VegaS™

I'm sorry for this guys, but if you want to fix it properly, that's the only solution, the rest is just a workaround.

Ok, I just tested right now with a default metin2 client and that's not a real 'beep', it's an 'Asterisk' sound from Windows and it comes from PythonApplication.cpp:

unsigned __GetWindowMode(bool windowed)
{
	if (windowed)
		return WS_OVERLAPPED | WS_CAPTION | WS_SYSMENU | WS_MINIMIZEBOX;

	return WS_POPUP;
}

If you remove WS_SYSMENU from the style, you won't get the sound anymore but you won't see the buttons and icon too.

UPDATE

Alright, after some debugging:

Here is a fast fix and should work fine, I didn't test it so well.

• UserInterface\PythonApplicationProcedure.cpp

Before: https://metin2.download/video/Oy3fg6R91i9BS2L98w35mUB54hTYJOhz/.mp4 (everywhere in the client)

After: https://metin2.download/video/iNrVA5EmXXKplT3P325pTJ896q6V2p8j/.mp4

I may be wrong, but that's a windows issue, not a metin2 one.

Keep it nice guys, that solution was posted 8 years ago.

game/src/constants.cpp

I didn't check the code, but the aiPolymorphPowerByLevel array it's missing a value by default, that one should be 0 when you've level 0 on the skill itself, then for level 1 (10), level 2 (11) [...].

It should be like this:

I can't test this right now in-game, but from a fast check, it seems that hide_horse_state command is sent from the server-side when you unsummon the horse, which is defined in interfaceModule.py as HideHorseState:

	def HideHorseState(self):
		self.affectShower.SetHorseState(0, 0, 0)

	def UpdateHorseState(self, level, health, battery):
		self.affectShower.SetHorseState(level, health, battery)

That means when you unsummon the horse, the SetHorseState function is called with (0, 0, 0) arguments, and there's a condition which check if the level is 0, then set the self.horseImage variable as a null value, without arrange the images.

So, in theory, we just need to call the __ArrangeImageList function after that, and it should be fine, the images will be sorted again.

• root/uiAffectShower.py

Search for the function:

	def SetHorseState(self, level, health, battery):
		[...]

Replace it with:

On 11/30/2021 at 3:31 AM, MyAnubis said:

Hi, I know it's been a long time but could someone find the solution? I would like to have this function during my ox

• Srcs/game/questlua_pc.cpp

namespace quest
{
	[...]
	int pc_is_cube_open(lua_State* L)
	{
		LPCHARACTER ch = CQuestManager::instance().GetCurrentCharacterPtr();
		lua_pushboolean(L, ch && ch->IsCubeOpen());
		return 1;
	}
	[...]
}
	
luaL_reg pc_functions[] =
{
	[...]
	{ "is_cube_open",	pc_is_cube_open	},
	[...]
}

• share/locale/country/quest/quest_functions

pc.is_cube_open

• your_quest.lua

if pc.is_cube_open() then
	say("CUBE_WINDOW_IS_OPEN")
	return
end

20 minutes ago, ReFresh said:

And if I want to add race index? I tried something like this and it doesn't work. I still cannot get how these tables works.

local job_items = 
{
	[0] = {	{15, 1},	{11205, 1},	{12205, 1} },
	[1] = {	{1005, 1},	{11405, 1},	{12345, 1} },
	[2] = {	{15, 1},	{11605, 1},	{12485, 1} },
	[3] = {	{7005, 1},	{11805, 1},	{12625, 1} },
}

local item_table = job_items[pc.get_job()]
if item_table ~= nil then
	for key, value in ipairs(item_table) do
		pc.give_item2(unpack(value))
	end
end

Just to know:

pc.give_item2(unpack(value))
-- equivalent to:
pc.give_item2(value[0], value[1])
-- equivalent to:
local vnum, count = unpack(value)
pc.give_item2(vnum, count)

23 minutes ago, ReFresh said:

			for i = 1, table.getn(same_items) do
			pc.give_item2(same_items[pc.countitem()])

 

It should be like this:

for key, value in ipairs(same_items) do
	pc.give_item2(unpack(value))
end

9 minutes ago, MrQuin said:

Just remove:

				if app.IsPressed(app.DIK_LALT):
					link = chat.GetLinkFromHyperlink(hyperlink)
					ime.PasteString(link)
				else:

from both game.py->def OnMouseLeftButtonUp(self): & uiChat.py->class ChatLogWindow->def OnMouseLeftButtonDown(self):

2 hours ago, VegaS™ said:

imePasteString and chatGetLinkFromHyperlink is responsible for this.

Here you have a small tutorial on how to disable it:

Glass of Insight - block using on shout chat - Questions & Answers - Metin2 Dev

imePasteString and chatGetLinkFromHyperlink is responsible for this.

Here you have a small tutorial on how to disable it:

2 hours ago, blaxis said:

TItemPos Cell;
BYTE window_type = Cell.window_type;
if (MALL == window_type)
{
	[...]
}

 

It won't work because you just initialized the structure with the default values from the constructor, which means window_type will be always INVENTORY

You already have the GetWindow function inside of CItem class, you can use it like this:

if (MALL == item->GetWindow())
{
	[...]
}

Or if you really want to use TItemPos and the functions from it, you must initialize it properly:

const TItemPos Cell(item->GetWindow(), item->GetCell());

Quote

1>PythonNetworkStreamPhaseGame.cpp(xxxx): warning C4172: returning address of local variable or temporary

or:

That's a small tip for the next time when you're coding, so you'll know if it's a critical warning and it needs real attention or not, based on the level.

https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings

I will update the repo when I will have some free time, right now I'm very busy with the university and the job.
For those who want to contribute to it, you can do a pull request in the GitHub repository.

On 9/28/2021 at 4:09 PM, narcisxb said:

0928 16:03:21685 :: TypeError
0928 16:03:21685 :: : 
0928 16:03:21685 :: 'GridSlotWindow' object does not support indexing
0928 16:03:21685 :: 

self.wndItem[itemSlotIndex].SetChangerImage()

self.wndItem it's an object, basically a class (GridSlotWindow), not a list/tuple/dict [...], that means it doesn't have a __getitem__ method implemented by default.

So, you should replace that line with a simple call as a member function from an instance:

self.wndItem.SetChangerImage()

The function must be implemented in ui.py inside of class GridSlotWindow.

Seems that your 'system' is incomplete.

But based on the function name, I think it's changing the base image of the slot, so you can try to add something like this:

Of course, you've to change the image path based on your needs.

On 5/8/2021 at 11:47 AM, DragonBlack94 said:

quest Carta_mostro begin
	state start begin
	
		when 50283.use begin
			say_title ( "Carta Mostro:")
			say ( "Questo e' la carta mostro, vuoi aprirla?" )
			local yesno = select ( "Apri" , "Non aprire" )
				pc.removeitem(50283,1)
				local dragon = number(1,4)
				local dragon1 = number(2,5)
				local dragon2 = {102,103,104,105}
				mob_vnum(dragon2[dragon],dragon1)
				end
			end
		end

Try this:

Hi, thanks for the release, but you don't need any extra function, you just need to select the change look vnum.

item.SelectItem(changelookVnum)
valu3 = item.GetValue(3)

# Set selected item as the old one because it's used later in other conditions
item.SelectItem(oldItemVnum)

1 hour ago, Karbust said:

				elif itemSubType == item.COSTUME_TYPE_HAIR: #Hair 
					if self.__ItemGetRace() == player.GetRace():
						itemVnum_prv = itemVnum
						if app.ENABLE_CHANGE_LOOK_SYSTEM and getChangelookVnum:
							itemVnum_prv = getChangelookVnum
							self.__ModelPreview(item.GetValueByVnum(3, itemVnum_prv), 1, player.GetRace())
						else:
							self.__ModelPreview(item.GetValue(3), 1, player.GetRace())

 

So, the code should looks like:

				elif itemSubType == item.COSTUME_TYPE_HAIR:
					if self.__ItemGetRace() == player.GetRace():
						value3 = item.GetValue(3)
						if app.ENABLE_CHANGE_LOOK_SYSTEM and getChangelookVnum:
							item.SelectItem(getChangelookVnum)
							value3 = item.GetValue(3)

						self.__ModelPreview(value3, 1, player.GetRace())
						item.SelectItem(itemVnum)

Powered by Core X