fix Guild & Party Core Downer

[Matteo 69]

Hi guys,

It's maybe released somewhere else, but i ran into this with 300-400 player on my server and one of them injected a little python script which invites mobs or npcs into guild and party or forces guild skills on mobs or npcs. If that happens the core will crash since there is no checks for that.

 

input_main.cpp

 

Find in case GUILD_SUBHEADER_CG_ADD_MEMBER::

if (!ch->IsPC())

Replace:

if (!ch->IsPC() || !newmember->IsPC())

 

 

Find in CInputMain::PartyUseSkill:

if (pch)
	ch->GetParty()->SummonToLeader(pch->GetPlayerID());

Replace:

if (pch)
{
	if (pch->IsPC())
		ch->GetParty()->SummonToLeader(pch->GetPlayerID());
}

 

 

Add at the beginning of the CInputMain::PartyInvite function:

if (!ch)
	return;

In the same function find:

if (!pInvitee || !ch->GetDesc() || !pInvitee->GetDesc())

Replace:

if (!pInvitee || !ch->GetDesc() || !pInvitee->GetDesc() || !pInvitee->IsPC() || !ch->IsPC())

 

 

Add at the beginning of the CInputMain::PartyInviteAnswer function:

if (!ch)
	return;

In the same function find:

if (!pInviter)

Replace:

if (!pInviter || !pInviter->IsPC())

 

Have a nice day!

 

[Defacer35 23]

Thank you very much.

[Flourine 136]

That is already known

 

Edited March 6, 2020 by Flourine

[ManiacRobert 488]

 

if (pch && pch->IsPC())
	ch->GetParty()->SummonToLeader(pch->GetPlayerID());

 

[Helia01 3405]

This is a very old bug. But thanks anyway.

[MariusExygo 1481]

This is from 2017