fix Little Fix About AutoGiveItem

[Mali 61380]

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited March 14, 2023 by Mali

[MariusExygo 1481]

if (inv_item->GetType() == ITEM_BLEND && inv_item->GetVnum() == item->GetVnum())
{
	if (inv_item->GetCount() + item->GetCount() <= ITEM_MAX_COUNT && FN_compare_item_socket(inv_item, item))
    {
		inv_item->SetCount(inv_item->GetCount() + item->GetCount());
  		return inv_item;
	}
}

 

[VegaS™ 13082]

For those who need FN_compare_item_socket function and also with fixed 'memory leak' which already is public.

• Srcs/game/src/char_item.cpp

1.0) Add at the beginning of file:

static bool FN_compare_item_socket(const LPITEM pkItemSrc, const LPITEM pkItemDest)
{
	if (!pkItemSrc || !pkItemDest)
		return false;

	return memcmp(pkItemSrc->GetSockets(), pkItemDest->GetSockets(), sizeof(long) * ITEM_SOCKET_MAX_NUM) == 0;
}

2.0) Search for:

Spoiler

			if (inv_item->GetType() == ITEM_BLEND)
			{
				if (inv_item->GetVnum() == item->GetVnum())
				{
					if (inv_item->GetSocket(0) == item->GetSocket(0) &&
							inv_item->GetSocket(1) == item->GetSocket(1) &&
							inv_item->GetSocket(2) == item->GetSocket(2) &&
							inv_item->GetCount() < ITEM_MAX_COUNT)
					{
						inv_item->SetCount(inv_item->GetCount() + item->GetCount());
						return inv_item;
					}
				}
			}

 

 

2.1) Replace it with:

This is the hidden content, please

• Sign In
• or
• Sign Up

 

Edited December 3, 2020 by VegaS™

[MariusExygo 1481]

15 hours ago, VegaS™ said:

For those who need FN_compare_item_socket function and also with fixed memory leak which already is public.

 

 

Where is the memory leak exactly ? There are just 2 LPITEM pointers entering in the function arguments, there is no "new" operator there ..

Maybe you were reffering to the memory leak of the blend item load function.

 

 

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mali 61380]

51 minutes ago, Exygo said:

 

Where is the memory leak exactly ? There are just 2 LPITEM pointers entering in the function arguments, there is no "new" operator there ..

Maybe you were reffering to the memory leak of the blend item load function.

 

 

He is talking about this topic

Actually there isn't a real memory leak there. Because CreateItem function is creating new CItem() and saving object to the m_VIDMap.

And look what is going on there

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Sherer 614]

3 hours ago, Mali61 said:

He is talking about this topic

Actually there isn't a real memory leak there. Because CreateItem function is creating new CItem() and saving object to the m_VIDMap.

And look what is going on there

 

Still, better to keep unused object deleted rather than keep them scrapping in memory.

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mali 61380]

3 minutes ago, Sherer said:

Still, better to keep unused object deleted rather than keep them scrapping in memory.

That is why I said there isn't a real memory leak there

[Sebypunct 24]

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[MariusExygo 1481]

by the way memcmp it's not for comparing item socket

 

sadly ..

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mali 61380]

26 minutes ago, Exygo said:

by the way memcmp it's not for comparing item socket

 

sadly ..

because memcmp usage is wrong, must be 0 if equals

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[MariusExygo 1481]

no, the problem is that memcmp must not be used to compare item socket ..

[VegaS™ 13082]

31 minutes ago, Exygo said:

by the way memcmp it's not for comparing item socket

https://en.cppreference.com/w/cpp/string/byte/memcmp

#define ITEM_SOCKET_MAX_NUM 3

int main()
{
	long lSockets[ITEM_SOCKET_MAX_NUM] = { 1, 2, 3 };
	long lSockets2[ITEM_SOCKET_MAX_NUM] = { 1, 2, 3 };
	cout << (memcmp(lSockets, lSockets2, sizeof(long) * ITEM_SOCKET_MAX_NUM) == 0) << endl;
	return 0;
}
//>> 1

 

Edited March 26, 2020 by VegaS™

[Mali 61380]

3 minutes ago, Exygo said:

no, the problem is that memcmp must not be used to compare item socket ..

db/Cache.cpp - OnFlush()

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[MariusExygo 1481]

You don't need to post another example, I just gaved you one directly from the game.

[Sherer 614]

21 hours ago, Mali61 said:

That is why I said there isn't a real memory leak there

Nowadays with so many system collectors (like built-in unix/windows) there isn't a real memory leak at all.

On the other hand if you keep stacking those unused items, memory will may grow to ridiculous values.

Same outcome you are going to have because of classic memory leak - a lot of memory is allocated most of them is junked.

[66Dragon99 297]

sounds fun thanks for the topic. 00

have you seen the CSafebox::ChangeSize memory leak?

Edited October 24, 2020 by 66Dragon99