Buffs to All Party Members

[serex 465]

M2 Download Center

This is the hidden content, please

• Sign In
• or
• Sign Up

( Internal )

 

 

char_skill.cpp search:

	if (IS_SET(pkSk->dwFlag, SKILL_FLAG_SELFONLY))
		ComputeSkill(dwVnum, this);

add before:

	//Party buff system
	if (GetParty() && (dwVnum == 94 || dwVnum == 95 || dwVnum == 96 || dwVnum == 110 || dwVnum == 111))
	{
		if (pkVictim->GetParty()){
			if (pkVictim->GetParty() == GetParty()){
				ComputeSkillParty(dwVnum, this);
			}
		}
	}

 

[Zeph 8]

Dnia 9.01.2019 o 16:54, serex napisał:

 

 

char_skill.cpp search:

	if (IS_SET(pkSk->dwFlag, SKILL_FLAG_SELFONLY))
		ComputeSkill(dwVnum, this);

add before:

	//Party buff system
	if (GetParty() && (dwVnum == 94 || dwVnum == 95 || dwVnum == 96 || dwVnum == 110 || dwVnum == 111))
	{
		if (pkVictim->GetParty()){
			if (pkVictim->GetParty() == GetParty()){
				ComputeSkillParty(dwVnum, this);
			}
		}
	}

 

Hello bro, i don't have "ComputeSkillParty" function in my source so.. can you give me this?

I changed this to "ComputeSkill" but i can buff only on 2 players on group.

[ManiacRobert 488]

Acum 11 ore, Zeph a spus:

Hello bro, i don't have "ComputeSkillParty" function in my source so.. can you give me this?

I changed this to "ComputeSkill" but i can buff only on 2 players on group.

search on wolfman branch

[Zeph 8]

7 godzin temu, ManiacRobert napisał:

search on wolfman branch

I download source from this topic: 

But i can't find this there, can you help me?

In "dev_wolf_branch" i can't find there too ;/

[serex 465]

En 19/1/2019 a las 17:47, Zeph dijo:

Hello bro, i don't have "ComputeSkillParty" function in my source so.. can you give me this?

I changed this to "ComputeSkill" but i can buff only on 2 players on group.

struct FComputeSkillParty
{
	FComputeSkillParty(DWORD dwVnum, LPCHARACTER pkAttacker, BYTE bSkillLevel = 0)
		: m_dwVnum(dwVnum), m_pkAttacker(pkAttacker), m_bSkillLevel(bSkillLevel)
		{
		}

	void operator () (LPCHARACTER ch)
	{
		m_pkAttacker->ComputeSkill(m_dwVnum, ch, m_bSkillLevel);
	}

	DWORD m_dwVnum;
	LPCHARACTER m_pkAttacker;
	BYTE m_bSkillLevel;
};

int CHARACTER::ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel)
{
	FComputeSkillParty f(dwVnum, pkVictim, bSkillLevel);
	if (GetParty() && GetParty()->GetNearMemberCount())
		GetParty()->ForEachNearMember(f);
	else
		f(this);

	return BATTLE_NONE;
}

 

[Zeph 8]

Dnia 21.01.2019 o 11:21, serex napisał:

struct FComputeSkillParty
{
	FComputeSkillParty(DWORD dwVnum, LPCHARACTER pkAttacker, BYTE bSkillLevel = 0)
		: m_dwVnum(dwVnum), m_pkAttacker(pkAttacker), m_bSkillLevel(bSkillLevel)
		{
		}

	void operator () (LPCHARACTER ch)
	{
		m_pkAttacker->ComputeSkill(m_dwVnum, ch, m_bSkillLevel);
	}

	DWORD m_dwVnum;
	LPCHARACTER m_pkAttacker;
	BYTE m_bSkillLevel;
};

int CHARACTER::ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel)
{
	FComputeSkillParty f(dwVnum, pkVictim, bSkillLevel);
	if (GetParty() && GetParty()->GetNearMemberCount())
		GetParty()->ForEachNearMember(f);
	else
		f(this);

	return BATTLE_NONE;
}

 

Thank you

[r00t3r 68]

after tests is doing crash core, but i don`t know why

[VegaS™ 13082]

1 hour ago, sonyc73 said:

after tests is doing crash core, but i don`t know why

There's no check for victim pointer.

// Replace:
if (pkVictim->GetParty())
// With:
if (pkVictim && pkVictim->GetParty())

 

[Criminus 669]

 

Solved:

in char.h i had the macro for wolfman:

#ifdef ENABLE_WOLFMAN_CHARACTER
        int                    ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel = 0);
#endif

Edited August 21, 2022 by Metin2 Dev
Core X - External 2 Internal

[r00t3r 68]

La 26.09.2019 la 1:05, VegaS™ a spus:

There's no check for victim pointer.

// Replace:
if (pkVictim->GetParty())
// With:
if (pkVictim && pkVictim->GetParty())

 

Thx Vegas, is ok now !

[Metin2 Dev 12235]

On 1/19/2019 at 5:47 PM, Zeph said:

//Party buff system if (GetParty() && (dwVnum == 94 || dwVnum == 95 || dwVnum == 96 || dwVnum == 110 || dwVnum == 111)) { if (pkVictim->GetParty()){ if (pkVictim->GetParty() == GetParty()){ ComputeSkillParty(dwVnum, this); } } }

If you add this, you can give buffs to people who are not in your group:
 

	if (GetParty() && (dwVnum == 94 || dwVnum == 95 || dwVnum == 96 || dwVnum == 109 || dwVnum == 110 || dwVnum == 111))
	{
		if (pkVictim && pkVictim->GetParty())
		{
			if (pkVictim->GetParty() == GetParty())
			{
				if (GetParty()->GetNearMemberCount())
					ComputeSkillParty(dwVnum, this);
				else
					ComputeSkill(dwVnum, pkVictim);
			}
			else
				ComputeSkill(dwVnum, pkVictim);
		}
		else if (pkVictim && !pkVictim->GetParty())
		{
			ComputeSkill(dwVnum, pkVictim);
		}
	}

 

Edited June 1, 2020 by M2Dev
You can give buffs yourself, if dont have near members on party

[Paulo 8]

I really want to use this buff function, but it doesn't work because of the error

[dawnofthedead15 7]

im getting this error

char_skill.cpp:2688:33: error: qualified-id in declaration before '(' token
 2688 | int CHARACTER::ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel)

[xabugas123 1]

works fine thx

[Resist0 37]

Works fine thanks, how can i remove the range for buff ?

[Tuckii 21]

It doens't seem to work for me, tried computeskillparty withoput party, tried with struct and everything possible I think

https://metin2.download/picture/h6S17UrA171NZ8oRB4n8rSJoWVtC6Jfc/.png

Edited September 11, 2022 by Metin2 Dev
Core X - External 2 Internal

[marinebun 46]

when i compile the game i have the following errors:

Edited April 22, 2023 by marinebun

[Mitachi 3366]

I did a small refactory, not tested yet:

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited December 10, 2023 by Mitachi

[im4x8061 1]

Thanks for sharing!

This might be a stupid question, but when you look at the definition of `int CHARACTER::ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel)`, it  expects 3 input arguments, but you called it with only two arguments: `ComputeSkillParty(dwVnum, this);`
Did I miss something? Wouldn't  `BYTE bSkillLevel = GetSkillLevel(dwVnum); for calling it again like `ComputeSkillParty(dwVnum, this,bSkillLevel);` be required?

Thanks in advance!

[Mitachi 3366]

On 1/3/2025 at 12:26 PM, im4x8061 said:

Thanks for sharing!

This might be a stupid question, but when you look at the definition of `int CHARACTER::ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel)`, it  expects 3 input arguments, but you called it with only two arguments: `ComputeSkillParty(dwVnum, this);`
Did I miss something? Wouldn't  `BYTE bSkillLevel = GetSkillLevel(dwVnum); for calling it again like `ComputeSkillParty(dwVnum, this,bSkillLevel);` be required?

Thanks in advance!

In the declaration, bSkillLevel is initialized to 0:

int ComputeSkillParty(DWORD dwVnum, LPCHARACTER pkVictim, BYTE bSkillLevel = 0);

This means that you can avoid passing the 3rd param, 'cause it will be automatically filled with 0.

Then, call ::ComputeSkill, which in case of (0 == bSkillLevel) will already call ::GetSkillLevel:

// from ::ComputeSkill(..)
	if (0 == bSkillLevel)
	{
		if ((bSkillLevel = GetSkillLevel(pkSk->dwVnum)) == 0)
		{
			if (test_server)
				sys_log(0, "ComputeSkill : name:%s vnum:%d  skillLevelBySkill : %d ", GetName(), pkSk->dwVnum, bSkillLevel);
			return BATTLE_NONE;
		}
	}

Don't worry, you can always ask questions, that's what the forum is for

[JacksonKing 0]

Hi,

I downloaded the files and modified char.h and char_skill.cpp, but it only will buff the target and the caster, or just the caster if I target myself.

I don't have the Lycan, just 4 classes

Thanks