DoS vulnerability (invalid player id spam)

[LTGT 934]

This is a fix for a DoS Vulnerability where invalid player ids are spammed (i.e. HEADER_CG_CHARACTER_SELECT),

you can confirm this by looking in the syslog for a bunch of [PLAYER_LOAD] Load from PlayerDB pid[0].

 

to fix this:

This is the hidden content, please

• Sign In
• or
• Sign Up

 

 

this fix will make sure the player gets disconnected upon choosing an invalid character, making it harder to spam and making rate limits effective again

Thanks to everyone from sura-head.

Edited November 12, 2022 by LTGT
added support for different packets

[Amun 1128]

What's dumb is that they checked for the PID when deleting a player

	if (!c_rAccountTable.players[pinfo->index].dwID)
	{
		sys_err("PlayerDelete: Wrong Social ID index %d, login: %s", pinfo->index, c_rAccountTable.login);
		d->Packet(encode_byte(HEADER_GC_CHARACTER_DELETE_WRONG_SOCIAL_ID), 1);
		return;
	}

but they didn't check when selecting it(they've done the same shit in ::ChangeName, the method above ::CharacterSelect).

I advise you to check all packets using indexes sent by the client, because it's not just the one @ LTGT posted.

[LTGT 934]

5 hours ago, Amun said:

What's dumb is that they checked for the PID when deleting a player

	if (!c_rAccountTable.players[pinfo->index].dwID)
	{
		sys_err("PlayerDelete: Wrong Social ID index %d, login: %s", pinfo->index, c_rAccountTable.login);
		d->Packet(encode_byte(HEADER_GC_CHARACTER_DELETE_WRONG_SOCIAL_ID), 1);
		return;
	}

but they didn't check when selecting it(they've done the same shit in ::ChangeName, the method above ::CharacterSelect).

I advise you to check all packets using indexes sent by the client, because it's not just the one @ LTGT posted.

Main post has been adjusted to support them as well.

[ReFresh 1756]

@ LTGTJust a little detail... there isn't any player_index variable.

One step in your tutorial must look like this:

This is the hidden content, please

• Sign In
• or
• Sign Up

[Denizeri24 28]

Edited November 13, 2022 by Metin2 Dev
Core X - External 2 Internal

[Helia01 1487]

On 11/13/2022 at 4:24 AM, Denizeri24 said:

Edited November 29, 2022 by Helia01