fix Fix refine proto 5th item

[Istny 93]

Fix allow you to use vnum4 in refine_proto

 

Explanation:

By default refine materials are beign loaded until vnumx == 0, but if you assign item to the last socket, material_count will never be assigned. As a result material_count will remain 0, despite 5 material items being set.

Adding simple additional check solves this problem

 

Open db/ClientManagerBoot.cpp

replace

for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
{
	str_to_number(prt->materials[i].vnum, data[col++]);
	str_to_number(prt->materials[i].count, data[col++]);
	if (prt->materials[i].vnum == 0)
	{
		prt->material_count = i;
		break;
	}
}

 

with

for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
{
	str_to_number(prt->materials[i].vnum, data[col++]);
	str_to_number(prt->materials[i].count, data[col++]);
	if (prt->materials[i].vnum == 0)
	{
		prt->material_count = i;
		break;
	} 
	else if (i+1 == REFINE_MATERIAL_MAX_NUM)
	{
		prt->material_count = REFINE_MATERIAL_MAX_NUM;
		break;
	}
}

 

final result

   

 

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Syreldar 2739]

The answer below is correct. I need some sleep.

Edited December 7, 2020 by Syreldar

[Sonitex 1676]

		BYTE material_count = 0;
		for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
		{
			str_to_number(prt->materials[i].vnum, data[col++]);
			str_to_number(prt->materials[i].count, data[col++]);

			if (prt->materials[i].vnum)
				material_count++;
		}

		prt->material_count = material_count;

 

Issue is how they approached counting in the first place. When the loop hits a vnum equal to zero, material count was assigned based on current loop index which means if you had 5 slots occupied you would never hit an empty slot which is why material count would be always zero. By extending the loop you would also need to extend mysql columns which does nothing in this case. 

Edited December 7, 2020 by Sonitex
Wrong data type :/

[Istny 93]

9 minutes ago, Sonitex said:

		BYTE material_count = 0;
		for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
		{
			str_to_number(prt->materials[i].vnum, data[col++]);
			str_to_number(prt->materials[i].count, data[col++]);

			if (prt->materials[i].vnum)
				material_count++;
		}

		prt->material_count = material_count;

 

Issue is how they approached counting in the first place. When the loop hits a vnum equal to zero, material count was assigned based on current loop index which means if you had 5 slots occupied you would never hit an empty slot which is why material count would be always zero. By extending the loop you would also need to extend mysql columns which does nothing in this case. 

 

Cleaner, only downside is, if someone for unknow reason will have for example socket3 set to 0 and socket4 to 11 loop in CHARACTER::DoRefine will use value frome socket3 as material vnum which is 0. Summarazing don't do a mess and you are good to go 

[Sonitex 1676]

8 minutes ago, Istny said:

 

Cleaner, only downside is, if someone for unknow reason will have for example socket3 set to 0 and socket4 to 11 loop in CHARACTER::DoRefine will use value frome socket3 as material vnum which is 0. Summarazing don't do a mess and you are good to go 

 

Yeah but it goes both ways. Before if you set a value for socket0, left socket1 empty and set socket2, 3rd socket would be ignored. But as you said, you need a bit more precision & focus when doing things like that.

Edited December 7, 2020 by Sonitex

[meneleos 406]

		prt->material_count = 0;
		for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
		{
			str_to_number(prt->materials[i].vnum, data[col++]);
			str_to_number(prt->materials[i].count, data[col++]);
			if (prt->materials[i].vnum != 0)
				prt->material_count++;
		}

 

Edited December 7, 2020 by meneleos

[Mystik 0]

i have the follow problem,

when i go to refine for exemple, sword +8 to sword +9 he shows the probability in the place of vnum, and in the probability of refine shows 0

some help?

[Distraught 10026]

prt->material_count = 0;
for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
{
	str_to_number(prt->materials[i].vnum, data[col++]);
	str_to_number(prt->materials[i].count, data[col++]);
	
	if (prt->materials[i].vnum == 0)
		break;
  
	prt->material_count++;
}

Writing this makes the code logic more clear and easier to follow.

 

  

On 12/7/2020 at 8:43 PM, Sonitex said:

		BYTE material_count = 0;
		for (int i = 0; i < REFINE_MATERIAL_MAX_NUM; i++)
		{
			str_to_number(prt->materials[i].vnum, data[col++]);
			str_to_number(prt->materials[i].count, data[col++]);

			if (prt->materials[i].vnum)
				material_count++;
		}

		prt->material_count = material_count;

 

Issue is how they approached counting in the first place. When the loop hits a vnum equal to zero, material count was assigned based on current loop index which means if you had 5 slots occupied you would never hit an empty slot which is why material count would be always zero. By extending the loop you would also need to extend mysql columns which does nothing in this case. 

Try setting for example an item for the first and third slot while leaving the second one 0.

Edited July 20, 2025 by Distraught

[Sonitex 1676]

15 hours ago, Distraught said:

Try setting for example an item for the first and third slot while leaving the second one 0.

Edited July 20, 2025 by Metin2 Dev International
Core X - External 2 Internal