Reimplementation of Events

[Sherer 614]

M2 Download Center

This is the hidden content, please

• Sign In
• or
• Sign Up

( Internal )

Hello,

 

Working on some new stuff I found out that current implementation of event looks a bit tricky.

Due to this fact I basically deciced to re-implement it in C++11 providing up to date tech.

Don`t forget to take a look at this topic before you start:

https://metin2dev.org/board/index.php?/topic/305-src-compile-with-gcc48-c11-and-optimized-flags/

So lets begin.

Add include into the main.cpp:

#ifdef __NEW_EVENT_HANDLER__
	#include "EventFunctionHandler.h"
#endif

And add this into main function before:

while (idle());

	#ifdef __NEW_EVENT_HANDLER__
		CEventFunctionHandler EventFunctionHandler;
	#endif

Now add this at the end of idle:

	#ifdef __NEW_EVENT_HANDLER__
		CEventFunctionHandler::instance().Process();
	#endif

Now search for:

sys_log(0, "<shutdown> Destroying CArenaManager...");

And add before:

	#ifdef __NEW_EVENT_HANDLER__
		sys_log(0, "<shutdown> Destroying CEventFunctionHandler...");
		CEventFunctionHandler::instance().Destroy();
	#endif

Now open service.h and add this define:

#define __NEW_EVENT_HANDLER__

That`s all.

Now just download attachment and add included files to your source.

[Салом 21]

@Sherer  We can not open the attachment file. Please upload the files to an external site (Mega/dropbox)

[Sherer 614]

50 minut temu, Салом napisał:

@Sherer  We can not open the attachment file. Please upload the files to an external site (Mega/dropbox)

Added

[Mali 61377]

Nice :')

[Tasho 275]

	#ifdef __NEW_EVENT_HANDLER__
		CEventFunctionHandler EventFunctionHandler;
	#endif

That doesn't need to exist, but if someone really want to use:

Search for:

• CEventFunctionHandler::instance().Process();

Replace with:

• EventFunctionHandler.Process();

Thanks for release, i like that structure, keep up the good work.

[Sherer 614]

2 godziny temu, Tasho napisał:

	#ifdef __NEW_EVENT_HANDLER__
		CEventFunctionHandler EventFunctionHandler;
	#endif

That doesn't need to exist, but if someone really want to use:

Search for:

• CEventFunctionHandler::instance().Process();

Replace with:

• EventFunctionHandler.Process();

Thanks for release, i like that structure, keep up the good work.

Indeed. It is just singleton initial call.

[Sherer 614]

Reupload (cannot edit thread):
https://gofile.io/?c=ZZuJVu

[CenkAksu 0]

hello @Sherer realy nice post! Can you reupload the files please?

[Mali 61377]

This is the hidden content, please

• Sign In
• or
• Sign Up

[Mafuyu 56]

REUPLOAD AMK

[Mali 61377]

40 minutes ago, Mafuyu said:

REUPLOAD AMK

Why are you cursing for no reason?

Link is at the top of the topic. You might want to go for an eye checkup.

Edited April 13, 2021 by Mali61

[Mafuyu 56]

2 minutes ago, Mali61 said:

Why are you cursing for no reason?

Link is at the top of the topic. You might want to go for an eye checkup.

 

big brain i wouldnt cry if it would be that simple my guuuuy

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mali 61377]

2 minutes ago, Mafuyu said:

 

big brain i wouldnt cry if it would be that simple my guuuuy

The link is broken = I have to swear

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mafuyu 56]

Just now, Mali61 said:

The link is broken = I have to swear

is this some "only paid user can access this website" shit?

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Geoffrey 9329]

4 minutes ago, Mafuyu said:

 

big brain i wouldnt cry if it would be that simple my guuuuy

What browser are you using?

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mafuyu 56]

3 minutes ago, ASIKOO said:

What browser are you using?

Im using opera gx

 

€dit: website is getting blocked because of some trojans out there (malwarebytes detecting it)

 

ffs

Edited April 13, 2021 by Mafuyu

[Geoffrey 9329]

2 minutes ago, Mafuyu said:

Im using opera gx

I do not understand, are you using a VPN? Proxy?

[Mafuyu 56]

1 minute ago, ASIKOO said:

I do not understand, are you using a VPN? Proxy?

no, website is getting blocked by malwarebytes because of trojan detection. I turned it off then it worked^^

Edited April 13, 2021 by Mafuyu

[Geoffrey 9329]

1 minute ago, Mafuyu said:

no, website is getting blocked by malwarebytes because of trojan detection. I turned it off then it worked^^

Hm.. Okay

[martysama0134 10746]

Some people requested me to refactor this library for c++20 without invalidating the old syntax.

This is the hidden content, please

• Sign In
• or
• Sign Up

This is the hidden content, please

• Sign In
• or
• Sign Up

Here are the changes:

• changed std::string_view instead of std::string handling
• changed std::unordered_map instead of std::map
• supported new foreach pair syntax
• added missing const-ness
• rewritten CEventFunctionHandler::Process with std::erase_if
• replaced copy with impactless move for std::function
• removed Destroy() from destructor because unneeded for std containers
• removed SupportArg
• added looped events
• removed ProcessStatus
• disabled DelayEvent for looped events

 

The usage is remained unchanged, except the support for looped timers.

	// Create the event and call it after 5 seconds. Using "this" as argument is safe only if it's a singleton, for CHARACTER or CItem, use their vid and find them inside the lambda.
	CEventFunctionHandler::instance().AddEvent([this](SArgumentSupportImpl*) {
			this->SendNotificationToAll();
		}, "MY_BEAUTIFUL_EVENT", std::chrono::seconds(5).count()
	);

	// Create the event and loop it every 5 minutes. Don't forget, keys already existing will be skipped, such as this one.
	CEventFunctionHandler::instance().AddEvent([this](SArgumentSupportImpl*) {
			this->SendNotificationToAll();
		}, "MY_BEAUTIFUL_EVENT", std::chrono::minutes(5).count(), true
	);

	// Check if it exists, then delay it again by 5s. Don't forget, DelayEvent has no effect to looped events.
	if (CEventFunctionHandler::instance().FindEvent("MY_BEAUTIFUL_EVENT"))
		CEventFunctionHandler::Instance().DelayEvent("MY_BEAUTIFUL_EVENT", std::chrono::seconds(5).count());

	// Cancel the event. Safe even if the key doesn't exist.
	CEventFunctionHandler::Instance().RemoveEvent("MY_BEAUTIFUL_EVENT");

 

[BadRomani 170]

On 10/14/2024 at 2:03 AM, martysama0134 said:

Some people requested me to refactor this library for c++20 without invalidating the old syntax.

This is the hidden content, please

• Sign In
• or
• Sign Up

This is the hidden content, please

• Sign In
• or
• Sign Up

Here are the changes:

• changed std::string_view instead of std::string handling
• changed std::unordered_map instead of std::map
• supported new foreach pair syntax
• added missing const-ness
• rewritten CEventFunctionHandler::Process with std::erase_if
• replaced copy with impactless move for std::function
• removed Destroy() from destructor because unneeded for std containers
• removed SupportArg
• added looped events
• removed ProcessStatus
• disabled DelayEvent for looped events

 

The usage is remained unchanged, except the support for looped timers.

	// Create the event and call it after 5 seconds. Using "this" as argument is safe only if it's a singleton, for CHARACTER or CItem, use their vid and find them inside the lambda.
	CEventFunctionHandler::instance().AddEvent([this](SArgumentSupportImpl*) {
			this->SendNotificationToAll();
		}, "MY_BEAUTIFUL_EVENT", std::chrono::seconds(5).count()
	);

	// Create the event and loop it every 5 minutes. Don't forget, keys already existing will be skipped, such as this one.
	CEventFunctionHandler::instance().AddEvent([this](SArgumentSupportImpl*) {
			this->SendNotificationToAll();
		}, "MY_BEAUTIFUL_EVENT", std::chrono::minutes(5).count(), true
	);

	// Check if it exists, then delay it again by 5s. Don't forget, DelayEvent has no effect to looped events.
	if (CEventFunctionHandler::instance().FindEvent("MY_BEAUTIFUL_EVENT"))
		CEventFunctionHandler::Instance().DelayEvent("MY_BEAUTIFUL_EVENT", std::chrono::seconds(5).count());

	// Cancel the event. Safe even if the key doesn't exist.
	CEventFunctionHandler::Instance().RemoveEvent("MY_BEAUTIFUL_EVENT");

 

CEventFunctionHandler::Instance().AddEvent([pkKiller](SArgumentSupportImpl*) { pkKiller->TimeOver(2); }, "DEMON_TOWER_EVENT", std::chrono::seconds(10).count());

A function was developed that sends me a message with WHISPER after 10 seconds. But it doesn't work. Can the LPCHARACTER pointer be used?

Example:

char_battle.cpp ::Dead -> pkKiller

Edited March 3, 2025 by BadRomani

[Distraught 9984]

On 3/3/2025 at 6:47 PM, BadRomani said:

CEventFunctionHandler::Instance().AddEvent([pkKiller](SArgumentSupportImpl*) { pkKiller->TimeOver(2); }, "DEMON_TOWER_EVENT", std::chrono::seconds(10).count());

A function was developed that sends me a message with WHISPER after 10 seconds. But it doesn't work. Can the LPCHARACTER pointer be used?

Example:

char_battle.cpp ::Dead -> pkKiller

Never capture pointers in lambdas if it's not called somewhere inside the function where you created it (like an std::for_each or something), by this I also mean capturing "this" or "&". If the object gets destroyed, it becomes a dangling pointer causing a crash when you dereference it.

Capture the PID instead and try to find the corresponding LPCHARACTER from CHARACTER_MANAGER.

Edited April 3, 2025 by Distraught

[BadRomani 170]

On 4/3/2025 at 10:18 PM, Distraught said:

Never capture pointers in lambdas if it's not called somewhere inside the function where you created it (like an std::for_each or something), by this I also mean capturing "this" or "&". If the object gets destroyed, it becomes a dangling pointer causing a crash when you dereference it.

Capture the PID instead and try to find the corresponding LPCHARACTER from CHARACTER_MANAGER.

Yes, I did that later. I tried to find the player's pid.