How To Use Pickup Motion

[Shisui 536]

Here's the correct guide on how2 pickup motion.

 

Spoiler

 

Firstly go to UserInterface/PythonCharacterModule.cpp and search for:

    PyModule_AddIntConstant(poModule, "NEW_AFFECT_DRAGON_SOUL_QUALIFIED",        CInstanceBase::NEW_AFFECT_DRAGON_SOUL_QUALIFIED);

add this function under it:

    PyModule_AddIntConstant(poModule, "MOTION_PICK_UP",                        CRaceMotionData::NAME_PICK_UP);

 

 

 

Secondly go to UserInterface/PythonPlayerInput.cpp and search for:

void CPythonPlayer::PickCloseItem()

  add this function:

    pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);

 

 

 

Thirdly go  to GameLib/ActorInstanceMotion.cpp and search for:

        case CRaceMotionData::NAME_SLAP_HURT_WITH_SHAMAN:

add this function under it:

        case CRaceMotionData::NAME_PICK_UP:

 

 

 

Fourthly go to GameLib/RaceManager.cpp and search for:

        s_kMap_stType_dwIndex.insert(std::map<std::string, DWORD>::value_type("SKILL5", CRaceMotionData::NAME_SKILL+125));

add this function under it:

        s_kMap_stType_dwIndex.insert(std::map<std::string, DWORD>::value_type("PICK_UP", CRaceMotionData::NAME_PICK_UP));

 

 

Fifthly go to GameLib/RaceMotionData.cpp and search for:

        case NAME_DIG:

add this function under it:

        case NAME_PICK_UP:

 

 

 

 

Sixthly go to GameLib/RaceMotionData.h and search for:

            NAME_JOY,

add this function under it:

            NAME_PICK_UP,

 

Compile it and you're good to go.

 

Now to finish this tutorial, go to root/playersettingmodule.py and search for:

def SetGeneralMotions(mode, folder):

add this function:

    chrmgr.RegisterCacheMotionData(mode,        chr.MOTION_PICK_UP,                "pick_up.msa")

 

Tutorial finished, have fun.

[MrLibya 703]

the problem is , this not really good for metin2

becous there too many items drops by mobs - stone ...

so every time when u want pick up the item it will take time , so this is very borring

[Shisui 536]

the problem is , this not really good for metin2

becous there too many items drops by mobs - stone ...

so every time when u want pick up the item it will take time , so this is very borring

​​Yeah...

That's why they don't use this, probably.

But if you click z many times, for example, the speed is the same as if you haven't this, but he looks like having an epileptic seizure.

Edited June 27, 2015 by Shisui

[Aerrow 42]

That's all? No need to add the gr2 animation?

[Necro 100]

That's all? No need to add the gr2 animation?

​GR2 Animation was made by Ymir long time ago

[flygun 356]

i did this long time ago ... and i talked to Denis about it ... then we came out with the same idea no need for all this waste of time of picking up items from ground ... but anyway good TUT 

[Galet 590]

Great ! However it's sad that we can use it because of the amount of items on the ground

[Shisui 536]

no need for all this waste of time of picking up items from ground

​The time of picking up is the same.

[Mentez 1]

It isn't good for pickup items, because there are few other motions - skills, sword etc. Pickup motion is good for flowers system.

[Sr.Agente 24]

very good tutorial, but i have a problem, when i use "z" i cant pick a item but i char make animation.
somebody can help me whit this error?

sorry for my bad inglês
 

Edited August 8, 2015 by Sr.Agente

[Sr.Agente 24]

very good tutorial, but i have a problem, when i use "z" i cant pick a item but i char make animation.
somebody can help me whit this error?

sorry for my bad inglês
 

[BUMP]

[Sr.Agente 24]

very good tutorial, but i have a problem, when i use "z" i cant pick a item but i char make animation.
somebody can help me whit this error?

sorry for my bad inglês
 

[BUMP]

[Roxas07 258]

I prefer add that

 

_{if (pkInstMain->IsAttacking()){ // if the player attack}

        _{}
        else{ // if the player don't attack
            pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);
        }}

Because use SPACE and Z at the same time, it's a very good usebug for speed attack x)

[Galet 590]

if (!__IsPlayerAttacking())
           pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);

22 minutes ago, Roxas07 said:

I prefer add that

 

_{if (pkInstMain->IsAttacking()){ // if the player attack}

        _{}
        else{ // if the player don't attack
            pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);
        }}

Because use SPACE and Z at the same time, it's a very good usebug for speed attack x)

It's completely untested but I think that the following code is maybe better

if (!__IsPlayerAttacking())
           pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);

Or maybe this one :

if (!pkInstMain->IsAttacking())
              pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);

But it's untested and it'll probably won't work as I don't know if "__IsPlayerAttacking" is declared or if the "!" must be placed before "pkInstMain" or before "IsAttacking()"

 

[Roxas07 258]

Yes you can do that also, the method return a boolean.

I made that like this because I add a chat log for say something to the player or something other

[Eigenartig 7]

thanks for release :B

[Pisti95 161]

Thanks, i will try this

[Draktharon 33]

Nice release but if u have to pick up 20, 30 items it's so slow Ahaha

[EnKor 48]

how to add command only to make animation?

[ReFresh 3151]

@EnKor It's a simple thing, you have to add the command to server source, then you simply call it by type this command in a chat. You can try to search on another forums, just type in google search somehing like: metin 2 add new emotion, animation. I believe you'll find some tutorial which you can follow to make a new command that you can call.

[EnKor 48]

6 hours ago, ReFresh said:

@EnKor It's a simple thing, you have to add the command to server source, then you simply call it by type this command in a chat. You can try to search on another forums, just type in google search somehing like: metin 2 add new emotion, animation. I believe you'll find some tutorial which you can follow to make a new command that you can call.

thankyou. i make it

[KolenMG 1124]

Hello, just to confirm that the above change is working. I've just tested it. the other two things provided are failing the build tho. But yea, with the below change (provided above in comments) you can avoid the Atack speed animation glitch / bug / exploit. 

 

if (!pkInstMain->IsAttacking()) pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);

[KolenMG 1124]

Coming back here with a solution for PickUP motion Spamming: 

 

Spoiler

void CPythonPlayer::PickCloseItem()
{
	static DWORD lastPickUpTime = 0;
	DWORD currentTime = GetTickCount();  // Get current system time (in milliseconds)

	CInstanceBase* pkInstMain = NEW_GetMainActorPtr();
	if (!pkInstMain)
		return;

	// 1000 milliseconds = 1 second delay to avoid retriggering the animation too soon
	if (!pkInstMain->IsAttacking() && (currentTime - lastPickUpTime > 1000))
	{
		pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);
		lastPickUpTime = currentTime;  // Update the last pick-up time
	}

	// Get the pixel position of the main character
	TPixelPosition kPPosMain;
	pkInstMain->NEW_GetPixelPosition(&kPPosMain);

	// Try to get the closest item
	DWORD dwItemID;
	CPythonItem& rkItem = CPythonItem::Instance();
	if (!rkItem.GetCloseItem(kPPosMain, &dwItemID, __GetPickableDistance()))
		return;

	// Send the click item packet to pick the item
	SendClickItemPacket(dwItemID);
}

 

Now, the animation is not playing until is finished. also, does not affect the Pickup trigger (You can spam the Z or ~ button). 

I've made this to work along with this release(Holding Z for Pickup): 

 Here's the final result when holding Z: https://metin2.download/picture/Mum9DcVS9tS1odgXzdMSyoEPS5c65Hfn/.gif (Similar result if you spam Z)

Of course, you can added other conditions like "IsWalking" and so on, to play the motion only if the character is staying and not running. 

Edited September 11, 2024 by Metin2 Dev International
Core X - External 2 Internal

[Nazox 473]

Thanks, I used another kind of fix I made years ago, which was similar to the one in the post, I'm still trying to get the function to be seen in another client, since it is only seen, for those who use the effect, I have tried copying other emotions from 0, and modifying several parts of the client src but so far without success, the truth that I like this kind of old contributions!

[KolenMG 1124]

On 9/11/2024 at 5:21 PM, KolenMG said:

Coming back here with a solution for PickUP motion Spamming: 

 

  Hide contents

void CPythonPlayer::PickCloseItem()
{
	static DWORD lastPickUpTime = 0;
	DWORD currentTime = GetTickCount();  // Get current system time (in milliseconds)

	CInstanceBase* pkInstMain = NEW_GetMainActorPtr();
	if (!pkInstMain)
		return;

	// 1000 milliseconds = 1 second delay to avoid retriggering the animation too soon
	if (!pkInstMain->IsAttacking() && (currentTime - lastPickUpTime > 1000))
	{
		pkInstMain->GetGraphicThingInstancePtr()->InterceptOnceMotion(CRaceMotionData::NAME_PICK_UP);
		lastPickUpTime = currentTime;  // Update the last pick-up time
	}

	// Get the pixel position of the main character
	TPixelPosition kPPosMain;
	pkInstMain->NEW_GetPixelPosition(&kPPosMain);

	// Try to get the closest item
	DWORD dwItemID;
	CPythonItem& rkItem = CPythonItem::Instance();
	if (!rkItem.GetCloseItem(kPPosMain, &dwItemID, __GetPickableDistance()))
		return;

	// Send the click item packet to pick the item
	SendClickItemPacket(dwItemID);
}

 

Now, the animation is not playing until is finished. also, does not affect the Pickup trigger (You can spam the Z or ~ button). 

I've made this to work along with this release(Holding Z for Pickup): 

 Here's the final result when holding Z: https://metin2.download/picture/Mum9DcVS9tS1odgXzdMSyoEPS5c65Hfn/.gif (Similar result if you spam Z)

Of course, you can added other conditions like "IsWalking" and so on, to play the motion only if the character is staying and not running. 

10 minutes ago I've found another bug (I hope is the last one). 

https://metin2.download/picture/RCPx86i9W2605oCb055cpEz4FH0oHGq7/.gif

In the fix that I've provided above, change 

 if (!pkInstMain->IsAttacking() && (currentTime - lastPickUpTime > 1000))

into the below

if (!pkInstMain->IsAttacking() && !pkInstMain->IsMountingHorse() && !(pkInstMain->IsFishing()) && (currentTime - lastPickUpTime > 1000))

I starting to think is not the best aesthetic solution since the line is starting to go bigger. but for above, I added fix for when you are mounted AND when you are fishing.  

Edited September 16, 2024 by KolenMG
Core X - External 2 Internal