[C++] Remove collision from mobs

[Papix 3801]

Hello community,

I needed to remove the collision from all the monsters and decided to share with you how to do it.

Anything included in mob_proto from vnum 101 to 99999 loses the collision.

Spoiler

 

The collision is removed, but when you are attacking it continues to exist.

Spoiler

 

Step by Step

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited March 18, 2023 by Papix

[ScriptMan 1486]

2 hours ago, Papix said:

Hello community,

I needed to remove the collision from all the monsters and decided to share with you how to do it.

Anything included in mob_proto from vnum 101 to 99999 loses the collision.

  Hide contents

 

The collision is removed, but when you are attacking it continues to exist.

  Reveal hidden contents

 

Step by Step

Hidden Content

• 
  
• #Binary
  @GameLib/ActorInstanceCollisionDetection.cpp
  
  After:

   

  BOOL CActorInstance::TestActorCollision(CActorInstance& rVictim)
  {
  	if (rVictim.IsDead())
  		return false;

  
  Add:

  #ifdef REMOVE_MOB_COLLISION
  	if (rVictim.GetRace() >= 101 && rVictim.GetRace() <= 99999 && !isAttacking())
  		return false;
  #endif

  
  @Locale_inc.h

  
  Add:

  #define REMOVE_MOB_COLLISION

   

 

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

[Metin2 Dev 4666]

1 hour ago, speze012 said:

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

The method I shared worked for me, I explained in the thread how the function works.

Instead of answering "WTF?" you could just say "this function is more efficient" and share your version.

I decided to share to help those who need it, I don't understand the point of that kind of comment.

Is it to try to come off as "superior"?

 

And if you want the function to work well, you must declare that 1 attack is not being made using !isAttacking()

Otherwise you will get something strange when choosing a target

Edited March 18, 2023 by Papix

[martysama0134 6939]

1 hour ago, speze012 said:

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

That check would remove IsAttacking, this is the correct one:

	if (rVictim.GetActorType() == TYPE_ENEMY && !isAttacking())
		return FALSE;

This check is only for mobs, so ignore npc/pet/door for now.

I haven't tested the code, so I have no idea if isAttacking would remain true for delayed attacks.

[Viello 49]

   

Client/Source/GameLib/ActorInstanceCollisionDetection.cpp

BOOL CActorInstance::TestActorCollision(CActorInstance & rVictim)

{

if(rVictim.IsEnemy() || rVictim.IsPoly() || rVictim.IsNPC())
        return FALSE;

I was using like that.

[WeedHex 626]

This crap because of the auto hunting?

[Mali 39422]

everyone shares a code , here is official reversed code for pets and shops:

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited March 18, 2023 by Mali

[Vaynz 1793]

I don't know why all the fuss over some lines of code. Congratulations for post the ideea is very good, and to the others who came up with other ideas.
If someone needs it, I have it like that.

There is a new verison:

In BOOL CActorInstance::IgnoreCollisionNew(CActorInstance& rkTarget), you can and new conditions.

This is the hidden content, please

• Sign In
• or
• Sign Up

 or 

This is the hidden content, please

• Sign In
• or
• Sign Up

[Metin2 Dev 4666]

2 hours ago, WeedHex said:

This crap because of the auto hunting?

no, because !isAttacking()

[Intel 731]

Since y'all shared:

	if(!rVictim.isAttacking() && !rVictim.IsUsingMovingSkill() && !rVictim.__IsAttackMotion() && !rVictim.__IsKnockDownMotion() && !rVictim.__IsStandUpMotion() && !isAttacking())
	{	
		if(!rVictim.IsDoor() && !rVictim.IsBoss() && !rVictim.IsPC())
			return FALSE;
	}

This way every NPC/Monster/Metinstone can be passed trough, unless monsters are attacking you (not when they are moving when aggro-ed), or you are attacking

Edited April 26, 2023 by Intel

[crewfire1337 28]

Bros..... I had the same error, tried to fix it for 7 hours (that was 1 week ago) and yesterday I saw this topic...

that was my bugfix before, but all your bugfixes in that way dont work!

DO right click on a monster (select a monster ) but run with a mount to a another group, the bug is not gone.

sometimes at a mount the character moves little bit forward i think if you attack.

	if (m_pkHorse)
	{
		if(rVictim.IsEnemy() || rVictim.IsPoly())
		{
			return FALSE;
		}
		else if(isAttacking())
		{
			return TRUE;
		}
	}

 

And this fix: dont works too guys..

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited May 6, 2023 by crewfire1337
wrong

[Mitachi 1316]

It's amazing the follow up to this post, when one releases something small, all the bots come out to be professors.
Instead, when a thick developer releases something, nobody says shit, everybody says "wow you have a really long dick."

Am I perhaps the only strange one that this check does in InstanceBaseBattle.cpp in  ::CheckAdvancing? I ask for the meme

BOOL CInstanceBase::CheckAdvancing()
{
...

		//NOTE : Skil을 쓰더라도 Door Type과는 Collision체크 한다.
		if( bUsingSkill && !rkActorEach.IsDoor() )
			continue;

#ifdef FUNC_WALK_THROUGH_ENEMY // https://www.youtube.com/watch?v=h3uBr0CCm58&ab_channel=Hazard
		if (!IsAttacking() && rkActorEach.IsEnemy())
			continue;
#endif

Edited May 6, 2023 by Mitachi

[Papix 3801]

2 hours ago, crewfire1337 said:

Bros..... I had the same error, tried to fix it for 7 hours (that was 1 week ago) and yesterday I saw this topic...

that was my bugfix before, but all your bugfixes in that way dont work!

DO right click on a monster (select a monster ) but run with a mount to a another group, the bug is not gone.

sometimes at a mount the character moves little bit forward i think if you attack.

	if (m_pkHorse)
	{
		if(rVictim.IsEnemy() || rVictim.IsPoly())
		{
			return FALSE;
		}
		else if(isAttacking())
		{
			return TRUE;
		}
	}

 

And this fix: dont works too guys..

This is the hidden content, please

• Sign In
• or
• Sign Up

I use the function on my PvM server, I don't have any problems that were mentioned, it's up to whoever wants to use it if they need to adapt something in their server-files.

In server-files owsap works fine, if you use other files you will have to adapt the code if something does not work correctly.

[HFWhite 433]

On 5/6/2023 at 8:58 PM, crewfire1337 said:

Bros..... I had the same error, tried to fix it for 7 hours (that was 1 week ago) and yesterday I saw this topic...

that was my bugfix before, but all your bugfixes in that way dont work!

DO right click on a monster (select a monster ) but run with a mount to a another group, the bug is not gone.

sometimes at a mount the character moves little bit forward i think if you attack.

	if (m_pkHorse)
	{
		if(rVictim.IsEnemy() || rVictim.IsPoly())
		{
			return FALSE;
		}
		else if(isAttacking())
		{
			return TRUE;
		}
	}

 

And this fix: dont works too guys..

This is the hidden content, please

• Sign In
• or
• Sign Up

 

if (m_pkHorse)
    {
        if (rVictim.IsEnemy() || rVictim.IsPoly() || rVictim.GetActorType() == TYPE_NPC)
        {
            return FALSE;
        }
        else if (!IsMoving())
        {
            return TRUE;
        }
    }

[crewfire1337 28]

On 6/14/2023 at 5:32 AM, SCOOB said:

 

if (m_pkHorse)
    {
        if (rVictim.IsEnemy() || rVictim.IsPoly() || rVictim.GetActorType() == TYPE_NPC)
        {
            return FALSE;
        }
        else if (!IsMoving())
        {
            return TRUE;
        }
    }

Did you tried it ? Ill tried it already with IsMoving(), dont work too

[HFWhite 433]

On 6/15/2023 at 8:26 PM, crewfire1337 said:

Did you tried it ? Ill tried it already with IsMoving(), dont work too

for me it;s working. https://metin2.download/video/1uKwE6oE2nQpQ2F51Y57w61jEOV547Sx/.mp4

Edited June 16, 2023 by Metin2 Dev International
Core X - External 2 Internal