[C++] Remove collision from mobs

[Papix 832]

Hello community,

I needed to remove the collision from all the monsters and decided to share with you how to do it.

Anything included in mob_proto from vnum 101 to 99999 loses the collision.

Spoiler

 

The collision is removed, but when you are attacking it continues to exist.

Spoiler

 

Step by Step

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited March 18 by Papix

[speze012 930]

2 hours ago, Papix said:

Hello community,

I needed to remove the collision from all the monsters and decided to share with you how to do it.

Anything included in mob_proto from vnum 101 to 99999 loses the collision.

  Hide contents

 

The collision is removed, but when you are attacking it continues to exist.

  Reveal hidden contents

 

Step by Step

Hidden Content

• 
  
• #Binary
  @GameLib/ActorInstanceCollisionDetection.cpp
  
  After:

   

  BOOL CActorInstance::TestActorCollision(CActorInstance& rVictim)
  {
  	if (rVictim.IsDead())
  		return false;

  
  Add:

  #ifdef REMOVE_MOB_COLLISION
  	if (rVictim.GetRace() >= 101 && rVictim.GetRace() <= 99999 && !isAttacking())
  		return false;
  #endif

  
  @Locale_inc.h

  
  Add:

  #define REMOVE_MOB_COLLISION

   

 

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

[Papix 832]

1 hour ago, speze012 said:

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

The method I shared worked for me, I explained in the thread how the function works.

Instead of answering "WTF?" you could just say "this function is more efficient" and share your version.

I decided to share to help those who need it, I don't understand the point of that kind of comment.

Is it to try to come off as "superior"?

 

And if you want the function to work well, you must declare that 1 attack is not being made using !isAttacking()

Otherwise you will get something strange when choosing a target

Edited March 18 by Papix

[martysama0134 4744]

1 hour ago, speze012 said:

WTF Bro?

	if (rVictim.GetActorType() == TYPE_ENEMY || rVictim.GetActorType() == TYPE_NPC)
		return FALSE;

 

That check would remove IsAttacking, this is the correct one:

	if (rVictim.GetActorType() == TYPE_ENEMY && !isAttacking())
		return FALSE;

This check is only for mobs, so ignore npc/pet/door for now.

I haven't tested the code, so I have no idea if isAttacking would remain true for delayed attacks.

[Viello 10]

   

Client/Source/GameLib/ActorInstanceCollisionDetection.cpp

BOOL CActorInstance::TestActorCollision(CActorInstance & rVictim)

{

if(rVictim.IsEnemy() || rVictim.IsPoly() || rVictim.IsNPC())
        return FALSE;

I was using like that.

[WeedHex 590]

This crap because of the auto hunting?

[Mali 20526]

everyone shares a code , here is official reversed code for pets and shops:

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited March 18 by Mali

[Vaynz 763]

I don't know why all the fuss over some lines of code. Congratulations for post the ideea is very good, and to the others who came up with other ideas.
If someone needs it, I have it like that.

There is a new verison:

In BOOL CActorInstance::IgnoreCollisionNew(CActorInstance& rkTarget), you can and new conditions.

This is the hidden content, please

• Sign In
• or
• Sign Up

 or 

This is the hidden content, please

• Sign In
• or
• Sign Up

[Papix 832]

2 hours ago, WeedHex said:

This crap because of the auto hunting?

no, because !isAttacking()