fix Fix Damage Queue

[Helia01 2053]

Hey m2dev

You summon a lot of monsters, they attack your character and then you kill or purge monsters, but the damage still continues to be shown visually. Is this a familiar situation?

In addition, the damage is shown visually even after the death of the character... I love this game. 

 

I haven't seen a fix for this problem, let's try to fix this sh..

This is the hidden content, please

• Sign In
• or
• Sign Up

I'm not saying that this is an ideal solution. If you have any ideas, please write comments.


Best regards, Masha

Edited September 21, 2021 by Helia01
now the code is more secure.

[Helia01 2053]

i made small changes (now the removal of damage when your character died works correctly.)

[Cunoo 209]

Tested works fine! Thanks!

Here is better tutorial + small redesign code (TABs, space, only for eyes)

Serverside:

Spoiler

// game/src/packet.h -> search this:

typedef struct packet_damage_info
{
	BYTE	header;
	DWORD	dwVID;
	BYTE	flag;
	int		damage;
} TPacketGCDamageInfo;

// replace with this:

typedef struct packet_damage_info
{
	BYTE	header;
	DWORD	dwVictimVID;
	DWORD	dwAttackerVID;
	BYTE	flag;
	int		damage;
} TPacketGCDamageInfo;

// game/src/char_battle.cpp -> search this:

void CHARACTER::SendDamagePacket(LPCHARACTER pAttacker, int Damage, BYTE DamageFlag)
{
	if (IsPC() == true || (pAttacker->IsPC() == true && pAttacker->GetTarget() == this))
	{
		TPacketGCDamageInfo damageInfo;
		memset(&damageInfo, 0, sizeof(TPacketGCDamageInfo));

		damageInfo.header = HEADER_GC_DAMAGE_INFO;
		damageInfo.dwVID = (DWORD)GetVID();
		damageInfo.flag = DamageFlag;
		damageInfo.damage = Damage;

		if (GetDesc() != NULL)
		{
			GetDesc()->Packet(&damageInfo, sizeof(TPacketGCDamageInfo));
		}

		if (pAttacker->GetDesc() != NULL)
		{
			pAttacker->GetDesc()->Packet(&damageInfo, sizeof(TPacketGCDamageInfo));
		}
	}
}

// replace with this:

void CHARACTER::SendDamagePacket(LPCHARACTER pAttacker, int Damage, BYTE DamageFlag)
{
	if (IsPC() == true || (pAttacker->IsPC() == true && pAttacker->GetTarget() == this))
	{
		TPacketGCDamageInfo damageInfo;
		memset(&damageInfo, 0, sizeof(TPacketGCDamageInfo));

		damageInfo.header = HEADER_GC_DAMAGE_INFO;
		damageInfo.dwVictimVID = (DWORD)GetVID();
		damageInfo.dwAttackerVID = (DWORD)pAttacker->GetVID();
		damageInfo.flag = DamageFlag;
		damageInfo.damage = Damage;

		if (GetDesc() != NULL)
		{
			GetDesc()->Packet(&damageInfo, sizeof(TPacketGCDamageInfo));
		}

		if (pAttacker->GetDesc() != NULL)
		{
			pAttacker->GetDesc()->Packet(&damageInfo, sizeof(TPacketGCDamageInfo));
		}
	}
}

 

Clientside:

Spoiler

// UserInterface/Packet.h -> search this:

typedef struct packet_damage_info
{
	BYTE	header;
	DWORD	dwVID;
	BYTE	flag;
	int		damage;
} TPacketGCDamageInfo;

// replace with this:

typedef struct packet_damage_info
{
	BYTE	header;
	DWORD	dwVictimVID;
	DWORD	dwAttackerVID;
	BYTE	flag;
	int		damage;
} TPacketGCDamageInfo;

// UserInterface/InstanceBase.cpp -> search this:

ProcessDamage();

// add after this:

ProcessRemoveOldDamage();

// UserInterface/InstanceBase.h -> search this:

		struct SEffectDamage
		{
			DWORD	damage;
			BYTE	flag;
			BOOL	bSelf;
			BOOL	bTarget;
		};

		typedef std::list<SEffectDamage> CommandDamageQueue;
		CommandDamageQueue m_DamageQueue;

		void ProcessDamage();

	public:
		void AddDamageEffect(DWORD damage, BYTE flag, BOOL bSelf, BOOL bTarget);

// replace with this:

		struct SEffectDamage
		{
			DWORD	damage;
			BYTE	flag;
			BOOL	bSelf;
			BOOL	bTarget;
			DWORD	dwVictimVID;
			DWORD	dwAttackerVID;
		};

		typedef std::list<SEffectDamage> CommandDamageQueue;
		CommandDamageQueue m_DamageQueue;

		void ProcessDamage();
		void ProcessRemoveOldDamage();

	public:
		void AddDamageEffect(DWORD damage, BYTE flag, BOOL bSelf, BOOL bTarget, DWORD dwVictimVID, DWORD dwAttackerVID);


// UserInterface/InstanceBaseEffect.cpp -> add this to include:

#include "PythonPlayer.h" // this is default added so check it

#include "PythonApplication.h"
#include "PythonCharacterManager.h"

// UserInterface/InstanceBaseEffect.cpp -> search this:

void CInstanceBase::AddDamageEffect(DWORD damage, BYTE flag, BOOL bSelf, BOOL bTarget)
{
	if(CPythonSystem::Instance().IsShowDamage())
	{
		SEffectDamage sDamage;
		sDamage.bSelf = bSelf;
		sDamage.bTarget = bTarget;
		sDamage.damage = damage;
		sDamage.flag = flag;
		m_DamageQueue.push_back(sDamage);
	}
}

// replace with this:
void CInstanceBase::AddDamageEffect(DWORD damage, BYTE flag, BOOL bSelf, BOOL bTarget, DWORD dwVictimVID, DWORD dwAttackerVID)
{
	if (CPythonSystem::Instance().IsShowDamage() && !CPythonApplication::Instance().IsMinimizedWnd())
	{
		SEffectDamage sDamage;
		sDamage.bSelf = bSelf;
		sDamage.bTarget = bTarget;
		sDamage.damage = damage;
		sDamage.flag = flag;
		sDamage.dwVictimVID = dwVictimVID;
		sDamage.dwAttackerVID = dwAttackerVID;
		m_DamageQueue.push_back(sDamage);
	}
}

// UserInterface/InstanceBaseEffect.cpp -> search this:

void CInstanceBase::ProcessDamage()
{
	if(m_DamageQueue.empty())
		return;

	SEffectDamage sDamage = m_DamageQueue.front();

	m_DamageQueue.pop_front();

	DWORD damage = sDamage.damage;
	BYTE flag = sDamage.flag;
	BOOL bSelf = sDamage.bSelf;
	BOOL bTarget = sDamage.bTarget;

// replace with this:

void CInstanceBase::ProcessDamage()
{
	if(m_DamageQueue.empty())
		return;

	SEffectDamage sDamage = m_DamageQueue.front();

	m_DamageQueue.pop_front();

	DWORD damage = sDamage.damage;
	BYTE flag = sDamage.flag;
	BOOL bSelf = sDamage.bSelf;
	BOOL bTarget = sDamage.bTarget;
	DWORD dwVictimVID = sDamage.dwVictimVID;
	DWORD dwAttackerVID = sDamage.dwAttackerVID;

	CInstanceBase * pMainInstance = CPythonPlayer::Instance().NEW_GetMainActorPtr();

	if ((CPythonCharacterManager::instance().IsDeadVID(dwAttackerVID) || pMainInstance->IsDead()) && (flag != DAMAGE_POISON || flag != DAMAGE_BLEEDING || flag != DAMAGE_FIRE) && bSelf)
		return;

// UserInterface/InstanceBaseEffect.cpp -> search this function:

void CInstanceBase::ProcessDamage()

// add after this function this function:

void CInstanceBase::ProcessRemoveOldDamage()
{
	std::list<SEffectDamage>::iterator it;

	CInstanceBase * pMainInstance = CPythonPlayer::Instance().NEW_GetMainActorPtr();

	for (it = m_DamageQueue.begin(); it != m_DamageQueue.end(); ++it)
	{
		if ((CPythonCharacterManager::instance().IsDeadVID(it->dwAttackerVID) || pMainInstance->IsDead()) && (it->flag != DAMAGE_POISON || it->flag != DAMAGE_BLEEDING || it->flag != DAMAGE_FIRE) && it->bSelf)
		{
			m_DamageQueue.erase(it);
		}
	}
}

// UserInterface/PythonNetworkStreamPhaseGame.cpp -> search this:

bool CPythonNetworkStream::RecvDamageInfoPacket()
{
	TPacketGCDamageInfo DamageInfoPacket;

	if (!Recv(sizeof(TPacketGCDamageInfo), &DamageInfoPacket))
	{
		Tracen("Recv Target Packet Error");
		return false;
	}
	
	CInstanceBase * pInstTarget = CPythonCharacterManager::Instance().GetInstancePtr(DamageInfoPacket.dwVID);

	bool bSelf = (pInstTarget == CPythonCharacterManager::Instance().GetMainInstancePtr());
	bool bTarget = (pInstTarget == m_pInstTarget);

	if (pInstTarget)
	{
		if(DamageInfoPacket.damage >= 0)
			pInstTarget->AddDamageEffect(DamageInfoPacket.damage,DamageInfoPacket.flag,bSelf,bTarget);
		else
			TraceError("Damage is equal or below 0.");
	}

	return true;
}

// replace with this:

bool CPythonNetworkStream::RecvDamageInfoPacket()
{
	TPacketGCDamageInfo DamageInfoPacket;

	if (!Recv(sizeof(TPacketGCDamageInfo), &DamageInfoPacket))
	{
		Tracen("Recv Target Packet Error");
		return false;
	}

	CInstanceBase * pInstTarget = CPythonCharacterManager::Instance().GetInstancePtr(DamageInfoPacket.dwVictimVID);

	bool bSelf = (pInstTarget == CPythonCharacterManager::Instance().GetMainInstancePtr());
	bool bTarget = (pInstTarget == m_pInstTarget);

	if (pInstTarget)
	{
		if(DamageInfoPacket.damage >= 0)
			pInstTarget->AddDamageEffect(DamageInfoPacket.damage, DamageInfoPacket.flag, bSelf, bTarget, DamageInfoPacket.dwVictimVID, DamageInfoPacket.dwAttackerVID);
		else
			TraceError("Damage is equal or below 0.");
	}

	return true;
}

// UserInterface/PythonApplication.cpp -> search this function:

bool CPythonApplication::Process()

// add after this function this function:

bool CPythonApplication::IsMinimizedWnd()
{
	return m_isMinimizedWnd;
}

// UserInterface/PythonApplication.h -> search this:

bool Process()

// add after this:

bool IsMinimizedWnd();

Edit: btw. one little think.. Check your client source for DAMAGE_FIRE + DAMAGE_BLEEDING flag.. You must change your code if you dont have it..

Edited September 20, 2021 by VegaS™
added spoiler

[martysama0134 6944]

On 9/18/2021 at 2:23 AM, Helia01 said:

I'm not saying that this is an ideal solution. If you have any ideas, please write comments.

If m_DamageQueue' size() is bigger than 20 elements, you can just pop() the old one. Just 2 lines of code required.

I suggest you to change its type from std::list to std::queue.

[Tatsumaru 5022]

The delay still occurs, but is clearly shorter.

Could someone explain in more detail what to do in Martysam's solution?

[Shahin 214]

On 9/19/2021 at 7:34 PM, martysama0134 said:

If m_DamageQueue' size() is bigger than 20 elements, you can just pop() the old one. Just 2 lines of code required.

I suggest you to change its type from std::list to std::queue.

Can you help us out with this one @ martysama0134?

[VegaS™ 9935]

On 9/21/2021 at 1:58 AM, Tatsumaru said:

Could someone explain in more detail what to do in Martysam's solution?

On 9/21/2021 at 2:07 AM, Shahin said:

Can you help us out with this one @ martysama0134?

 

Quote

If m_DamageQueue' size() is bigger than 20 elements, you can just pop() the old one.

I suggest you to change its type from std::list to std::queue.

Based on what martysama said in his reply, these are the changes you've to do:

InstanceBase.h

// Search for:
typedef std::list<SEffectDamage> CommandDamageQueue;
// Replace with:
typedef std::queue<SEffectDamage> CommandDamageQueue;

InstanceBaseEffect.cpp

This is the hidden content, please

• Sign In
• or
• Sign Up

Exclamation: I'm not responsible for this solution.

Edited September 30, 2021 by VegaS™

[Helia01 2053]

23 hours ago, Tatsumaru said:

The delay still occurs, but is clearly shorter.

Could someone explain in more detail what to do in Martysam's solution?

 

//open char_battle.cpp
//In function void CHARACTER::Dead(LPCHARACTER pkKiller, bool bImmediateDead) search this:
if (IsRevive() == false && HasReviverInParty() == true)
{
  m_pkDeadEvent = event_create(dead_event, pEventInfo, bImmediateDead ? 1 : PASSES_PER_SEC(3));
}
else
{
  m_pkDeadEvent = event_create(dead_event, pEventInfo, bImmediateDead ? 1 : PASSES_PER_SEC(10));
}

// replace with this:
m_pkDeadEvent = event_create(dead_event, pEventInfo, bImmediateDead ? 1 : PASSES_PER_SEC(1));

And compare the result again.

You can rewrite this part of the code as you want. I showed a quick and stupid example. However, this will fix your situation.

 

I rewrote some of the code, now the code is more secure.

// UserInterface/InstanceBaseEffect.cpp
//Old version
void CInstanceBase::ProcessRemoveOldDamage()
{
	CInstanceBase * pMainInstance = CPythonPlayer::Instance().NEW_GetMainActorPtr();
	std::list<SEffectDamage>::iterator it;
	for (it = m_DamageQueue.begin(); it != m_DamageQueue.end(); ++it)
	{
		if ((CPythonCharacterManager::instance().IsDeadVID(it->dwAttackerVID) || pMainInstance->IsDead()) && (it->flag != DAMAGE_POISON || it->flag != DAMAGE_BLEEDING || it->flag != DAMAGE_FIRE) && it->bSelf)
		{
			m_DamageQueue.erase(it);
		}
	}

}


//New version
void CInstanceBase::ProcessRemoveOldDamage()
{
	if (m_DamageQueue.empty())
		return;

	m_DamageQueue.remove_if([](CInstanceBase::SEffectDamage sed){ return ((CPythonCharacterManager::instance().IsDeadVID(sed.dwAttackerVID) || CPythonPlayer::Instance().NEW_GetMainActorPtr()->IsDead()) && (sed.flag != DAMAGE_POISON || sed.flag != DAMAGE_BLEEDING || sed.flag != DAMAGE_FIRE) && sed.bSelf); });
}

 

//In function void CInstanceBase::ProcessDamage() remove this
	CInstanceBase * pMainInstance = CPythonPlayer::Instance().NEW_GetMainActorPtr();
	DWORD dwVictimVID = sDamage.dwVictimVID;
	DWORD dwAttackerVID = sDamage.dwAttackerVID;

	if ((CPythonCharacterManager::instance().IsDeadVID(dwAttackerVID) || pMainInstance->IsDead()) && (flag != DAMAGE_POISON || flag != DAMAGE_BLEEDING || flag != DAMAGE_FIRE) && bSelf)
		return;

The tutorial has already been updated.

Edited September 21, 2021 by Helia01

[Zylon 29]

On 9/19/2021 at 4:04 PM, Cunoo said:

Edit: btw. one little think.. Check your client source for DAMAGE_FIRE + DAMAGE_BLEEDING flag.. You must change your code if you dont have it..

How is the change, can u explain?

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[Distraught 5688]

What if you just handle all the damage effects in the queue in every update so that they won't stack up?

[Helia01 2053]

On 10/19/2021 at 5:42 AM, Zylon said:

How is the change, can u explain?

m_DamageQueue.remove_if([](CInstanceBase::SEffectDamage sed){ return ((CPythonCharacterManager::instance().IsDeadVID(sed.dwAttackerVID) || CPythonPlayer::Instance().NEW_GetMainActorPtr()->IsDead()) && (sed.flag != DAMAGE_POISON) && sed.bSelf); });

 

On 10/19/2021 at 11:57 AM, Distraught said:

What if you just handle all the damage effects in the queue in every update so that they won't stack up?

it's a good idea.
It would be nice if you showed examples of how you would fix this problem. Perhaps your method will really be much better. A comparison is needed.

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[Distraught 5688]

Make ProcessDamage return with a boolean value. Return false if the damage queue is empty and return true at other returns and at the end of the function.

This is the hidden content, please

• Sign In
• or
• Sign Up

And in CInstanceBase::Update put ProcessDamage in a loop like this.

This is the hidden content, please

• Sign In
• or
• Sign Up

[Helia01 2053]

Recently I realized that my decision is bad because when you kill the enemy, the damage is lost. For example, if you hit the enemy at 21.234, then after the enemy's death you will see 2,234. In short, the numbers disappear and this is bad. I advise everyone to use the implementation of the fix from @ Distraught