official Official appSetCameraMaxDistance [REVERSED]

[Mali 39635]

This is the hidden content, please

• Sign In
• or
• Sign Up

 

From: 22.5.7.0

 

It includes a modification that changes the custom distance based on the map names.

 

This is the hidden content, please

• Sign In
• or
• Sign Up

Edited January 10, 2023 by Mali

[WeedHex 626]

I did it by myself time ago because so ugly in thight places the long zoom, stonks. Thanks for posting! 

[martysama0134 6962]

#define ENABLE_CAMERA_ZOOM_OPTIMIZE
#ifdef ENABLE_CAMERA_ZOOM_OPTIMIZE
#include <unordered_map>
#endif

PyObject* appSetCameraMaxDistance(PyObject* poSelf, PyObject* poArgs)
{
	float fMax{};
	if (!PyTuple_GetFloat(poArgs, 0, &fMax))
		return Py_BuildException();

#ifdef ENABLE_CAMERA_ZOOM_OPTIMIZE
	static const std::unordered_map<std::string, float> mapCameraZoom = {
		{"metin2_map_n_flame_dragon", 6000.0f},
		{"metin2_12zi_stage", 5000.0f},
		{"metin2_map_defensewave", 5000.0f},
		{"metin2_map_miniboss_01", 5000.0f},
		{"metin2_map_miniboss_02", 5000.0f},
		{"metin2_map_mists_of_island", 5000.0f},
	};
	const std::string c_rstrMapFileName = CPythonBackground::Instance().GetWarpMapName();
	const auto it = mapCameraZoom.find(c_rstrMapFileName);
	if (it != mapCameraZoom.end())
		fMax = it->second;
#endif

	CCamera::SetCameraMaxDistance(fMax);
	return Py_BuildNone();
}

I slightly refactored it. Now it's O(1).

Edited December 17, 2022 by martysama0134

[ReFresh 2263]

You can get this error: 'c_rstrMapFileName': redefinition; multiple initialization'

Just remove const std::string c_rstrMapFileName = CPythonBackground::Instance().GetWarpMapName(); in @ martysama0134 code it's defined twice.

This is the hidden content, please

• Sign In
• or
• Sign Up

[martysama0134 6962]

6 minutes ago, ReFresh said:

'c_rstrMapFileName': redefinition

Fixed.

[Mali 39635]

Let's increase the number of comments

Edited March 12, 2023 by Mali

[Deso 702]

 Here is my slightly refactored version.. 

 

#include <unordered_map>

// Add a list of maps and their corresponding max distance values to a map.
// This allows us to look up the max distance value for a given map more efficiently than using a series of if statements.
std::unordered_map<std::string, float> mapMaxDistances = {
    {"metin2_map_n_flame_dragon", 6000.0f},
    {"metin2_12zi_stage", 5000.0f},
    {"metin2_map_defensewave", 5000.0f},
    {"metin2_map_miniboss_01", 5000.0f},
    {"metin2_map_miniboss_02", 5000.0f},
    {"metin2_map_mists_of_island", 5000.0f}
};

PyObject* appSetCameraMaxDistance(PyObject* poSelf, PyObject* poArgs)
{
    float fMax;
    if (!PyTuple_GetFloat(poArgs, 0, &fMax))
        return Py_BuildException();

    const std::string c_rstrMapFileName = CPythonBackground::Instance().GetWarpMapName();

    // Look up the max distance value for the current map in the mapMaxDistances map.
    // If the map is not found in the map, the max distance value will be the default value of 0.0f.
    fMax = mapMaxDistances[c_rstrMapFileName];

    CCamera::SetCameraMaxDistance(fMax);
    return Py_BuildNone();
}

 

[PACI 911]

13 minutes ago, Deso said:

 Here is my slightly refactored version.. 

 

#include <unordered_map>

// Add a list of maps and their corresponding max distance values to a map.
// This allows us to look up the max distance value for a given map more efficiently than using a series of if statements.
std::unordered_map<std::string, float> mapMaxDistances = {
    {"metin2_map_n_flame_dragon", 6000.0f},
    {"metin2_12zi_stage", 5000.0f},
    {"metin2_map_defensewave", 5000.0f},
    {"metin2_map_miniboss_01", 5000.0f},
    {"metin2_map_miniboss_02", 5000.0f},
    {"metin2_map_mists_of_island", 5000.0f}
};

PyObject* appSetCameraMaxDistance(PyObject* poSelf, PyObject* poArgs)
{
    float fMax;
    if (!PyTuple_GetFloat(poArgs, 0, &fMax))
        return Py_BuildException();

    const std::string c_rstrMapFileName = CPythonBackground::Instance().GetWarpMapName();

    // Look up the max distance value for the current map in the mapMaxDistances map.
    // If the map is not found in the map, the max distance value will be the default value of 0.0f.
    fMax = mapMaxDistances[c_rstrMapFileName];

    CCamera::SetCameraMaxDistance(fMax);
    return Py_BuildNone();
}

 

Absolutely nonsense.
What's the point of passing fMax to define the camera max distance if it's replaced by 0?

[martysama0134 6962]

15 minutes ago, Deso said:

fMax = mapMaxDistances[c_rstrMapFileName];

If the key is missing, it will create a new entry inside the unordered_map. Any m2 map not in table will have a max distance of 0.f. 

Edited December 19, 2022 by martysama0134

[Amun 1819]

Spoiler

  

10 minutes ago, Deso said:

 Here is my slightly refactored version.. 

 

#include <unordered_map>

// Add a list of maps and their corresponding max distance values to a map.
// This allows us to look up the max distance value for a given map more efficiently than using a series of if statements.
std::unordered_map<std::string, float> mapMaxDistances = {
    {"metin2_map_n_flame_dragon", 6000.0f},
    {"metin2_12zi_stage", 5000.0f},
    {"metin2_map_defensewave", 5000.0f},
    {"metin2_map_miniboss_01", 5000.0f},
    {"metin2_map_miniboss_02", 5000.0f},
    {"metin2_map_mists_of_island", 5000.0f}
};

PyObject* appSetCameraMaxDistance(PyObject* poSelf, PyObject* poArgs)
{
    float fMax;
    if (!PyTuple_GetFloat(poArgs, 0, &fMax))
        return Py_BuildException();

    const std::string c_rstrMapFileName = CPythonBackground::Instance().GetWarpMapName();

    // Look up the max distance value for the current map in the mapMaxDistances map.
    // If the map is not found in the map, the max distance value will be the default value of 0.0f.
    fMax = mapMaxDistances[c_rstrMapFileName];

    CCamera::SetCameraMaxDistance(fMax);
    return Py_BuildNone();
}

 

 

The fuck did you refactor?

 

Thanks, Mali!

[Deso 702]

Well it was a joke, i made use of a artificial intelligence. Dont take everything so serious. 

[WeedHex 626]

1 minute ago, Deso said:

Well it was a joke, i made use of a artificial intelligence. Dont take everything so serious. 

You know how used to say for the math...