[C++]Shop price same in all Kingdoms

[Lycawn 1274]

With this change you can have same price in every kingdom 

 

At shop.cpp 

search for if (bOtherEmpire)

			pack2.items[i].price = item.price * 3;

change it to : 

			pack2.items[i].price = item.price

search 
if (it->second) // if other empire, price is triple
    dwPrice *= 3;

Change 

if (it->second) // if other empire, price is triple
    dwPrice *= 1;

 

Edited November 16, 2023 by Lycawn
Fixed

[Gurgarath 3693]

Hello, thank you for your release but it is not a good or complete solution. Let me explain:

• It is better to not do "price * 1" as "price * 1" is simply equal to "price".

  • pack2.items[i].price = item.price;

• In that case, both cases of the if are equal, you can then simply remove the following check and replace it with the code above.

  • if (bOtherEmpire)
        pack2.items[i].price = item.price * 3;
    else
        pack2.items[i].price = item.price;

• Also, in shop.cpp you must remove the following piece of code for the change to be complete:

  • if (it->second) // if other empire, price is triple
        dwPrice *= 3;
    

 

[Lycawn 1274]

3 minutes ago, Gurgarath said:

Hello, thank you for your release but it is not a good or complete solution. Let me explain:

• It is better to not do "price * 1" as "price * 1" is simply equal to "price".

  • pack2.items[i].price = item.price;

• In that case, both cases of the if are equal, you can then simply remove the following check and replace it with the code above.

  • if (bOtherEmpire)
        pack2.items[i].price = item.price * 3;
    else
        pack2.items[i].price = item.price;

• Also, in shop.cpp you must remove the following piece of code for the change to be complete:

  • if (it->second) // if other empire, price is triple
        dwPrice *= 3;
    

 

Thank you!  in my case there is not  dwPrice  already!

Edited November 15, 2023 by Lycawn

[Thorek 374]

We have the answer to the question of why 90% of Metin2 „developers” won't ever do anything useful, sadge

Edited November 15, 2023 by Thorek

[Vegaz 4]

@Thorek

Take Polak, you ridicule everyone and on your "forum" people laugh at you because you can't write in python. The boy may be starting his adventure with coding from the simplest things and you have the nerve to criticize him instead of congratulating or in some way still directing him?
I feel bad having anything to do with Poland because of people like you.

Edited November 21, 2023 by Vegaz

[Thorek 374]

4 hours ago, Vegaz said:

@Thorek

Take Polak, you ridicule everyone and on your "forum" people laugh at you because you can't write in python. The boy may be starting his adventure with coding from the simplest things and you have the nerve to criticize him instead of congratulating or in some way still directing him?
I feel bad having anything to do with Poland because of people like you.

Take Niemiec, which forum is mine? Yes, I can't write in Python because Python is crap, and I don't like this language. Even if he started his adventure, he could have looked for this addition before he published it.

I appreciate every work, but honestly - why would we need topics like this when we have tons of them? But yes - my first comment may be a little toxic, and I want to apologize for this.

Edited November 21, 2023 by Thorek