fix Fix: Sura weapon and Shaman

[Draveniou1 697]

Hello,

In this I fixed several problems

Now with the new method the problems have all been solved

[Please it has been tested before publishing]

1) OPEN char_affect.cpp
search:
void CHARACTER::RemoveBadAffect()
{
  ..........
}

Change with:

void CHARACTER::RemoveBadAffect()
{
	for (auto it = 0; it < SKILL_MAX_NUM; it++)
	{
		const CAffect * pkAff = FindAffect(it);
		if (pkAff)
		{
			switch (it)
			{
				case AFFECT_FIRE:
				{
					RemoveAffect (AFFECT_FIRE);
					event_cancel(&m_pkFireEvent);
					break;
				}
				case AFFECT_POISON:
				{
					RemoveAffect (AFFECT_POISON);
					event_cancel(&m_pkPoisonEvent);
					break;
				}
				case AFFECT_STUN:
				case AFFECT_SLOW:
				case SKILL_TUSOK:
				{
					RemoveAffect (it);
					break;
				}
			}
		}
	}

	ComputePoints();
	UpdatePacket();
}

--------------------
  ----------

2. search:
void CHARACTER::RemoveGoodAffect()
{
  ..........
}

change with:

void CHARACTER::RemoveGoodAffect()
{
	for (auto it = 0; it < SKILL_MAX_NUM; it++)
	{
		const CAffect * pkAff = FindAffect(it);
		if (pkAff)
		{
			switch (it)
			{
				case AFFECT_MOV_SPEED:
				case AFFECT_ATT_SPEED:
				case AFFECT_STR:
				case AFFECT_DEX:
				case AFFECT_INT:
				case AFFECT_CON:
				case AFFECT_CHINA_FIREWORK:
				case SKILL_JEONGWI:
				case SKILL_GEOMKYUNG:
				case SKILL_CHUNKEON:
				case SKILL_EUNHYUNG:
				case SKILL_GYEONGGONG:
				case SKILL_GWIGEOM:
				case SKILL_TERROR:
				case SKILL_JUMAGAP:
				case SKILL_MANASHILED:
				case SKILL_HOSIN:
				case SKILL_REFLECT:
				case SKILL_GICHEON:
				case SKILL_KWAESOK:
				case SKILL_JEUNGRYEOK:
				{
					RemoveAffect (it);
					break;
				}
			}
		}
	}

	ComputePoints();
	UpdatePacket();
}

 

 

 

(If you haven't solved the UpdatePacket and ComputePoints issues please don't use this method)

(90% people have martysama and owsap serverfiles there is no problem)

 

I worked many hours to fix all the problems from the fix @ Syreldar

it has been tested before I publish it  (I Have test and in martysama serverfiles and in Owsap to be sure it will work properly)

 

thanks you.

 

Edited May 20, 2023 by Draveniou1

[Gurgarath 2427]

Hello,

Why would you do this? It is a less performant version of what Syreldar already shared.

Thank you for your release however

[Draveniou1 697]

4 minutes ago, Gurgarath said:

Hello,

Why would you do this? It is a less performant version of what Syreldar already shared.

Thank you for your release however

@ Syreldar  good fix  only have 2-5 problem's  with removed affect and stackable bonus i find full bug 

I have configured his fix and it has been tested on quite a few people before it is published 

 

 

[Draveniou1 697]

const std::vector<WORD> BadAffects =
{
	AFFECT_FIRE,
	AFFECT_POISON,
	AFFECT_STUN,
	AFFECT_SLOW,
	SKILL_TUSOK
};

void CHARACTER::RemoveBadAffect()
{
	for (auto it : BadAffects)
	{
		auto pkAff = FindAffect(it);
		auto pkAffoff = RemoveAffect(it);
		if (pkAff)
		{
			switch (it)
			{
				case AFFECT_FIRE:
				{
					event_cancel(&m_pkFireEvent);
					break;
				}
				case AFFECT_POISON:
				{
					event_cancel(&m_pkPoisonEvent);
					break;
				}
				pkAffoff;
				break;
			}
		}
	}

	ComputePoints();
	UpdatePacket();
}



---------------------------------------
  ---------------------------------
  ---------------------------------
  const std::vector<WORD> GoodAffects =
{
	AFFECT_MOV_SPEED,
	AFFECT_ATT_SPEED,
	AFFECT_STR,
	AFFECT_DEX,
	AFFECT_INT,
	AFFECT_CON,
	AFFECT_CHINA_FIREWORK,
	SKILL_JEONGWI,
	SKILL_GEOMKYUNG,
	SKILL_CHUNKEON,
	SKILL_EUNHYUNG,
	SKILL_GYEONGGONG,
	SKILL_GWIGEOM,
	SKILL_TERROR,
	SKILL_JUMAGAP,
	SKILL_MANASHILED,
	SKILL_HOSIN,
	SKILL_REFLECT,
	SKILL_GICHEON,
	SKILL_KWAESOK,
	SKILL_JEUNGRYEOK
};

void CHARACTER::RemoveGoodAffect()
{
	for (auto it : GoodAffects)
	{
		auto pkAff = FindAffect(it);
		auto pkAffofef = RemoveAffect(it);
		if (pkAff)
		{
			pkAffofef;
		}
	}

	ComputePoints();
	UpdatePacket();
}

@ Gurgarath It can also be done like this

It has not been tested, maybe I will test it soon

I like it that way

 

[Syreldar 1808]

The fix I posted 5 years ago has been thoroughly tested by many users, myself included.

There's no problem whatsoever, but feel free to use whatever suits you best.

Edited May 20, 2023 by Syreldar

[Draveniou1 697]

Just now, Syreldar said:

The fix i posted has been thoroughly tested by many users, myself included.

There's no problem whatsoever, but feel free to use whatever suits you best.

i have your fix  i have  problem's

1o problem = warrior skill not clear  why?

2o problem = if have pottion stackable why ?

 

i don't know and in another serverfiles have game.core 

i have remade your fix and it works on all server files without problems this

[Syreldar 1808]

1 minute ago, Draveniou1 said:

i have your fix  i have  problem's

1o problem = warrior skill not clear  why?

I made 2 .gifs after coding the fix, you can find them in the topic.

It shows that warrior skills clear just fine.

[Draveniou1 697]

4 minutes ago, Syreldar said:

I made 2 .gifs after coding the fix, you can find them in the topic.

It shows that warrior skills clear just fine.

You didn't understand, for example some serverfiles don't accept your fix 

I have added your fix to some server files and there are problems 

check video for you see problem 

 

this problem exists in many servers 

but your solution is still the best as long as you find the serverfiles to match it

@ SyreldarFor example  download fliege serverfiles or another serverfiles and check your fix with your method and the my method and you see

[Syreldar 1808]

13 minutes ago, Draveniou1 said:

You didn't understand, for example some serverfiles don't accept your fix 

I have added your fix to some server files and there are problems 

check video for you see problem 

 

this problem exists in many servers 

but your solution is still the best as long as you find the serverfiles to match it

The change I posted has been tested on default mainlines, like all the releases I made.

Also, I believe the code I changed is the same on every rev that has been leaked 9 years ago.

In short, there's nothing wrong with my release.

 

By the gif you just sent I believe the updatepacket is failing.

Try to redo my changes except inside the RemoveAffect function use this code instead of the one you find in the release.
 

    if (single)
        if (AFFECT_REVIVE_INVISIBLE != pkAff->dwType)
            ComputePoints();
        else
            UpdatePacket();
    else
        UpdatePacket();

 

Edited May 20, 2023 by Syreldar

[Draveniou1 697]

1 minute ago, Syreldar said:

The change I posted has been tested on default mainlines, like all the releases I made.

Also, I believe the code I changed is the same on every rev that has been leaked 9 years ago.

In short, there's nothing wrong with my release.

i know your fix is ok as we give a chance to add people who have had such problems to their files 

some don't want mainline or main sources

I never said that your solution is not good I have seen these errors on 20 small servers Also the solution I suggested has already helped some people

[Syreldar 1808]

1 minute ago, Draveniou1 said:

i know your fix is ok as we give a chance to add people who have had such problems to their files 

some don't want mainline or main sources

I never said that your solution is not good I have seen these errors on 20 small servers Also the solution I suggested has already helped some people

Read my message again, if possible.

[Draveniou1 697]

3 minutes ago, Syreldar said:

Read my message again, if possible.

    if (single)
        if (AFFECT_REVIVE_INVISIBLE != pkAff->dwType)
            ComputePoints();
        else
            UpdatePacket();
    else
        UpdatePacket();

 

Why are there 2 NULL? if it is suddenly activated to true what will happen?

[Syreldar 1808]

5 minutes ago, Draveniou1 said:

    if (single)
        if (AFFECT_REVIVE_INVISIBLE != pkAff->dwType)
            ComputePoints();
        else
            UpdatePacket();
    else
        UpdatePacket();

 

Why are there 2 NULL? if it is suddenly activated to true what will happen?

wdym?

As you can read, the change I made adds an arg to the RemoveAffect function.

The purpose of this arg is to make the func call behave differently based on an arbitrary condition, in this case we need it to not execute the ComputePoints() call inside the function, cause we need to only call it once AFTER all the good/bad affects have been cleared, so we do that at the end of their respecting funcs.

I have already stated why we need to do that in the topic, it's cause ComputePoints() is a "heavy" function, and it will lag a bit by itself already, so calling it once per affect to clear is not only useless but is also what causes the lag we're talking about.

Edited May 20, 2023 by Syreldar

[Draveniou1 697]

2 minutes ago, Syreldar said:

wdym?

As you can read, the change I made adds an arg to the RemoveAffect function.

The purpose of this arg is to make the func call behave differently based on an arbitrary condition, in this case we need to not execute the ComputePoints() call inside the function cause we need to only make it once, after all the good/bad affects have been cleared.

I have already wrote why we need to do that in the topic, because ComputePoints() is a "heavy" function, and it will lag a big by itself, so calling it once per affect to clear is not only useless but is also what causes the lag we're talking about.

I will test on these now and come back with newer ones

[Syreldar 1808]

Just now, Draveniou1 said:

I will test on these now and come back with newer ones

If you have issues, contact me on discord instead of writing here. It's simpler.

[Syreldar 1808]

I solved the issue he had and updated my topic to match the change.

[Draveniou1 697]

24 minutes ago, Syreldar said:

I solved the issue he had and updated my topic to match the change.

  is the best thanks you for all for understants