fix Fix - Effect rendering bug on models with opacity when the effect is inside the model

[Distraught 9985]

There's a bug in the game if you have like an NPC and you set its opacity to less then 1.0 and attach effects to it and the effects are inside the model. The effect will not be rendered because the effect rendering is after character rendering so when it's stenciling it, it won't know what should be seen behind the model.

 

To fix this we just have to pre-render the effects in this case.

To achieve this add this code to the beginning of CActorInstance::OnRender

if (GetAlphaValue() < 1.0f)
{
	for (auto it = m_AttachingEffectList.begin(); it != m_AttachingEffectList.end(); ++it)
	{
		CEffectManager::Instance().SelectEffectInstance(it->dwEffectIndex);
		CEffectManager::Instance().RenderEffect();
	}
}

 

and add a new method to CEffectManager in EffectLib/EffectManager.h:

void RenderEffect();

and for sure define it in EffectManager.cpp

void CEffectManager::RenderEffect()
{
	if (!m_pSelectedEffectInstance)
		return;

	m_pSelectedEffectInstance->Render();
}

 

Now you can create eg. mounts with effects like this:

 

Hope you like it and will be useful!

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[MrQuin 8155]

#Distraught_Dev_Tag

[Geoffrey 9330]

9 hours ago, MrQuin said:

#Distraught_Dev_Tag

 

It's done.

[Distraught 9985]

1 hour ago, ASIKOO said:

 

It's done.

Oh, thank you

[ReFresh 3151]

@ Distraught Thanks for the release, but it will make a visual bug in character select. You can see the select target on characters.

Edited December 27, 2023 by ReFresh
Core X - External 2 Internal