fix Fix Guilding Building Yang Bug

[Sherer 614]

Hello,
I don't really know if someone else pointed it out but (if not) there you go.
There is really ugly yang-bug in guild building code.
Open cmd_gm.cpp, go to the do_build function and navigate this kind of code:
 

				if (test_server || GMLevel == GM_PLAYER)
					// °ÇĽł Ŕç·á ĽŇ¸đÇϱâ (Ĺ׼·żˇĽ­´Â GMµµ ĽŇ¸đ)
				{
					// °ÇĽł şńżë ĽŇ¸đ
					ch->PointChange(POINT_GOLD, -t->dwPrice);

Looks ok, right? Not really. dwPrice is typed as DWORD. It's never a good idea to subtract unsigned value.
That will not cause any damage if your PointChange function takes int as an argument but once you decide to change it to f.e long long, there you have live example:
https://onlinegdb.com/HJF-CWsCE
Mitigation:

Just cast the value to int/long long:

				if (test_server || GMLevel == GM_PLAYER)
					// °ÇĽł Ŕç·á ĽŇ¸đÇϱâ (Ĺ׼·żˇĽ­´Â GMµµ ĽŇ¸đ)
				{
					// °ÇĽł şńżë ĽŇ¸đ
					int iPrice = static_cast<int>(t->dwPrice);
					ch->PointChange(POINT_GOLD, -iPrice);

Regards

[ElRenardo 26]

Hi, the same problem can be found in the cube_proto.

ch->PointChange(POINT_GOLD, -(cube_proto->gold), false);

cube_proto->gold is unsigned by default.

[Dalí 313]

For cube.cpp

ch->PointChange(POINT_GOLD, -static_cast<int>(cube_proto->gold), false);

[Flourine 136]

Dnia 10.06.2019 o 10:32, xGenessis napisał:

For cube.cpp

ch->PointChange(POINT_GOLD, -static_cast<int>(cube_proto->gold), false);

or just in cube.h

struct CUBE_DATA
use 

long long gold; 

instead of unsigned lol.

 

Same with buildings

in common/building.h

dwPrice into long long.

[ReFresh 3151]

@Sherer More simple thing is like @Flourine did. 

And for long long you can use this: 

ch->PointChange(POINT_GOLD, -static_cast<long long>(t->dwPrice));