pc.in_dungeon function for quest

[Exygo 1045]

Description:

Quote

Get rid of any other functions and put it directly in the source

if you want to don't use anymore this nasty piece of code :

if pc.get_map_index() >= (206 * 10000) and pc.get_map_index() < ((206 + 1) * 10000) then

 

Usage:

Quote

when 2493.kill with pc.in_dungeon(208) begin
when kill with pc.in_dungeon() begin -- any dungeon

 

Function:

Quote

// dungeon.h

// Find
	long	GetMapIndex() { return m_lMapIndex; }

// Add after
	int		GetOriginalMapIndex() { return m_lOrigMapIndex; }

// questlua_pc.cpp
// Find & replace the whole function
	int pc_in_dungeon(lua_State * L)
	{
		LPCHARACTER ch = CQuestManager::instance().GetCurrentCharacterPtr();
		if (!ch)
		{
			lua_pushboolean(L, false);
			return 1;
		}

		LPDUNGEON dungeon = ch->GetDungeon();
		bool ret = (dungeon != NULL);

		if (ret && lua_gettop(L) >= 1 && lua_isnumber(L, 1))
		{
			int mapIndex = (int)lua_tonumber(L, 1);
			if (mapIndex > 0)
				ret = (mapIndex == dungeon->GetOriginalMapIndex());
		}

		lua_pushboolean(L, ret);
		return 1;
	}

 

 

[Syreldar 1808]

Why would you add a new source function for such a thing?

 

[shenhui1986 10]

questlua_pc.cpp: In function 'int quest::pc_in_dungeon(lua_State*)':
questlua_pc.cpp:277:31: error: invalid use of incomplete type 'class CDungeon'
  277 |     ret = (mapIndex == dungeon->GetOriginalMapIndex());
      |                               ^~
In file included from stdafx.h:57,
                 from questlua_pc.cpp:1:
typedef.h:78:7: note: forward declaration of 'class CDungeon'
   78 | class CDungeon;
      |       ^~~~~~~~
gmake: *** [Makefile:171: .obj/questlua_pc.o] Error 1

 

 

 

This is the solution

#include "dungeon.h" 

 

in questlua_pc.cpp

Edited January 7 by shenhui1986

[Syreldar 1808]

 

13 hours ago, shenhui1986 said:

questlua_pc.cpp: In function 'int quest::pc_in_dungeon(lua_State*)':
questlua_pc.cpp:277:31: error: invalid use of incomplete type 'class CDungeon'
  277 |     ret = (mapIndex == dungeon->GetOriginalMapIndex());
      |                               ^~
In file included from stdafx.h:57,
                 from questlua_pc.cpp:1:
typedef.h:78:7: note: forward declaration of 'class CDungeon'
   78 | class CDungeon;
      |       ^~~~~~~~
gmake: *** [Makefile:171: .obj/questlua_pc.o] Error 1

 

 

 

This is the solution

#include "dungeon.h" 

 

in questlua_pc.cpp

Bro.

You don't need a C++ function for such a thing.

InDungeon = function(map_index)
    local pc_index = pc.get_map_index();
    return
        pc.in_dungeon() and
        pc_index >= ToDungeonIndex(map_index) and
        pc_index < ToDungeonIndex(map_index+1);
end -- function

when MOB_VNUM.kill with InDungeon(DUNGEON_MAP_INDEX) begin

 

[shenhui1986 10]

ok  thank you