fix Fix for the Refresh of the Skill Cooldown

[Shang 466]

M2 Download Center

This is the hidden content, please

• Sign In
• or
• Sign Up

( Internal )

Hi devs, today I will release the fix I made for the skill cooldown, already fixed on official servers, this is the bug it self:

And this is the fix:

Regards!

This is the hidden content, please

• Sign In
• or
• Sign Up

### root/ui.py
### Search:
	def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a):
		wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a)
### Add after:		
	def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0):
		wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime)
	
	def RestoreSlotCoolTime(self, key):
		wndMgr.RestoreSlotCoolTime(self.hWnd, key)

 

On 12/24/2017 at 9:19 AM, Horinna said:

HI,

thank you.  Everything work.

But what is with THIS "classic" bug? @Shang

Thanks to @Horinna for report that bug.

Here's the fix:

""" Find this:

					elif (not self.__CanUseSkillNow()) or (skillGrade != j):
						skillPage.SetSlotCount(realSlotIndex, 0)
						skillPage.DisableCoverButton(realSlotIndex)

Add this under:"""

						skillPage.DeactivateSlot(realSlotIndex)
						
# After the else, paste this:

					if player.IsSkillActive(slotIndex) and (skillGrade == j): # fix001
						skillPage.ActivateSlot(realSlotIndex)

# The if should look like this:

					if (skillGrade == skill.SKILL_GRADE_COUNT) and j == (skill.SKILL_GRADE_COUNT-1):
						skillPage.SetSlotCountNew(realSlotIndex, skillGrade, skillLevel)
					elif (not self.__CanUseSkillNow()) or (skillGrade != j):
						skillPage.SetSlotCount(realSlotIndex, 0)
						skillPage.DisableCoverButton(realSlotIndex)
						skillPage.DeactivateSlot(realSlotIndex) # fix
					else:
						skillPage.SetSlotCountNew(realSlotIndex, skillGrade, skillLevel)
						
					if player.IsSkillActive(slotIndex) and (skillGrade == j): # fix
						skillPage.ActivateSlot(realSlotIndex)

 

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Sebypunct 24]

Nice , thanks

[Hik 124]

Thanks

[Johnny69 519]

Very good code. Thanks.

[Shang 466]

hace 20 minutos, Johnny69 dijo:

Very good code. Thanks.

  Hide contents

### root/ui.py
### Search:
	def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a):
		wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a)
### Add after:		
	def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0):
		wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime)
	
	def RestoreSlotCoolTime(self, key):
		wndMgr.RestoreSlotCoolTime(self.hWnd, key)

 

 

Yeah, I forgot it xD.

[felixenpr 0]

Nice shang!

[MooFuuuuck 2]

It doesn't work for me. There is no difference to before . my syssr is empty

[Shang 466]

hace 3 horas, MooFuuuuck dijo:

It doesn't work for me. There is no difference to before . my syssr is empty

Did you change the uicharacter.py side?

[MooFuuuuck 2]

vor 21 Stunden schrieb Shang:

Did you change the uicharacter.py side?

yes i did

[.SliceR 8]

#edit

Ok now the fix for the skill cooldown works! But I think I have found a bug.

When you have two or more "activatable skills" that fix works wrong. Visual you can only active one "activatable skill". The other one will be stopped, but both are still activated.

 

GIF: (without that fix)

GIF: (with that fix = bug)

[Shang 466]

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Horinna 4]

HI,

thank you.  Everything work.

But what is with THIS "classic" bug? @Shang

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Shang 466]

hace 7 horas, Horinna dijo:

HI,

thank you.  Everything work.

But what is with THIS "classic" bug? @Shang

Main post updated, try the fix please and tell me if it fully works.

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Horinna 4]

Works.  Thank you, @Shang

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[ReFresh 3151]

GameWindow.Open - exceptions.AttributeError:'SlotWindow' object has no attribute 'RestoreSlotCoolTime'

Can someone help me to fix this error?

[Shang 466]

En 1/10/2018 a las 18:51, ReFresh dijo:

GameWindow.Open - exceptions.AttributeError:'SlotWindow' object has no attribute 'RestoreSlotCoolTime'

Can someone help me to fix this error?

Read the main post.

[ReFresh 3151]

1 hour ago, Shang said:

Read the main post.

I tried to do it again, but here is the same problem. Problem is maybe in python version I'm using 2.2

[Shang 466]

hace 5 horas, ReFresh dijo:

I tried to do it again, but here is the same problem. Problem is maybe in python version I'm using 2.2

 

En 10/9/2017 a las 16:46, Shang dijo:

### root/ui.py
### Search:
	def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a):
		wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a)
### Add after:		
	def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0):
		wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime)
	
	def RestoreSlotCoolTime(self, key):
		wndMgr.RestoreSlotCoolTime(self.hWnd, key)

 

 

[3bd0 221]

I don't have this def in my ui.py

def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a):

 

[Grimmjow 81]

il y a 2 minutes, 3bd0 a dit :

I don't have this def in my ui.py

def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a):

 

Add after that:

def SetSlotCoolTime(self, slotIndex, coolTime, elapsedTime = 0.0):

 

[3bd0 221]

11 minutes ago, Grimmjow said:

Add after that:

def SetSlotCoolTime(self, slotIndex, coolTime, elapsedTime = 0.0):

 

that's what I did, but there is no difference ingame, with nth in syserr

[Aerrow 42]

Same here. I think this is not compatible with the highlight slot system.

[LordZiege 368]

i have this problem:

 

no syserr or something.

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Syreldar 2735]

This whole thing only fixes correctly the second issue, the one brought by Horinna.

The first issue doesn't get solved like this as long as it resets the spell interface

Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif

Edited September 3, 2022 by Metin2 Dev
Core X - External 2 Internal

[Shang 466]

hace 50 minutos, Syreldar dijo:

This whole thing only fixes correctly the second issue, the one brought by Horinna.

The first issue doesn't get solved like this as long as it resets the spell interface

Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif

I'll take a look when I have time.

Edited September 3, 2022 by Metin2 Dev
Core X - External 2 Internal