(Better json) Fishing Load Renewal

[Mitachi 3366]

Download Center

This is the hidden content, please

• Sign In
• or
• Sign Up

This is the hidden content, please

• Sign In
• or
• Sign Up

The tutorial contains an already configured json file!

Q. What is trivially the difference?
A. Here's an example:

Spoiler

Old fishing.txt:

New fishing.json:


---

I tested it, here is some evidence + a dip into the past 

After installing, you can do /fish_simul to test if it works properly.

Non-Critical issue
The strings for fish names in Korean are broken at the time of reading
I could have done something about it but I noticed that korean names are mostly used by fish_simul
(A gm command used to test fishing), and since we are not Korean
I didn't bother much to fix it, rather I did a cleanup to my fishing.cpp/.h which I can post below if you want.

   I thank @ martysama0134 for the idea.

Edited May 9, 2023 by Mitachi
Core X - External 2 Internal

[Thorek 374]

You can check if ifstream is open instead of using the filesystem library (which comes from C++17):

std::ifstream file(LocaleService_GetBasePath() + "/fishing.json");

if (!file.is_open()
	return;

// ...

Also you should remove #include <fmt/core.h> to avoid compilation errors.

Edited May 9, 2023 by Thorek

[Mitachi 3366]

7 hours ago, Thorek said:

You can check if ifstream is open instead of using the filesystem library (which comes from C++17):

std::ifstream file(LocaleService_GetBasePath() + "/fishing.json");

if (!file.is_open()
	return;

// ...

Also you should remove #include <fmt/core.h> to avoid compilation errors.

no