Jump to content

(Better json) Fishing Load Renewal


Recommended Posts

  • Developer

Download Center

This is the hidden content, please

This is the hidden content, please

The tutorial contains an already configured json file!

Q.
 What is trivially the difference?
A. Here's an example:

Spoiler


Old fishing.txt:

spacer.png


New fishing.json:
spacer.png

---

spacer.png


I tested it, here is some evidence + a dip into the past 👀

spacer.png

After installing, you can do /fish_simul to test if it works properly.

Non-Critical issue
The strings for fish names in Korean are broken at the time of reading
I could have done something about it but I noticed that korean names are mostly used by fish_simul
(A gm command used to test fishing), and since we are not Korean
I didn't bother much to fix it, rather I did a cleanup to my fishing.cpp/.h which I can post below if you want.

   I thank @ martysama0134 for the idea.

Edited by Mitachi
Core X - External 2 Internal
  • Metin2 Dev 61
  • Think 1
  • Good 9
  • Love 4
  • Love 24

503953077003354113.png

Link to comment
Share on other sites

  • Replies 2
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

You can check if ifstream is open instead of using the filesystem library (which comes from C++17):

std::ifstream file(LocaleService_GetBasePath() + "/fishing.json");

if (!file.is_open()
	return;

// ...

Also you should remove #include <fmt/core.h> to avoid compilation errors.

Edited by Thorek
  • Facepalm 1
Link to comment
Share on other sites

  • Developer
7 hours ago, Thorek said:

You can check if ifstream is open instead of using the filesystem library (which comes from C++17):

std::ifstream file(LocaleService_GetBasePath() + "/fishing.json");

if (!file.is_open()
	return;

// ...

Also you should remove #include <fmt/core.h> to avoid compilation errors.

no

  • Facepalm 2
  • Good 1

503953077003354113.png

Link to comment
Share on other sites

Announcements



×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.