fix Fix Too Long Cube Result List Text

[MariusExygo 1481]

How to fix 

Cube_request_result_list: Too long cube result list text. ?

 

Go in cube.cpp

Replace 

Spoiler

        if (resultText.size() - 20 >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, length: %d)", npcVNUM, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

 

With this:

Spoiler

        int WildFantasytFIXED;
        if (resultText.size() < 20)
        {
            WildFantasytFIXED = 20 - resultText.size();
        }
        else
        {
            WildFantasytFIXED = resultText.size() - 20;
        }
        if (WildFantasytFIXED >= CHAT_MAX_LEN)
        {
            sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, FIXED_size_value_exygo: %d, length: %d)", npcVNUM, WildFantasytFIXED, resultText.size());
            resultText.clear();
            resultCount = 0;
        }

The problem was caused by a comparison between a negative number and a number

[Kronzu 11]

WORK?

[Ken 1035]

size_t resultTextSize = resultText.size() < 20 ? 20 - resultText.size() : resultText.size() - 20;

if (resultTextSize >= CHAT_MAX_LEN)
{
	sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, length: %d)", npcVNUM, resultText.size());
	resultText.clear();
	resultCount = 0;
}

 It's more effectively and short. Thank you for share this fix with us.

Kind Regards ~ Ken

[MariusExygo 1481]

On 12/17/2015 at 8:19 PM, Ken said:

size_t resultTextSize = resultText.size() < 20 ? 20 - resultText.size() : resultText.size() - 20;

if (resultTextSize >= CHAT_MAX_LEN)
{
	sys_err("[CubeInfo] Too long cube result list text. (NPC: %d, length: %d)", npcVNUM, resultText.size());
	resultText.clear();
	resultCount = 0;
}

 It's more effectively and short. Thank you for share this fix with us.

Kind Regards ~ Ken

I was noob at that time and didn't know about that conversion ...