Cunoo 210 Posted September 16, 2021 Share Posted September 16, 2021 (edited) 2 hours ago, Distraught said: How can you be just so so so so so stupid? If your server kicks you out it's because you don't even know what you are doing. Not my fix is the problem, it's more like your knowledge... Actually marty just repeated half of what I wrote down before and you're saying what I wrote is not working while licking his ass clean at the same time. (don't get me wrong, it's not against marty, it's against you and other incompetent stupid-ass motherfuckers like you) Sorry for the language... But for nothing else... The effects you use on your maps are not managed by EffectManager. They are managed by the Area itself. I dont say anything on you or your fix *WTF.. You only dont understand.. I said I dont got black screen but kick.. So your fix works! But I think missing code or something because before I can got black screen, my char is kicked.. I think there is more than your fix.. And yes Im not pro, but Marty said he is not sure where is problem for sure and you safe it one of long time ago problem with one line??????!!! Respect if anyone say feedback.. Can be usefull for all.. Just with your code is no problem but game is not fit.. I dont have too much experiences with debug but I think there is overflow with some things.. Edit: Second kick before black screen.. Game works fine without lags without black screen but kicking if come black screen... Edited September 16, 2021 by Cunoo Link to comment Share on other sites More sharing options...
xGalardo 13 Posted September 16, 2021 Share Posted September 16, 2021 I had the client on a tray for 12 hours, it works perfectly, no ejections, etc. I also installed Marty's fix, which really fixed the Flame Ghost monster "bug". I don't know if it matters, but i use Marty's source. Link to comment Share on other sites More sharing options...
Cunoo 210 Posted September 16, 2021 Share Posted September 16, 2021 19 minutes ago, xGalardo said: I had the client on a tray for 12 hours, it works perfectly, no ejections, etc. I also installed Marty's fix, which really fixed the Flame Ghost monster "bug". I don't know if it matters, but i use Marty's source. Me too Marty fix works fine but this is only part.. I have strange bug with first part. I dont have problem with black screen but with kick if black screen cooming.. My cpu is 30%+ up if cooming black screen. I think this is not easy to safe with one line.. There is more things bad than granny controller. M 1 Link to comment Share on other sites More sharing options...
Honorable Member Owsap 8181 Posted September 16, 2021 Honorable Member Share Posted September 16, 2021 @Cunoowhat do you mean with kick? Does the client crash or does the character get disconnected back the the login phase? If the client is crashing, have you tried to debug it? https://owsap.dev/ / https://osf.owsap.dev/ Link to comment Share on other sites More sharing options...
Cunoo 210 Posted September 17, 2021 Share Posted September 17, 2021 (edited) 14 hours ago, Owsap said: @Cunoowhat do you mean with kick? Does the client crash or does the character get disconnected back the the login phase? If the client is crashing, have you tried to debug it? No, client works fine.. I'm kicked to login before black screen.. So I never got black screen but insta kick to login.. Edited September 17, 2021 by Cunoo Link to comment Share on other sites More sharing options...
Honorable Member Owsap 8181 Posted September 17, 2021 Honorable Member Share Posted September 17, 2021 1 minute ago, Cunoo said: No, client works fibe.. I'm kicked to login before black screen.. So I never got black screen but insta kick to login.. I find it hard to believe that 1 line of code causes that. It must be something else and certainly it's another topic. 1 https://owsap.dev/ / https://osf.owsap.dev/ Link to comment Share on other sites More sharing options...
PetePeter 36 Posted September 17, 2021 Share Posted September 17, 2021 1 minute ago, Owsap said: I find it hard to believe that 1 line of code causes that. It must be something else and certainly it's another topic. Can be about "_IMPROVED_PACKET_ENCRYPTION_" I had some similar problem with it (Like client instant kick instead of lagging when sorting a big inventory) Link to comment Share on other sites More sharing options...
Cunoo 210 Posted September 17, 2021 Share Posted September 17, 2021 24 minutes ago, PetePeter said: Can be about "_IMPROVED_PACKET_ENCRYPTION_" I had some similar problem with it (Like client instant kick instead of lagging when sorting a big inventory) I think can be something like this.. Because I never got black screen after fix, but if I can "get" black screen (10 hours+ in game) Im kicked.. I test it 3x and same problem just Im kicked before I can got black screen... Game is compiled clean from kraizy same as client, only for test.. I think there is something more bad.. Game is overflowed with something more.. Im not sure where is problem because I try debug and nothing happen.. I dont have too much deep knowledges for more.. But for me is this problem really strange because I use clean game for test... Today I test it on my game.. So I write feedback too late.. Link to comment Share on other sites More sharing options...
Shahin 223 Posted September 17, 2021 Share Posted September 17, 2021 3 hours ago, Cunoo said: I think can be something like this.. Because I never got black screen after fix, but if I can "get" black screen (10 hours+ in game) Im kicked.. I test it 3x and same problem just Im kicked before I can got black screen... Game is compiled clean from kraizy same as client, only for test.. I think there is something more bad.. Game is overflowed with something more.. Im not sure where is problem because I try debug and nothing happen.. I dont have too much deep knowledges for more.. But for me is this problem really strange because I use clean game for test... Today I test it on my game.. So I write feedback too late.. if you find the problem, please leave the fix over here. it might help to improve the "black screen issue" topic, so it will be an upgrade to what @ Distraught left for us. Link to comment Share on other sites More sharing options...
Honorable Member martysama0134 7180 Posted September 18, 2021 Honorable Member Share Posted September 18, 2021 (edited) On 9/16/2021 at 2:34 PM, Distraught said: The effects you use on your maps are not managed by EffectManager. They are managed by the Area itself. I've checked them, and they don't stack up. The loaded effects will keep being played as a loop until you move outside of the closed 2x2 area. In here there was only one element inside m_EffectInstanceMap, and rkEftMgr.DestroyUnsafeEffectInstance has never being called. I initially thought to move the CArea::__UpdateEffectList call inside CPythonBackground::Update, but we probably don't even need to do so if there are no temporary effects in the maps. Edited August 17, 2022 by Metin2 Dev Core X - External 2 Internal 2 3 Check out my GitHub Link to comment Share on other sites More sharing options...
Premium WeedHex 635 Posted September 19, 2021 Premium Share Posted September 19, 2021 (edited) Edited August 25, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Active Member lime 247 Posted September 26, 2021 Active Member Share Posted September 26, 2021 On 9/15/2021 at 1:02 PM, martysama0134 said: The black screen was mostly caused by two major bugs: The granny controller freezing the process for n seconds until you get dc'd from the game You can test it by: Spawning tons of monsters Minimize the client for 30 - 40 minutes Maximizing the window again (it will freeze exactly at this point) The EffectManager not destroying the expired effects while the window was minimized, which caused all the executed effects to stack up and be run all at once after maximizing the window again You can test this bug very easily: Spawn tons Flame Ghosts and minimize the window /ma "Flame Ghost" 100 /cannot_dead I wasn't sure how to solve the 1st one, but for the 2nd one you can fix it in one of these ways: 1st Way) refresh only once every 256 frames = 4-6 seconds depending on the lag 2nd Way) effect manager refresh for every frame 3rd Way) move the update from RenderGame to UpdateGame (it may not be called if skipFrame=true on ::Process) I've tried the 2nd way and it makes my Aura Sword flicker, is it normal? 1 Link to comment Share on other sites More sharing options...
ManecasPT 81 Posted January 3, 2022 Share Posted January 3, 2022 (edited) Nice fix but in some PC's players attack, monster movement and monster attack are much slower than usual, removing this fix resolves that problem. i'm talking about Marty fix: EDIT: Edited January 3, 2022 by ManecasPT Link to comment Share on other sites More sharing options...
EAkar 8 Posted April 23, 2022 Share Posted April 23, 2022 On 9/17/2021 at 1:48 PM, Cunoo said: I think can be something like this.. Because I never got black screen after fix, but if I can "get" black screen (10 hours+ in game) Im kicked.. I test it 3x and same problem just Im kicked before I can got black screen... Game is compiled clean from kraizy same as client, only for test.. I think there is something more bad.. Game is overflowed with something more.. Im not sure where is problem because I try debug and nothing happen.. I dont have too much deep knowledges for more.. But for me is this problem really strange because I use clean game for test... Today I test it on my game.. So I write feedback too late.. "_IMPROVED_PACKET_ENCRYPTION_" delete this from your files. But fix it before you delete it. delete this encryption after repairing. 1 Link to comment Share on other sites More sharing options...
CONTROL 79 Posted December 6, 2023 Share Posted December 6, 2023 (edited) On 9/17/2021 at 1:08 PM, Cunoo said: No, client works fine.. I'm kicked to login before black screen.. So I never got black screen but insta kick to login.. input_main.cpp else if (iDelta < -(iServerDelta / 50)) // Bugged { // I understand that it goes 20msec faster in 1 second. sys_log(0, "SPEEDHACK: DETECTED! %s (delta %d %d)", ch->GetName(), iDelta, iServerDelta); if (ch->GetGMLevel() == GM_IMPLEMENTOR) { // Logged @fixme415 ch->ChatPacket(CHAT_TYPE_INFO, "SPEEDHACK: DETECTED! %s (delta %d %d)", ch->GetName(), iDelta, iServerDelta); } else { //ch->GetDesc()->DelayedDisconnect(3); } } i had this problem before, it's mainly because of this right here, if you're not working on a live server you gonna have to adjust the server time zone with (tzsetup) every once in a while or just disable the DelayedDisconnect and keep working. Great fix btw thx @ Distraught Edited December 6, 2023 by CONTROL Link to comment Share on other sites More sharing options...
rbarbosas 0 Posted March 22 Share Posted March 22 Link to comment Share on other sites More sharing options...
Recommended Posts