fix [Fix] GM Character's Effect Fix After /inv Command

[blaxis 443]

You all know the famous problem that comes up from time to time.

Let me explain it briefly for those who don't know; After being invisible with the /inv command and becoming visible again, the effects of the GM character are not visible. The ENABLE_CANSEEHIDDENTHING_FOR_GM macro edit found in the Martysama files is an edit that is only valid for your screen. In other words, the effects continue to be invisible for other players.

I didn't care about this problem until now, but since I had to solve this problem in order to make some edits. I took a look at the codes a little and discovered a very small, harmless manipulation method to solve this problem. And as a result, I wanted to solve the problem and share it with you.

The only edit you need to make is as follows.

Open the InstanceBaseEffect.cpp file and edit it as I showed:

This is the hidden content, please

• Sign In
• or
• Sign Up

That's all. You can watch the proof video below.

This is the hidden content, please

• Sign In
• or
• Sign Up

 

Edited November 23, 2024 by blaxis

[MysteriousDev 8]

There is still issue with insert packet - cheaters can see if you're there. Also /observer is broken on warp, cause it sends insert packet before the observer mode is turned on (which trigger is sent by client).

[blaxis 443]

2 hours ago, MysteriousDev said:

There is still issue with insert packet - cheaters can see if you're there. Also /observer is broken on warp, cause it sends insert packet before the observer mode is turned on (which trigger is sent by client).

The only thing I'm talking about here is that the GM character's effects disappear when you come out of stealth mode. (visual bug)

Edited November 24, 2024 by blaxis

[MysteriousDev 8]

2 hours ago, blaxis said:

The only thing I'm talking about here is that the GM character's effects disappear when you come out of stealth mode. (visual bug)

Nothing wrong with the fix. Just saying about another bug (or should I say bad design) which is somehow related to the /inv command.

Edited November 24, 2024 by MysteriousDev

[Nuzzo 55]

On 11/23/2024 at 5:50 PM, blaxis said:

You all know the famous problem that comes up from time to time.

Let me explain it briefly for those who don't know; After being invisible with the /inv command and becoming visible again, the effects of the GM character are not visible. The ENABLE_CANSEEHIDDENTHING_FOR_GM macro edit found in the Martysama files is an edit that is only valid for your screen. In other words, the effects continue to be invisible for other players.

I didn't care about this problem until now, but since I had to solve this problem in order to make some edits. I took a look at the codes a little and discovered a very small, harmless manipulation method to solve this problem. And as a result, I wanted to solve the problem and share it with you.

The only edit you need to make is as follows.

Open the InstanceBaseEffect.cpp file and edit it as I showed:

Hidden Content

 

		case AFFECT_INVISIBILITY:
#ifdef ENABLE_CANSEEHIDDENTHING_FOR_GM // You may not have this. We have nothing to do with it.
			if (__MainCanSeeHiddenThing())
			{
				if (isVisible)
				{
					m_GraphicThingInstance.BlendAlphaValue(0.5f, 1.0f);
				}
				else
				{
					m_GraphicThingInstance.BlendAlphaValue(1.0f, 1.0f);
				}
				break;
			}
#endif
			if (isVisible)
			{
				m_GraphicThingInstance.ClearAttachingEffect();
				__EffectContainer_Destroy();
				DetachTextTail();
			}
			else
			{
				m_GraphicThingInstance.BlendAlphaValue(1.0f, 1.0f);
				if (IsGameMaster() && !__IsMainInstance()) // Add!!
				{
					ChangeArmor(0);
				}
				else
				{
					// enclose these two in an "else" block.
					AttachTextTail();
					RefreshTextTail();
				}
					
			}

Note: Some of you may think that there is no need to use the "__IsMainInstance()" condition when the "IsGameMaster()" condition is present, but do not remove it. It is very important.

 

 

That's all. You can watch the proof video below.

This is the hidden content, please

• Sign In
• or
• Sign Up

 

When I disable invisibility the character will see me without armor