Metin2 | Mount System Renewal

[glosteng4141 248]

@ZeNu @Mali61 @Koray @Raylee

 

Hello everybody

 

I opened the questions section about this problem, but nobody helped. Yes, I know nobody has to help. But it's nice to help a person who needs help. Likewise, when a person asks me, I help.

 

My problem:

There is only ITEM_COSTUME problem.

This is a problem when you change objects like costume, weapon costume, wing(sash), and hair.

 

Do you have any idea how to fix this?

 

Thank you very much for your help in advance.

 

Also, this problem does not occur with normal weapons and armor. only occurs in ITEM_COSTUME system.

 

For example:

 

COSTUME_WEAPON
COSTUME_SASH
COSTUME_BODY
COSTUME_HAIR

 

Problem Gif

 

https://metin2.download/picture/H0yi0BHSc5S14X5xIvFO4jnX76Hm7Wtr/.gif

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Neverr 74]

someone know how to fix this error https://metin2.download/picture/eXNLT04bFoeAPr4P5swZafc75xu8qHcS/.png 

 

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Thrall 421]

On 11/9/2020 at 4:51 PM, Neverr said:

someone know how to fix this error https://metin2.download/picture/eXNLT04bFoeAPr4P5swZafc75xu8qHcS/.png 

 

 

Hi!

In questlua_horse.cpp add at the top:

#include "arena.h"

 

In arena.h add at the top:

#include "char.h"

 

The system works fine, i like it a lot, the only problem i occured in my test server is that if i have my horse summoned and i use the mount item, the server crashes, i don't know if its only me but you can test to see if you have this problem too, i have fixed the problem by doing the following:

 

In MountSystem.cpp:

// search for 
bool CMountActor::Mount(LPITEM mountItem)

// look down for
	Unmount();

//and add above:
	if (m_pkOwner->GetHorse())
		m_pkOwner->HorseSummon(false);

 

Should look like this:

https://metin2.download/picture/yzhbek856vb9cRbNC9nR29ZQfsNz218J/.png

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[RenoxHD 5]

Good day together, I have 2 mounts in the inventory and press on Ctrl and G and then 1x mount goes into the slot and then the mount comes out and wants to ride on it now push again Ctrl and G and now want to ride and ride for 2 seconds and get kicked out again and the other mount comes in in the slot and the first mount in the inventory

[Metin2 Dev 12235]

TIMER_BASED_ON_WEAR how to??

it don't work now xd
https://metin2.download/picture/3Ywk5q78xHy8a3Of16p7Pl9N96YaJGi5/.gif

??????

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[I bims 1 WLAN 4]

Do I have to replace the files in the svn folder or add them to the respective file below?

[I bims 1 WLAN 4]

cmd_general.cpp:1373:18: error: member access into incomplete type 'CMountSystem'
                        if(mountSystem->CountSummoned() == 0)
                                      ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
cmd_general.cpp:1375:16: error: member access into incomplete type 'CMountSystem'
                                mountSystem->Unmount(mobVnum);
                                           ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
cmd_general.cpp:2542:18: error: member access into incomplete type 'CMountSystem'
                        if(mountSystem->CountSummoned() == 0)
                                      ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
cmd_general.cpp:2544:16: error: member access into incomplete type 'CMountSystem'
                                mountSystem->Unmount(mobVnum);
                                           ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
cmd_general.cpp:2549:18: error: member access into incomplete type 'CMountSystem'
                        if(mountSystem->CountSummoned() == 1)
                                      ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
cmd_general.cpp:2551:16: error: member access into incomplete type 'CMountSystem'
                                mountSystem->Mount(mobVnum, mount);
                                           ^
./char.h:2:7: note: forward declaration of 'CMountSystem'
class CMountSystem;
      ^
6 errors generated.

Edited January 3, 2022 by I bims 1 WLAN

[SamuraiHUN 1963]

char.cpp

add this to char.cpp
 

void CHARACTER::ReloadMountBonus(LPITEM mountItem)
{
	RemoveAffect(AFFECT_MOUNT_BONUS);
	
	for (int i = 0; i < ITEM_APPLY_MAX_NUM; ++i)
	{
		if (mountItem->GetProto()->aApplies[i].bType == APPLY_NONE)
			continue;

		AddAffect(AFFECT_MOUNT_BONUS, aApplyInfo[mountItem->GetProto()->aApplies[i].bType].bPointType, mountItem->GetProto()->aApplies[i].lValue, AFF_NONE, 60*60*24*365, 0, false);
	}
}

char.h

search this:

 

		bool 				IsRidingMount();

add under this:

 

		void				ReloadMountBonus(LPITEM mountItem);

MountSystem.cpp

search this:
 

bool CMountActor::Mount(LPITEM mountItem)

modify the function this:

 

bool CMountActor::Mount(LPITEM mountItem)
{
	if (0 == m_pkOwner)
		return false;
	
	if(!mountItem)
		return false;

	if (m_pkOwner->IsHorseRiding())
		m_pkOwner->StopRiding();
	
	if (m_pkOwner->GetHorse())
		m_pkOwner->HorseSummon(false);

	Unmount();
	int fixtime;

	for (int i = 0; i < ITEM_LIMIT_MAX_NUM; i++)
	{
		if ((LIMIT_REAL_TIME == mountItem->GetLimitType(i)) || (LIMIT_REAL_TIME_START_FIRST_USE == mountItem->GetLimitType(i)))
			fixtime = (DWORD)mountItem->GetSocket(0);
		else
			fixtime = INFINITE_AFFECT_DURATION;
	}
	m_pkOwner->AddAffect(AFFECT_MOUNT, POINT_MOUNT, m_dwVnum, AFF_NONE, fixtime - time(0), 0, true);

	m_pkOwner->ReloadMountBonus(mountItem);
	m_pkOwner->ComputePoints();
	
	return m_pkOwner->GetMountVnum() == m_dwVnum;
}

item_proto you can remove real_time for mount.

Edited August 8, 2022 by SamuraiHUN

[Ymir 4]

Is this code tested and does it work? I see a lot of negative feedback. Sorry for the quite dated UP, but I'm interested in the System.

[blanco 244]

12 hours ago, Ymir said:

Is this code tested and does it work? I see a lot of negative feedback. Sorry for the quite dated UP, but I'm interested in the System.

it works but you might want to modify / expand it to your own liking

[Ymir 4]

Spoiler

 

The System seems functional and without BUG for the moment. Do we know how to solve the name distance problem? "Metin2Dev Mount" is too high above the mount's body. Anyone have any ideas? Thanks in the meantime!

Edited November 27, 2022 by Metin2 Dev
Core X - External 2 Internal

[Syreldar 2736]

1 hour ago, Ymir said:

  Hide contents

 

The System seems functional and without BUG for the moment. Do we know how to solve the name distance problem? "Metin2Dev Mount" is too high above the mount's body. Anyone have any ideas? Thanks in the meantime!

 

[Ymir 4]

On 11/27/2022 at 2:16 PM, Syreldar said:

 

In the meantime, thank you for the answer, I'll try it and come back with the tests.

[Filiq 33]

i get this error:

In file included from char.cpp:66:
./MountSystem.h:53:10: error: no template named 'unordered_map' in namespace 'bo                                                                                        ost'; did you mean 'quest::unordered_map'?
        typedef boost::unordered_map<DWORD,     CMountActor*>           TMountAc                                                                                        torMap;
                ^~~~~~~~~~~~~~~~~~~~
                quest::unordered_map
/usr/include/c++/v1/unordered_map:920:28: note: 'quest::unordered_map' declared                                                                                         here
class _LIBCPP_TEMPLATE_VIS unordered_map

should to type quest instead of boost??

[Filiq 33]

13 hours ago, Filiq said:

i get this error:

In file included from char.cpp:66:
./MountSystem.h:53:10: error: no template named 'unordered_map' in namespace 'bo                                                                                        ost'; did you mean 'quest::unordered_map'?
        typedef boost::unordered_map<DWORD,     CMountActor*>           TMountAc                                                                                        torMap;
                ^~~~~~~~~~~~~~~~~~~~
                quest::unordered_map
/usr/include/c++/v1/unordered_map:920:28: note: 'quest::unordered_map' declared                                                                                         here
class _LIBCPP_TEMPLATE_VIS unordered_map

should to type quest instead of boost??

fixed, instead of boost i put "std"

[Alessio 261]

can someone help me? 
for the first 2 errors i tried the fix up here and it doesn't work

In file included from questlua_horse.cpp:9:
./arena.h:59:36: error: use of undeclared identifier 'CHARACTER_MANAGER'
        LPCHARACTER GetPlayerA() { return CHARACTER_MANAGER::instance().FindByPID(m_dwPIDA); }
                                          ^
./arena.h:60:36: error: use of undeclared identifier 'CHARACTER_MANAGER'
        LPCHARACTER GetPlayerB() { return CHARACTER_MANAGER::instance().FindByPID(m_dwPIDB); }
                                          ^
2 errors generated.
gmake: *** [Makefile:118: OBJDIR/questlua_horse.o] Error 1
gmake: *** Waiting for unfinished jobs....
cmd_general.cpp:2180:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2190:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2233:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2238:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2347:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2459:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2488:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2493:1: error: function definition is not allowed here
{
^
8 errors generated.
gmake: *** [Makefile:118: OBJDIR/cmd_general.o] Error 1
root@metin2:/usr/metin2/src/game/src #

Edited March 8, 2023 by Alessio

[Alessio 261]

1 hour ago, Alessio said:

can someone help me? 
for the first 2 errors i tried the fix up here and it doesn't work

In file included from questlua_horse.cpp:9:
./arena.h:59:36: error: use of undeclared identifier 'CHARACTER_MANAGER'
        LPCHARACTER GetPlayerA() { return CHARACTER_MANAGER::instance().FindByPID(m_dwPIDA); }
                                          ^
./arena.h:60:36: error: use of undeclared identifier 'CHARACTER_MANAGER'
        LPCHARACTER GetPlayerB() { return CHARACTER_MANAGER::instance().FindByPID(m_dwPIDB); }
                                          ^
2 errors generated.
gmake: *** [Makefile:118: OBJDIR/questlua_horse.o] Error 1
gmake: *** Waiting for unfinished jobs....
cmd_general.cpp:2180:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2190:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2233:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2238:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2347:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2459:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2488:1: error: function definition is not allowed here
{
^
cmd_general.cpp:2493:1: error: function definition is not allowed here
{
^
8 errors generated.
gmake: *** [Makefile:118: OBJDIR/cmd_general.o] Error 1
root@metin2:/usr/metin2/src/game/src #

i fixed this but now when i start the server i get this error with item_proto.txt
 

SYSERR: Mar  8 17:18:29 :: Set_Proto_Item_Table: ItemProto Reading Failed : Invalid value. (index: 3, col: 3, value: COSTUME_MOUNT)
SYSERR: Mar  8 17:18:29 :: Set_Proto_Item_Table: 	0 ~ 3 Values: 52001,0,28,

look like it doesn't recognize "COSTUME_MOUNT"

 

[jadsl01 0]

Does anyone have fixes for this system ?

[garofolo 14]

** UPDATE char.cpp

This modification is so that when you teleport to other maps or relog while the mount is equipped, you always ride it, and it is just an example.

Edited July 29, 2024 by Metin2 Dev International
Core X - External 2 Internal