Shang 369 Posted September 10, 2017 Share Posted September 10, 2017 (edited) M2 Download Center This is the hidden content, please Sign In or Sign Up ( Internal ) Hi devs, today I will release the fix I made for the skill cooldown, already fixed on official servers, this is the bug it self: And this is the fix: Regards! This is the hidden content, please Sign In or Sign Up ### root/ui.py ### Search: def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a): wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a) ### Add after: def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0): wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime) def RestoreSlotCoolTime(self, key): wndMgr.RestoreSlotCoolTime(self.hWnd, key) On 12/24/2017 at 9:19 AM, Horinna said: HI, thank you. Everything work. But what is with THIS "classic" bug? @Shang Thanks to @Horinna for report that bug. Here's the fix: """ Find this: elif (not self.__CanUseSkillNow()) or (skillGrade != j): skillPage.SetSlotCount(realSlotIndex, 0) skillPage.DisableCoverButton(realSlotIndex) Add this under:""" skillPage.DeactivateSlot(realSlotIndex) # After the else, paste this: if player.IsSkillActive(slotIndex) and (skillGrade == j): # fix001 skillPage.ActivateSlot(realSlotIndex) # The if should look like this: if (skillGrade == skill.SKILL_GRADE_COUNT) and j == (skill.SKILL_GRADE_COUNT-1): skillPage.SetSlotCountNew(realSlotIndex, skillGrade, skillLevel) elif (not self.__CanUseSkillNow()) or (skillGrade != j): skillPage.SetSlotCount(realSlotIndex, 0) skillPage.DisableCoverButton(realSlotIndex) skillPage.DeactivateSlot(realSlotIndex) # fix else: skillPage.SetSlotCountNew(realSlotIndex, skillGrade, skillLevel) if player.IsSkillActive(slotIndex) and (skillGrade == j): # fix skillPage.ActivateSlot(realSlotIndex) Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal 83 1 1 1 1 16 2 58 Link to comment Share on other sites More sharing options...
Sebypunct 24 Posted September 10, 2017 Share Posted September 10, 2017 Nice , thanks Link to comment Share on other sites More sharing options...
Hik 108 Posted September 10, 2017 Share Posted September 10, 2017 Thanks Link to comment Share on other sites More sharing options...
Johnny69 365 Posted September 10, 2017 Share Posted September 10, 2017 Very good code. Thanks. 2 Link to comment Share on other sites More sharing options...
Shang 369 Posted September 10, 2017 Author Share Posted September 10, 2017 hace 20 minutos, Johnny69 dijo: Very good code. Thanks. Hide contents ### root/ui.py ### Search: def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a): wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a) ### Add after: def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0): wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime) def RestoreSlotCoolTime(self, key): wndMgr.RestoreSlotCoolTime(self.hWnd, key) Yeah, I forgot it xD. Link to comment Share on other sites More sharing options...
felixenpr 0 Posted September 11, 2017 Share Posted September 11, 2017 Nice shang! Link to comment Share on other sites More sharing options...
MooFuuuuck 2 Posted September 25, 2017 Share Posted September 25, 2017 It doesn't work for me. There is no difference to before . my syssr is empty Link to comment Share on other sites More sharing options...
Shang 369 Posted September 25, 2017 Author Share Posted September 25, 2017 hace 3 horas, MooFuuuuck dijo: It doesn't work for me. There is no difference to before . my syssr is empty Did you change the uicharacter.py side? Link to comment Share on other sites More sharing options...
MooFuuuuck 2 Posted September 26, 2017 Share Posted September 26, 2017 vor 21 Stunden schrieb Shang: Did you change the uicharacter.py side? yes i did Link to comment Share on other sites More sharing options...
.SliceR 7 Posted October 30, 2017 Share Posted October 30, 2017 #edit Ok now the fix for the skill cooldown works! But I think I have found a bug. When you have two or more "activatable skills" that fix works wrong. Visual you can only active one "activatable skill". The other one will be stopped, but both are still activated. GIF: (without that fix) GIF: (with that fix = bug) 3 1 1 1 2 Link to comment Share on other sites More sharing options...
Shang 369 Posted October 31, 2017 Author Share Posted October 31, 2017 (edited) Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal 1 Link to comment Share on other sites More sharing options...
Horinna 4 Posted December 24, 2017 Share Posted December 24, 2017 (edited) HI, thank you. Everything work. But what is with THIS "classic" bug? @Shang Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Shang 369 Posted December 24, 2017 Author Share Posted December 24, 2017 (edited) hace 7 horas, Horinna dijo: HI, thank you. Everything work. But what is with THIS "classic" bug? @Shang Main post updated, try the fix please and tell me if it fully works. Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Horinna 4 Posted December 24, 2017 Share Posted December 24, 2017 (edited) Works. Thank you, @Shang Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal 1 Link to comment Share on other sites More sharing options...
Active Member ReFresh 2338 Posted January 10, 2018 Active Member Share Posted January 10, 2018 GameWindow.Open - exceptions.AttributeError:'SlotWindow' object has no attribute 'RestoreSlotCoolTime' Can someone help me to fix this error? I'll be always helpful! Link to comment Share on other sites More sharing options...
Shang 369 Posted January 13, 2018 Author Share Posted January 13, 2018 En 1/10/2018 a las 18:51, ReFresh dijo: GameWindow.Open - exceptions.AttributeError:'SlotWindow' object has no attribute 'RestoreSlotCoolTime' Can someone help me to fix this error? Read the main post. Link to comment Share on other sites More sharing options...
Active Member ReFresh 2338 Posted January 13, 2018 Active Member Share Posted January 13, 2018 1 hour ago, Shang said: Read the main post. I tried to do it again, but here is the same problem. Problem is maybe in python version I'm using 2.2 I'll be always helpful! Link to comment Share on other sites More sharing options...
Shang 369 Posted January 13, 2018 Author Share Posted January 13, 2018 hace 5 horas, ReFresh dijo: I tried to do it again, but here is the same problem. Problem is maybe in python version I'm using 2.2 En 10/9/2017 a las 16:46, Shang dijo: ### root/ui.py ### Search: def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a): wndMgr.SetSlotCoolTimeColor(self.hWnd, slotIndex, r, g, b, a) ### Add after: def StoreSlotCoolTime(self, key, slotIndex, coolTime, elapsedTime = 0.0): wndMgr.StoreSlotCoolTime(self.hWnd, key, slotIndex, coolTime, elapsedTime) def RestoreSlotCoolTime(self, key): wndMgr.RestoreSlotCoolTime(self.hWnd, key) Link to comment Share on other sites More sharing options...
3bd0 181 Posted January 13, 2018 Share Posted January 13, 2018 I don't have this def in my ui.py def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a): Link to comment Share on other sites More sharing options...
Grimmjow 59 Posted January 13, 2018 Share Posted January 13, 2018 il y a 2 minutes, 3bd0 a dit : I don't have this def in my ui.py def SetSlotCoolTimeColor(self, slotIndex, r, g, b, a): Add after that: def SetSlotCoolTime(self, slotIndex, coolTime, elapsedTime = 0.0): Link to comment Share on other sites More sharing options...
3bd0 181 Posted January 13, 2018 Share Posted January 13, 2018 11 minutes ago, Grimmjow said: Add after that: def SetSlotCoolTime(self, slotIndex, coolTime, elapsedTime = 0.0): that's what I did, but there is no difference ingame, with nth in syserr Link to comment Share on other sites More sharing options...
Aerrow 41 Posted February 4, 2018 Share Posted February 4, 2018 Same here. I think this is not compatible with the highlight slot system. Link to comment Share on other sites More sharing options...
LordZiege 279 Posted February 4, 2018 Share Posted February 4, 2018 (edited) i have this problem: no syserr or something. Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Premium Syreldar 1873 Posted February 5, 2018 Premium Share Posted February 5, 2018 (edited) This whole thing only fixes correctly the second issue, the one brought by Horinna. The first issue doesn't get solved like this as long as it resets the spell interface Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif Edited September 3, 2022 by Metin2 Dev Core X - External 2 Internal 2 1 1 2 "Nothing's free in this life. Ignorant people have an obligation to make up for their ignorance by paying those who help them. Either you got the brains or cash, if you lack both you're useless." Syreldar Link to comment Share on other sites More sharing options...
Shang 369 Posted February 5, 2018 Author Share Posted February 5, 2018 (edited) hace 50 minutos, Syreldar dijo: This whole thing only fixes correctly the second issue, the one brought by Horinna. The first issue doesn't get solved like this as long as it resets the spell interface Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif I'll take a look when I have time. Edited September 3, 2022 by Metin2 Dev Core X - External 2 Internal 1 Link to comment Share on other sites More sharing options...
Recommended Posts