Premium Syreldar 1875 Posted February 6, 2018 Premium Share Posted February 6, 2018 (edited) On 14/1/2018 at 12:36 AM, 3bd0 said: that's what I did, but there is no difference ingame, with nth in syserr On 4/2/2018 at 9:39 PM, LordZiege said: i have this problem: no syserr or something. Search: void CSlotWindow::OnOverOutItem() Inside, search for: m_CoolDownStore.clear(); If you find it, remove it. Now search for: void CSlotWindow::__Initialize() inside, search for: m_dwToolTipSlotNumber = SLOT_NUMBER_NONE; add after: m_CoolDownStore.clear(); Fixed. Edited August 20, 2022 by Metin2 Dev Core X - External 2 Internal 1 3 "Nothing's free in this life. Ignorant people have an obligation to make up for their ignorance by paying those who help them. Either you got the brains or cash, if you lack both you're useless." Syreldar Link to comment Share on other sites More sharing options...
LordZiege 279 Posted February 7, 2018 Share Posted February 7, 2018 (edited) Am 5.2.2018 um 14:38 schrieb Syreldar: This whole thing only fixes correctly the second issue, the one brought by Horinna. The first issue doesn't get solved like this as long as it resets the spell interface Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif This bug in your gif i dont have thats working good. vor 17 Stunden schrieb Syreldar: Search: void CSlotWindow::OnOverOutItem() Inside, search for: m_CoolDownStore.clear(); If you find it, remove it. Now search for: void CSlotWindow::__Initialize() inside, search for: m_dwToolTipSlotNumber = SLOT_NUMBER_NONE; add after: m_CoolDownStore.clear(); Fixed. Thank you, that fixxed mit issue. No System ist working perfect. Edited September 3, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
iPizder 8 Posted March 9, 2018 Share Posted March 9, 2018 (edited) bug: https://metin2.download/picture/ufr8E5cGbYp3K7N7eYnoYLJfP4156269/.gif Edited September 3, 2022 by Metin2 Dev Core X - External 2 Internal 4 1 1 2 Link to comment Share on other sites More sharing options...
Ciffer 13 Posted September 13, 2018 Share Posted September 13, 2018 Useless fix. 1 Link to comment Share on other sites More sharing options...
Swiezu 3 Posted October 31, 2018 Share Posted October 31, 2018 bug; Someone? Link to comment Share on other sites More sharing options...
HITRON 695 Posted March 1, 2020 Share Posted March 1, 2020 (edited) The last one is that: When you have a Toggle enabled and the skill is lower than G1 (M1 example) and you upgrade it to P or S / L the Toggle is not activate again. (This is happening only with command setsk, i think is not possible with other way cause the skill must go to G1 and after will working normally). FIX: Find: if playerm2g2.IsSkillActive(slotIndex) and skillGrade == j: skillPage.ActivateSlot(realSlotIndex) Replace it with: if playerm2g2.IsSkillActive(slotIndex): if skillGrade == j or (skillGrade >= self.SKILL_GRADE_SLOT_COUNT) and j == (self.SKILL_GRADE_SLOT_COUNT - 1): skillPage.ActivateSlot(realSlotIndex) Edited March 1, 2020 by HITRON 1 Link to comment Share on other sites More sharing options...
Shang 369 Posted August 16, 2020 Author Share Posted August 16, 2020 (edited) On 2/5/2018 at 2:38 PM, Syreldar said: Plus, there's a third bug: https://metin2.download/picture/wpkCNRfnTlfpmhkg20WXcu0l54Z4IYQo/.gif This bug is not related to my fix since I didn't touch the uiTaskbar.py. But you can try this to fix the activate animation to be resetted all the time: EterPythonLib/PythonSlotWindow.cpp: On void CSlotWindow::ActivateSlot(DWORD dwIndex) method add this under return: if (pSlot->bActive) return; Spoiler It should look like this: TSlot * pSlot; if (!GetSlotPointer(dwIndex, &pSlot)) return; if (pSlot->bActive) return; And to fix the ActivateSlot to be propagating to the slot you put the icon on the taskbar you can try this fix: On void CSlotWindow::ClearSlot(TSlot * pSlot) method find the ActiveEffect array hiding and just replace it with __DestroySlotEnableEffect(); or however your function is called. Long time but finally here, I bring to you the second version of this fix. I think I fixed every bug I saw on this post. New download link: This is the hidden content, please Sign In or Sign Up If missed something or just new bugs are found write on the post. Please do not create new threads trying to get help from something related to this post, just write here. I modified every file you find on the .zip so if you already installed the first version check everything again. PS: If any Moderator sees this, update the first post please. Edited September 4, 2022 by Metin2 Dev Core X - External 2 Internal 28 8 4 Link to comment Share on other sites More sharing options...
Finnael 481 Posted August 16, 2020 Share Posted August 16, 2020 (edited) I don't know how but we should be able to fix these bugs without touching the C++ code. Character window system I am working on doesn't have these bugs even though I didn't apply the fixes here. I am just updating the skill slots differently in python than the default character window and I think that fixes the bugs somehow. Okay, this should be enough to fix the bugs shown in the topic (hopefully) uicharacter.py Find: for j in xrange(skill.SKILL_GRADE_COUNT): skillPage.ClearSlot(self.__GetRealSkillSlot(j, i)) Replace with: for j in xrange(skill.SKILL_GRADE_COUNT): if j != player.GetSkillGrade(slotIndex): skillPage.ClearSlot(self.__GetRealSkillSlot(j, i)) Edited August 16, 2020 by VegaS™ merge replies + warning (spamming) Link to comment Share on other sites More sharing options...
Shang 369 Posted August 17, 2020 Author Share Posted August 17, 2020 (edited) On 8/16/2020 at 6:05 PM, Finnael said: Okay, this should be enough to fix the bugs shown in the topic (hopefully) uicharacter.py Find: for j in xrange(skill.SKILL_GRADE_COUNT): skillPage.ClearSlot(self.__GetRealSkillSlot(j, i)) Replace with: for j in xrange(skill.SKILL_GRADE_COUNT): if j != player.GetSkillGrade(slotIndex): skillPage.ClearSlot(self.__GetRealSkillSlot(j, i)) It isn't. You should be able to do this: https://metin2.download/picture/zIcK4V7AzNZ23ms52n9jEHxwK4i11BHX/.gif That's what this fix offers. Edited September 4, 2022 by Metin2 Dev Core X - External 2 Internal 3 1 3 Link to comment Share on other sites More sharing options...
Premium Syreldar 1875 Posted August 17, 2020 Premium Share Posted August 17, 2020 (edited) 2 hours ago, Shang said: It isn't. You should be able to do this: https://metin2.download/picture/Qnb77z7d6E8OLwQru4I3201eaK89kiK8/.gif That's what this fix offers. Oh you quoted me on a 2 year old post haha Edited September 4, 2022 by Metin2 Dev Core X - External 2 Internal "Nothing's free in this life. Ignorant people have an obligation to make up for their ignorance by paying those who help them. Either you got the brains or cash, if you lack both you're useless." Syreldar Link to comment Share on other sites More sharing options...
Finnael 481 Posted August 17, 2020 Share Posted August 17, 2020 (edited) 2 hours ago, Shang said: It isn't. You should be able to do this: https://metin2.download/picture/Qnb77z7d6E8OLwQru4I3201eaK89kiK8/.gif That's what this fix offers. Yeaah, still you can do it all in python I believe. Not saying you should. 6 minutes ago, Syreldar said: Oh you quoted me on a 2 year old post haha No, he wrote that for me. Edited September 4, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Honorable Member Tatsumaru 5260 Posted August 29, 2021 Honorable Member Share Posted August 29, 2021 (edited) On 8/16/2020 at 1:22 PM, Shang said: This bug is not related to my fix since I didn't touch the uiTaskbar.py. But you can try this to fix the activate animation to be resetted all the time: EterPythonLib/PythonSlotWindow.cpp: On void CSlotWindow::ActivateSlot(DWORD dwIndex) method add this under return: if (pSlot->bActive) return; Hide contents It should look like this: TSlot * pSlot; if (!GetSlotPointer(dwIndex, &pSlot)) return; if (pSlot->bActive) return; And to fix the ActivateSlot to be propagating to the slot you put the icon on the taskbar you can try this fix: On void CSlotWindow::ClearSlot(TSlot * pSlot) method find the ActiveEffect array hiding and just replace it with __DestroySlotEnableEffect(); or however your function is called. Long time but finally here, I bring to you the second version of this fix. I think I fixed every bug I saw on this post. New download link: This is the hidden content, please Sign In or Sign Up If missed something or just new bugs are found write on the post. Please do not create new threads trying to get help from something related to this post, just write here. I modified every file you find on the .zip so if you already installed the first version check everything again. PS: If any Moderator sees this, update the first post please. After adding v2 version Edited August 18, 2022 by Metin2 Dev Core X - External 2 Internal 1 Link to comment Share on other sites More sharing options...
Premium Hunger 472 Posted August 29, 2021 Premium Share Posted August 29, 2021 That page has lots of bugs. Try activate the enchanted blade for sura and then switch to horse page then back. The activate effect goes off. A complete re-write would be a fix. Link to comment Share on other sites More sharing options...
Shang 369 Posted August 29, 2021 Author Share Posted August 29, 2021 (edited) 5 hours ago, Tatsumaru said: After adding v2 version #include "../UserInterface/PythonSkill.h" In EterPythonLib/PythonSlotWindow.cpp 15 minutes ago, Hunger said: That page has lots of bugs. Try activate the enchanted blade for sura and then switch to horse page then back. The activate effect goes off. A complete re-write would be a fix. Indeed. Edited August 18, 2022 by Metin2 Dev Core X - External 2 Internal 1 Link to comment Share on other sites More sharing options...
MEKA 9 Posted December 15, 2021 Share Posted December 15, 2021 (edited) visual bug i just have this problem Edited September 4, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Tuckii 10 Posted September 5, 2022 Share Posted September 5, 2022 (edited) ../ Edited September 8, 2022 by Tuckii Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Tuckii 10 Posted September 8, 2022 Share Posted September 8, 2022 (edited) After having the same issue as tatsumaru, I've applied the fix that helped him but im encountering further more problems after adding v2 fix, anyone had similiar issue? Edited September 11, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
asdfgh12 0 Posted March 5, 2023 Share Posted March 5, 2023 0304 22:45:29169 :: Traceback (most recent call last): 0304 22:45:29169 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:29169 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:29169 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:29169 :: AttributeError 0304 22:45:29169 :: : 0304 22:45:29169 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:29169 :: 0304 22:45:33294 :: Traceback (most recent call last): 0304 22:45:33294 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:33294 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:33294 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:33294 :: AttributeError 0304 22:45:33294 :: : 0304 22:45:33294 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:33294 :: 0304 22:45:35587 :: Traceback (most recent call last): 0304 22:45:35587 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:35587 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:35587 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:35587 :: AttributeError 0304 22:45:35587 :: : 0304 22:45:35587 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:35587 :: Link to comment Share on other sites More sharing options...
Shang 369 Posted March 5, 2023 Author Share Posted March 5, 2023 7 hours ago, asdfgh12 said: 0304 22:45:29169 :: Traceback (most recent call last): 0304 22:45:29169 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:29169 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:29169 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:29169 :: AttributeError 0304 22:45:29169 :: : 0304 22:45:29169 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:29169 :: 0304 22:45:33294 :: Traceback (most recent call last): 0304 22:45:33294 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:33294 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:33294 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:33294 :: AttributeError 0304 22:45:33294 :: : 0304 22:45:33294 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:33294 :: 0304 22:45:35587 :: Traceback (most recent call last): 0304 22:45:35587 :: File "game.py", line 930, in RunUseSkillEvent 0304 22:45:35587 :: File "interfacemodule.py", line 1069, in OnUseSkill 0304 22:45:35587 :: File "uicharacter.py", line 1611, in OnUseSkill 0304 22:45:35587 :: AttributeError 0304 22:45:35587 :: : 0304 22:45:35587 :: 'SlotWindow' object has no attribute 'StoreSlotCoolTime' 0304 22:45:35587 :: Read again the first post and u will find the solution. Link to comment Share on other sites More sharing options...
Premium DemOnJR 564 Posted June 30, 2023 Premium Share Posted June 30, 2023 On 9/8/2022 at 11:48 AM, Tuckii said: After having the same issue as tatsumaru, I've applied the fix that helped him but im encountering further more problems after adding v2 fix, anyone had similiar issue? same. Link to comment Share on other sites More sharing options...
[TiTAN] 32 Posted July 9, 2023 Share Posted July 9, 2023 On 6/30/2023 at 5:25 AM, DemOnJR said: same. just add #include "GameType.h" in ItemData.h 1 1 Link to comment Share on other sites More sharing options...
Premium DemOnJR 564 Posted July 10, 2023 Premium Share Posted July 10, 2023 On 7/9/2023 at 7:17 PM, [TiTAN] said: just add #include "GameType.h" in ItemData.h Thanks. Link to comment Share on other sites More sharing options...
Active Member Mind Rapist 188 Posted November 28, 2023 Active Member Share Posted November 28, 2023 I have been struggling with all the bugs after trying everything in this post. I have been searching for answers several days now so if anyone can help me and any other person trying to fix those bugs we would be very grateful to you. Here is my code: PythonSlotWindow.cpp: https://pastebin.com/vZEueRRt PythonSlotWindow.h: https://pastebin.com/B0viTpCD PythonWindowManagerModule.cpp: https://pastebin.com/PEa1Aqsa ui.py: https://pastebin.com/ueSW9N4h uiCharacter.py: https://pastebin.com/KtkYu1zw Link to comment Share on other sites More sharing options...
Shang 369 Posted November 28, 2023 Author Share Posted November 28, 2023 3 hours ago, Mind Rapist said: I have been struggling with all the bugs after trying everything in this post. I have been searching for answers several days now so if anyone can help me and any other person trying to fix those bugs we would be very grateful to you. Here is my code: PythonSlotWindow.cpp: https://pastebin.com/vZEueRRt PythonSlotWindow.h: https://pastebin.com/B0viTpCD PythonWindowManagerModule.cpp: https://pastebin.com/PEa1Aqsa ui.py: https://pastebin.com/ueSW9N4h uiCharacter.py: https://pastebin.com/KtkYu1zw What bugs are you experiencing? Link to comment Share on other sites More sharing options...
Active Member Mind Rapist 188 Posted November 28, 2023 Active Member Share Posted November 28, 2023 2 hours ago, Shang said: What bugs are you experiencing? Thanks for the response. I was able to fix everything by making a clean reinstallation of the code (apparently I left something behind the 1st time) so the only thing I couldn't fix was this: On 12/16/2021 at 1:29 AM, MEKA said: visual bug i just have this problem and the one in the taskbar that changing position of the active skill adds the effect to the second slot Link to comment Share on other sites More sharing options...
Recommended Posts