fix Small optimization for getting the height

[Distraught 9985]

Hi everyone,

During some profiling today, I noticed that a significant amount of time in the Update process is being used to determine the z position of characters.

This is primarily because we currently have to iterate through all the collisions to verify their height.

 

By default, there’s another method available that utilizes caching, so we don’t have to repeatedly perform these calculations. Unfortunately, this method wasn’t used.

We’ll be updating our code to take advantage of the cached version.

 

First, go to MapManager.h in GameLib.

Find

float					GetHeight(float fx, float fy);

and add after:

float					GetCacheHeight(float fx, float fy);

 

Now, go to MapManager.cpp and add the following code somewhere:

float CMapManager::GetCacheHeight(float fx, float fy)
{
	if (!m_pkMap)
		return 0.0f;
  
	CMapOutdoor& rkMap = GetMapOutdoorRef();
	return rkMap.GetCacheHeight(fx, fy);
}

 

Now go to InstanceBase.cpp in UserInterface and find the CInstanceBase::__GetBackgroundHeight function.

Modify it:

float CInstanceBase::__GetBackgroundHeight(float x, float y)
{
	CPythonBackground& rkBG=CPythonBackground::Instance();
	return rkBG.GetCacheHeight(x, y);
}

That's all, we're done.

 

Here is how our flame graph looks like now:

 

I hope, it helped!

Edited October 22, 2024 by Metin2 Dev International
Core X - External 2 Internal

[Denizeri24 43]

thats will create 'stutter' problem for higher fps.

[Distraught 9985]

42 minutes ago, Denizeri24 said:

thats will create 'stutter' problem for higher fps.

What do you mean by that?

We're using this for days, and nobody noticed any problem. Literally it's just caching the values that has already been calculated.

[Denizeri24 43]

6 minutes ago, Distraught said:

What do you mean by that?

We're using this for days, and nobody noticed any problem. Literally it's just caching the values that has already been calculated.

no. cache vector is small so its caching precision is not good.

 

if you play like 240 fps, height updates will stutter. its look like warping..

[CONTROL 917]

it's not a bottleneck 

[cris690 1]

In 5.8 I get several errors like incorrect mouse and jerks when climbing mountains