official Official Mailbox

[HFWhite 450]

10 minutes ago, Marcos17 said:

I implemented the System, and the only problem is that due to the mailbox item it doesn't open at all, due to the NPC it is working perfectly.

Note: There is no error in any of the syssers, neither in Release or Debug

you have a quest there for NPC.

 

I, for example, I made the window open with click on icon from minimap.

[Ballads 18]

2 hours ago, SCOOB said:

you have a quest there for NPC.

 

I, for example, I made the window open with click on icon from minimap.

I have almost the same problem here, Mailbox window open with item, but not with npc.. the most crazy thing here is that i only have the NPC quest installed xD

[Marcos17 17]

2 hours ago, SCOOB said:

you have a quest there for NPC.

 

I, for example, I made the window open with click on icon from minimap.

Solved, it was a problem with item_proto

[BadRomani 14]

Rar password?

[m2Ciaran 283]

20 hours ago, BadRomani said:

Rar password?

[b6d4a82c15 84]

Works fine, thank you Mali. I had to make some modifications but overall its very polished and I'd recommend it for OX rewards

Edited December 14, 2023 by b6d4a82c15

[Jimmermania 24]

Hi @ Mali, how i can send via mailbox a "gift" for every player?

[nora 0]

Spoiler

On 9/14/2023 at 3:19 PM, HFWhite said:

FIXED!

 

I've added a separate check for bIsGMPost

    if (p.Message.bIsGMPost == true) {
        p.Message.DeleteTime = p.Message.SendTime + EMAILBOX::MAILBOX_REMAIN_DAY_GM * 60 * 60 * 24;
    } else {
        p.Message.DeleteTime = p.Message.SendTime + EMAILBOX::MAILBOX_REMAIN_DAY * 60 * 60 * 24;
    }

and a check for if owner is GM

    if (Owner->IsGM())
    {
        p.Message.bIsGMPost = true;
    }

this fixed my issue  

GIF: 

 

 

I tried the below in my case works fine. Same result, just need to change the order of checking.

1. On MailBox.cpp, find the << void CMailBox::ServerProcess(const BYTE SubHeader, const BYTE arg1, const BYTE arg2) const >> ,

1.1 Search the below:

Spoiler

p.Message.bIsGMPost = Owner->IsGM();

2. Move the previous line of code, above of:

Spoiler

p.Message.DeleteTime = p.Message.SendTime + (p.Message.bIsGMPost ? EMAILBOX::MAILBOX_REMAIN_DAY_GM : EMAILBOX::MAILBOX_REMAIN_DAY) * 60 * 60 * 24;

Should look like this:

Spoiler

    p.Message.SendTime = time(nullptr);

    p.Message.bIsGMPost = Owner->IsGM();

    p.Message.DeleteTime = p.Message.SendTime + (p.Message.bIsGMPost ? EMAILBOX::MAILBOX_REMAIN_DAY_GM : EMAILBOX::MAILBOX_REMAIN_DAY) * 60 * 60 * 24;

    std::memcpy(p.Message.szTitle, szTitle, sizeof(p.Message.szTitle));

    p.Message.bIsConfirm = false;

 

Edited April 10 by nora