Hide weapon while emotion is acting

[WeedHex 661]

Hello, i need your help for a thing already asked in metin2dev but i couldn't use it.

 

Someone have a way to: Hide weapon while emotion is acting?  

More better if you can do it from binary only.

[WeedHex 661]

UPP

[Raylee 725]

On 10/10/2018 at 6:11 PM, WeedHex said:

Hello, i need your help for a thing already asked in metin2dev but i couldn't use it.

 

Someone have a way to: Hide weapon while emotion is acting?  

More better if you can do it from binary only.

Do you tried this way?

Best regards
Raylee

[WeedHex 661]

5 hours ago, Raylee said:

Do you tried this way?

Best regards
Raylee

Yes, i was speaking about it, i can't install it bcs is unsafe...

Bad way to do it.

I Want to do only from binary, it's should be easy!

[Casawir 19]

yes i did, but im not proud of my solution, and its not that   short,  u need to think about many cases what triggers and what can stop emotion

 

ill post it later but its not quality code

[xP3NG3Rx 24872]

	AttackProcess();
	MovementProcess();

	m_GraphicThingInstance.MotionProcess(IsPC());
	// Hide weapon: GetCurrentMotionIndex public version of the __GetCurrentMotionIndex in gamelib\\ActorInstance.h
	if (m_GraphicThingInstance.GetCurrentMotionIndex() < CRaceMotionData::NAME_CLAP || m_GraphicThingInstance.GetCurrentMotionIndex() == CRaceMotionData::NAME_DIG)
	{
		if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON) != m_adwPart[CRaceData::PART_WEAPON])
		{
			m_GraphicThingInstance.AttachWeapon(m_adwPart[CRaceData::PART_WEAPON]);
			CItemData* pItemData;
			if (CItemManager::Instance().GetItemDataPointer(m_adwPart[CRaceData::PART_WEAPON], &pItemData))
				__GetRefinedEffect(pItemData);
		}
	}
	else if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON))
	{
		m_GraphicThingInstance.AttachWeapon(0);
		__ClearWeaponRefineEffect();
	}
	// EOF Hide weapon

	if (IsMountingHorse())
	{
		m_kHorse.m_pkActor->HORSE_MotionProcess(FALSE);
	}

Give a try with this, just put in the CInstanceBase::Update make it fit over there, and don't forget to make a public function for the GetCurrentMotionIndex.

[M.Sorin 342]

On 10/28/2018 at 9:05 PM, xP3NG3Rx said:

	AttackProcess();
	MovementProcess();

	m_GraphicThingInstance.MotionProcess(IsPC());
	// Hide weapon: GetCurrentMotionIndex public version of the __GetCurrentMotionIndex in gamelib\\ActorInstance.h
	if (m_GraphicThingInstance.GetCurrentMotionIndex() < CRaceMotionData::NAME_CLAP || m_GraphicThingInstance.GetCurrentMotionIndex() == CRaceMotionData::NAME_DIG)
	{
		if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON) != m_adwPart[CRaceData::PART_WEAPON])
		{
			m_GraphicThingInstance.AttachWeapon(m_adwPart[CRaceData::PART_WEAPON]);
			CItemData* pItemData;
			if (CItemManager::Instance().GetItemDataPointer(m_adwPart[CRaceData::PART_WEAPON], &pItemData))
				__GetRefinedEffect(pItemData);
		}
	}
	else if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON))
	{
		m_GraphicThingInstance.AttachWeapon(0);
		__ClearWeaponRefineEffect();
	}
	// EOF Hide weapon

	if (IsMountingHorse())
	{
		m_kHorse.m_pkActor->HORSE_MotionProcess(FALSE);
	}

Give a try with this, just put in the CInstanceBase::Update make it fit over there, and don't forget to make a public function for the GetCurrentMotionIndex.

You have one error in this code.  This part:

if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON) != m_adwPart[CRaceData::PART_WEAPON])

 

[xP3NG3Rx 24872]

What do you mean?

[M.Sorin 342]

43 minutes ago, xP3NG3Rx said:

What do you mean?

https://metin2.download/picture/7V01Op768kDUmMTvl3xJ5n98wI1r7lTU/.png

https://metin2.download/picture/Kt5vzdtI9wEklie1NkMA6fWVkMR179uT/.png

Or they are from my shite visual studio xD

Edited September 3, 2022 by Metin2 Dev
Core X - External 2 Internal

[xP3NG3Rx 24872]

I changed the type of the array, and his name also from m_awPart to m_adwPart, I thought this isn't a big deal.

 

[ReFresh 3161]

@xP3NG3Rx and don't forget to make a public function for the GetCurrentMotionIndex. How to do it?

[Exonow 0]

up

[xP3NG3Rx 24872]

What "up"?

Is that really difficult to make a function to public from private? Hm.

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[TAUMP 1179]

22 minutes ago, xP3NG3Rx said:

What "up"?

Is that really difficult to make a function to public from private? Hm.

Now they want 100% part of code on screen haha

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[sxvoyz 64]

Dnia 7.11.2018 o 19:22, ReFresh napisał:

@xP3NG3Rx and don't forget to make a public function for the GetCurrentMotionIndex. How to do it?

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[ReFresh 3161]

@xP3NG3Rx Your solution for hide weapon caused a little visual bug. You can see this bug when you buff yourself or another player. Skills are casted more faster than animation.

 

[Gkovacs32 4]

On 11/7/2018 at 7:22 PM, ReFresh said:

@xP3NG3Rx és ne felejtse el nyilvános funkciót létrehozni a GetCurrentMotionIndex számára. Hogyan kell csinálni?

Locale_inc.h

add

#define ENABLE_EMOTION_HIDE_WEAPON

InstanceBase.cpp

Search:
    

m_GraphicThingInstance.MotionProcess(IsPC());

Add after:

 

#ifdef ENABLE_EMOTION_HIDE_WEAPON
	if (m_GraphicThingInstance.GetCurrentMotionIndex() < CRaceMotionData::NAME_CLAP || m_GraphicThingInstance.GetCurrentMotionIndex() > CRaceMotionData::NAME_JOY || m_GraphicThingInstance.GetCurrentMotionIndex() == CRaceMotionData::NAME_DIG)
	{
		if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON) != m_awPart[CRaceData::PART_WEAPON])
		{
			m_GraphicThingInstance.AttachWeapon(m_awPart[CRaceData::PART_WEAPON]);
			CItemData* pItemData;
			if (CItemManager::Instance().GetItemDataPointer(m_awPart[CRaceData::PART_WEAPON], &pItemData))
			{
				__GetRefinedEffect(pItemData);
			}
		}
	}
	else if (m_GraphicThingInstance.GetPartItemID(CRaceData::PART_WEAPON))
	{
		m_GraphicThingInstance.AttachWeapon(0);
		__ClearWeaponRefineEffect();
	}
#endif

ActorInstanceMotion.cpp

Add end of file

#ifdef ENABLE_EMOTION_HIDE_WEAPON
WORD CActorInstance::GetCurrentMotionIndex()
{
	return __GetCurrentMotionIndex();
}
#endif

Actorinstance.h

Search

        std::deque<CFlyTarget> m_kQue_kFlyTarget;

Add after:
 

#ifdef ENABLE_EMOTION_HIDE_WEAPON
	public:
		WORD GetCurrentMotionIndex();
#endif

build client source, done.
 

 

 

Edited September 13, 2024 by Gkovacs32