[Bug on all servers] How to fix this?

[Woops 10]

    if (!IsEmptyItemGrid(DestCell, item->GetSize(), -1))
    {
        return false;
    }

[Yanni 0]

Even if we block the overlap, the attribute change, finishes won t work, but the stones work fine on weapons/armours.

[Khabib Nurmagomedov 388]

2 hours ago, CONTROL said:

1- you're typing in english because it's the only language you know , im typing in english because it's the only language you know  , we're not the same .. english teacher

2- [Untested btw i wrote it like in 5 min]

3- get a life

you were right the IsEmptyItemGrid really did came through after all 

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

Please speak for yourself lil bro

Anyone that has proof of purchase for the sanii switchbot can just DM me for the simple fix with the switchbot.

Edited July 29, 2024 by Metin2 Dev International
Core X - External 2 Internal

[TAUMP 1178]

9 minutes ago, Yanni said:

Even if we block the overlap, the attribute change, finishes won t work, but the stones work fine on weapons/armours.

again and better you are after lobotomy?

Edited July 25, 2024 by TAUMP

[Yanni 0]

42 minutes ago, TAUMP said:

again and better you are after lobotomy?

Next time ask Marty if you don t understand english.

[CONTROL 921]

47 minutes ago, FrenchForeignLegion said:

Please speak for yourself lil bro

Anyone that has proof of purchase for the sanii switchbot can just DM me for the simple fix with the switchbot.

I haven't even talk about the client part what so ever why tf are u even mentioning me for ? Lmao

Edited July 29, 2024 by Metin2 Dev International
Core X - External 2 Internal

[saudidos 14]

13 hours ago, Woops said:

    if (!IsEmptyItemGrid(DestCell, item->GetSize(), -1))
    {
        return false;
    }

 

 

 

 

in char_item.cpp in this faction : bool CHARACTER::MoveItem you need to add under this if (!IsValidItemPosition(DestCell)) this code :

 

    if (!IsEmptyItemGrid(DestCell, item->GetSize(), -1))
    {
        ChatPacket(CHAT_TYPE_INFO, LC_TEXT("Target slot is occupied!"));
        return false;
    }

thanks man

Edited July 29, 2024 by Metin2 Dev International
Core X - External 2 Internal

[Khabib Nurmagomedov 388]

Or you can do it this way as well
 

if (!IsEmptyItemGrid(DestCell, item->GetSize(), item)) {
    return false;
}

@ Intel has a great explaination on the white-looking thing when it comes to dragon alchemy inventory. His code preview of what hes done is NOT meant to be copy and pasted and you need to understand what you're doing, as i've attached a GIF a little bit upper you can see that it can be fixed as well as its just a matter of flags.

[apocalypse 0]

4 minutes ago, FrenchForeignLegion said:

Or you can do it this way as well
 

if (!IsEmptyItemGrid(DestCell, item->GetSize(), item)) {
    return false;
}

@ Intel has a great explaination on the white-looking thing when it comes to dragon alchemy inventory. His code preview of what hes done is NOT meant to be copy and pasted and you need to understand what you're doing, as i've attached a GIF a little bit upper you can see that it can be fixed as well as its just a matter of flags.

Ok thanks again but why not add this code since yesterday to close this case ?

 

and you asking to go to developer to fix this issue !! 

[Khabib Nurmagomedov 388]

1 minute ago, apocalypse said:

Ok thanks again but why not add this code since yesterday to close this case ?

 

and you asking to go to developer to fix this issue !! 

What? What do you even mean by that. I did NOT ask anyone in order to fix this issue, the only person that gave me a slight insight was Intel and i was not spoonfed at all because i can do stuff myself.

[Intel 913]

21 minutes ago, apocalypse said:

Ok thanks again but why not add this code since yesterday to close this case ?

 

and you asking to go to developer to fix this issue !! 

Because that is a custom fix actually ahah

I only need that "fix" on my files, which is actually the check that usually exists on original files:

 

Regarding the client side fix, I've basically posted it on the first page (in short, check if missing the slot type check in OverInItem, SelectEmptySlot and SelecItemtSlot (In my client I couldn't even move the items manually from the switchbot initially ahah))

Edited July 26, 2024 by Intel

[saudidos 14]

2 hours ago, Intel said:

Because that is a custom fix actually ahah

I only need that "fix" on my files, which is actually the check that usually exists on original files:

 

Regarding the client side fix, I've basically posted it on the first page (in short, check if missing the slot type check in OverInItem, SelectEmptySlot and SelecItemtSlot (In my client I couldn't even move the items manually from the switchbot initially ahah))

helle bro ,, i test this one it's working fine 

 

3 hours ago, saudidos said:

 

 

 

 

in char_item.cpp in this faction : bool CHARACTER::MoveItem you need to add under this if (!IsValidItemPosition(DestCell)) this code :

 

    if (!IsEmptyItemGrid(DestCell, item->GetSize(), -1))
    {
        ChatPacket(CHAT_TYPE_INFO, LC_TEXT("Target slot is occupied!"));
        return false;
    }

thanks man

 

Edited July 29, 2024 by Metin2 Dev International
Core X - External 2 Internal

[Syreldar 2737]

On 7/25/2024 at 5:26 PM, CONTROL said:

1- you're typing in english because it's the only language you know , im typing in english because it's the only language you know  , we're not the same .. english teacher

2- [Untested btw i wrote it like in 5 min]

3- get a life

you were right the IsEmptyItemGrid really did came through after all 

Is this what people mean by "having no shame at all"?

[Filachilla 66]

Well I have 2 structured files and I dont have any problem.. First server is T4MP high changed (have same switchbot and without any visual or psyhical bug) and secondary is original last marty (buyed) and too without any problem.. I test switchbot, shop, offline shop, sash, trans, etc.. Without any visual or psyhic bug. So maybe just your system are dumb added..

 

Sorry I cant edit my last post, but okay problem is also here.  I have edited moveItem in my source and its without problem, but when I tried base source, problem is in.

[rawn3cr0 1]

I have this but i don't have this bug..

		if (!IsEmptyItemGrid(DestCell, item->GetSize(), Cell.cell))
			return false;

Maybe because of:

	if (Cell.IsSamePosition(DestCell)) // @fixme196 (check same slot n same window aliases) (05.24/Adapted for overlapping objects: special inventory - inventory and move item if have same slotid SI=I)
		return false;

Edited July 30, 2024 by Metin2 Dev International
Core X - External 2 Internal

[Jira 740]

just change 

		if (!IsEmptyItemGrid(DestCell, item->GetSize(), Cell.cell))

with

		if (!IsEmptyItemGrid(DestCell, item->GetSize(), Cell.window_type == DestCell.window_type ? Cell.cell : -1))

 

[pellino5 0]

On 7/25/2024 at 8:46 AM, TAUMP said:

Lol, you have more information from him than me.  

HF white stupid poor idiot who owns the Romanian discord community, where he strongly supports resellers of purchased systems and resells it there for discord invites, I hope you get banned soon. 

And yet you're still on his community and use the resources from there:

Edited April 17, 2025 by Geoffrey 🧊
Imgur removed