[Collector's topic] Remove Unussed code

[SamuraiHUN 1493]

@Update001: teen_packet added.

@Update002: check_server (libserverkey) added.

[xaoxo 0]

nice work 

[CsanMag 0]

6 hours ago, SamuraiHUN said:

@Update001: teen_packet added.

@Update002: check_server (libserverkey) added.

If I remove all these features will the server be faster or why we need to remove them?

I get they are not used but that's it? It's just about thinning the code?

[Kafa 148]

On 11/14/2021 at 4:39 PM, CsanMag said:

If I remove all these features will the server be faster or why we need to remove them?

I get they are not used but that's it? It's just about thinning the code?

I don't recommend you using this tutorial if you don't understand what you do, the code's are just there, just keep them.   (Just my opinion, dont change what you dont understand)

[r00t3r 67]

Updates ?

[enisina 156]

Thank you

Edited January 6, 2022 by enisina

[Metin2 Dev 4701]

for matrix in db.cpp i have this error if i modify like this

void DBManager::LoginPrepare(long lRemainSecs, LPDESC d, DWORD * pdwClientKey, int * paiPremiumTimes)
{
	const TAccountTable & r = d->GetAccountTable();

	CLoginData * pkLD = M2_NEW CLoginData;

	pkLD->SetKey(d->GetLoginKey());
	pkLD->SetLogin(r.login);
	pkLD->SetRemainSecs(lRemainSecs);
	pkLD->SetIP(d->GetHostName());
	pkLD->SetClientKey(pdwClientKey);

	if (paiPremiumTimes)
		pkLD->SetPremium(paiPremiumTimes);

	InsertLoginData(pkLD);
	SendAuthLogin(d);
}

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[ragem0re 154]

4 hours ago, Cryptex said:

for matrix in db.cpp i have this error if i modify like this

void DBManager::LoginPrepare(long lRemainSecs, LPDESC d, DWORD * pdwClientKey, int * paiPremiumTimes)
{
	const TAccountTable & r = d->GetAccountTable();

	CLoginData * pkLD = M2_NEW CLoginData;

	pkLD->SetKey(d->GetLoginKey());
	pkLD->SetLogin(r.login);
	pkLD->SetRemainSecs(lRemainSecs);
	pkLD->SetIP(d->GetHostName());
	pkLD->SetClientKey(pdwClientKey);

	if (paiPremiumTimes)
		pkLD->SetPremium(paiPremiumTimes);

	InsertLoginData(pkLD);
	SendAuthLogin(d);
}

compare the arguments of DBManager::LoginPrepare in db.cpp & db.h.

the output says they are different.

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[Metin2 Dev 4701]

6 minutes ago, ragem0re said:

compare the arguments of DBManager::LoginPrepare in db.cpp & db.h.

the output says they are different.

I already fix it

[SamuraiHUN 1493]

today, (maybe 6pm) update with removed gf hs.

[r00t3r 67]

On 6/6/2022 at 4:20 PM, SamuraiHUN said:

today, (maybe 6pm) update with removed gf hs.

Welcome back  

[SamuraiHUN 1493]

sorry for late, i have lot of work, and don't have time, but some day and i update the topic.

[LIME1X 2]

Thank you

but add 

input_login.cpp

 

Search and delete

    if (g_TeenDesc) // BufferedPacket 사용 금지
    {
        TPacketGTLogin p;

        p.header = HEADER_GT_LOGIN;
        p.empty = 0;
        p.id = d->GetAccountTable().id;

        g_TeenDesc->Packet(&p, sizeof(p));
        sys_log(0, "TEEN_SEND: (%u, %s)", d->GetAccountTable().id, ch->GetName());
    }