[Py] Taskbar Skill Slot 'Hover' Problem

[blaxis 263]

Hello there.
As you can see in the GIF, when I hover over the skills, the "over" effect appears but immediately disappears. How can I solve this?

No syserr.
Debug: No syserr.

 

[Hysteria 8]

this just in skill icon or on any button ?

[blaxis 263]

11 hours ago, Hysteria said:

this just in skill icon or on any button ?

It only happens on the skill icon. In slots 1-2-3-4 and F1 F2 F3 F4.

Edited August 28, 2021 by blaxis

[Hysteria 8]

ah its normal that happen in every server file 

[blaxis 263]

11 hours ago, Hysteria said:

ah its normal that happen in every server file 

Does everyone have it? o.O

[Hysteria 8]

2 hours ago, blaxis said:

Does everyone have it? o.O

yeah everyone 

[VegaS™ 10049]

The bug is caused by self.RefreshQuickSlot() which is called in OnUpdate() at each 0.5 seconds.

It also affects the emotion slots, not just the skills.

Inside of RefreshQuickSlot is the following snippet:

	elif player.SLOT_TYPE_SKILL == Type:
		[...]
		slot.SetCoverButton(slotNumber)

	elif player.SLOT_TYPE_EMOTION == Type:
		[...]
		slot.SetCoverButton(slotNumber)

That part of the code resets the cover button for each slot and resets the up/over/down states.

How-To-Fix:

• root/uiTaskBar.py

# Search for: (x2 times)
					slot.SetCoverButton(slotNumber)
# Replace it with:
					if not slot.HasCoverButton(slotNumber):
						slot.SetCoverButton(slotNumber)

• root/ui.py

# Search for:
	def EnableCoverButton(self, slotIndex):
		wndMgr.EnableCoverButton(self.hWnd, slotIndex)
# Add after:
	def HasCoverButton(self, slot_index):
		return wndMgr.HasCoverButton(self.hWnd, slot_index)

• Src/Client/EterPythonLib/PythonSlotWindow.h

// Search for:
			void HideSlotBaseImage(DWORD dwIndex);
// Add after:
			bool HasCoverButton(const DWORD slot_index)
			{
				TSlot * slot;
				if (!GetSlotPointer(slot_index, &slot))
					return false;

				return slot->pCoverButton != nullptr;
			}

• Src/Client/EterPythonLib/PythonWindowManagerModule.cpp

// Search for:
PyObject * wndMgrHideSlotBaseImage(PyObject * poSelf, PyObject * poArgs)
{
	[...]
}
// Add after:
PyObject* wndMgrHasCoverButton(PyObject*, PyObject* poArgs)
{
	UI::CWindow* window;
	PyTuple_GetWindow(poArgs, 0, &window);

	int slot_index;
	PyTuple_GetInteger(poArgs, 1, &slot_index);

	auto* const slot = dynamic_cast<UI::CSlotWindow*>(window);
	return Py_BuildValue("b", slot->HasCoverButton(slot_index));
}

// Search for:
		{ "HideSlotBaseImage",			wndMgrHideSlotBaseImage,			METH_VARARGS },
// Add after:
		{ "HasCoverButton",			wndMgrHasCoverButton,				METH_VARARGS },

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[blaxis 263]

2 hours ago, VegaS™ said:

The bug is caused by self.RefreshQuickSlot() which is called in OnUpdate() at each 0.5 seconds.

It also affects the emotion slots, not just the skills.

Inside of RefreshQuickSlot is the following snippet:

	elif player.SLOT_TYPE_SKILL == Type:
		[...]
		slot.SetCoverButton(slotNumber)

	elif player.SLOT_TYPE_EMOTION == Type:
		[...]
		slot.SetCoverButton(slotNumber)

That part of the code resets the cover button for each slot and resets the up/over/down states.

How-To-Fix:

• root/uiTaskBar.py

# Search for: (x2 times)
					slot.SetCoverButton(slotNumber)
# Replace it with:
					if not slot.HasCoverButton(slotNumber):
						slot.SetCoverButton(slotNumber)

• Src/Client/EterPythonLib/PythonWindow.h

// Search for:
			BOOL IsDisableCoverButton(DWORD dwIndex);
// Add after:
			bool HasCoverButton(const DWORD slot_index)
			{
				TSlot * slot;
				if (!GetSlotPointer(slot_index, &slot))
					return false;

				return slot->pCoverButton != nullptr;
			}

• Src/Client/EterPythonLib/PythonWindowManagerModule.cpp

// Search for:
PyObject * wndMgrIsDisableCoverButton(PyObject * poSelf, PyObject * poArgs)
{
	[...]
}
// Add after:
PyObject* wndMgrHasCoverButton(PyObject*, PyObject* poArgs)
{
	UI::CWindow* window;
	PyTuple_GetWindow(poArgs, 0, &window);

	int slot_index;
	PyTuple_GetInteger(poArgs, 1, &slot_index);

	auto* const slot = dynamic_cast<UI::CSlotWindow*>(window);
	return Py_BuildValue("b", slot->HasCoverButton(slot_index));
}

// Search for:
		{ "IsDisableCoverButton",		wndMgrIsDisableCoverButton,			METH_VARARGS },
// Add after:
		{ "HasCoverButton",			wndMgrHasCoverButton,				METH_VARARGS },

Thank you so much !

But, I dont' have IsDisableCoverButton in client src. I'm using novaline.

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[VegaS™ 10049]

7 minutes ago, blaxis said:

But, I dont' have IsDisableCoverButton in client src. I'm using novaline.

Doesn't have relevance, just add it where you want in that file, following the code syntax from other functions.

As an example, instead of searching for wndMgrIsDisableCoverButton, search for wndMgrHideSlotBaseImage and HideSlotBaseImage.

I updated the first post, check it.

Edited August 28, 2021 by VegaS™

[Tatsumaru 5124]

17 minutes ago, VegaS™ said:

Doesn't have relevance, just add it where you want in that file, following the code syntax from other functions.

As an example, instead of searching for wndMgrIsDisableCoverButton, search for wndMgrHideSlotBaseImage and HideSlotBaseImage.

I updated the first post, check it.

Still something is wrong.
PythonWindow.h or PythonSlotWindow.h?

0828 22:30:13428 ::   File "networkModule.py", line 247, in SetGamePhase

0828 22:30:13428 ::   File "game.py", line 100, in __init__

0828 22:30:13428 ::   File "interfaceModule.py", line 290, in MakeInterface

0828 22:30:13429 ::   File "interfaceModule.py", line 126, in __MakeTaskBar

0828 22:30:13429 ::   File "uiTaskBar.py", line 543, in LoadWindow

0828 22:30:13429 ::   File "uiTaskBar.py", line 799, in RefreshQuickSlot

0828 22:30:13429 :: AttributeError
0828 22:30:13429 :: : 
0828 22:30:13429 :: 'GridSlotWindow' object has no attribute 'HasCoverButton'
0828 22:30:13429 :: 

[blaxis 263]

25 minutes ago, VegaS™ said:

Doesn't have relevance, just add it where you want in that file, following the code syntax from other functions.

As an example, instead of searching for wndMgrIsDisableCoverButton, search for wndMgrHideSlotBaseImage and HideSlotBaseImage.

I updated the first post, check it.

Sorry for my carelessness. You wrote PythonWindow.h, but it should have been PythonSlotWindow.h

I completed the steps but error loading screen.

0828 23:31:28911 ::   File "uiTaskBar.py", line 940, in RefreshQuickSlot

0828 23:31:28911 :: AttributeError
0828 23:31:28911 :: : 
0828 23:31:28911 :: 'GridSlotWindow' object has no attribute 'HasCoverButton'
0828 23:31:28911 :: 

 

 

 

Edited August 28, 2021 by blaxis

[VegaS™ 10049]

I forgot the ui.py part, I updated the first reply, check it now. 

Edited August 28, 2021 by VegaS™

[blaxis 263]

7 minutes ago, VegaS™ said:

I forgot the ui.py part, I updated the first reply, check it now. 

Yess  Solved.. Thank you so much!