Shop Ex Renewal

[MrQuin 8157]

The system works fine i tried it.

[displayjokes 101]

14 hours ago, MrQuin said:

The system works fine i tried it.

Can you show me this function: bool CShopManager::Initialize(TShopTable * table, int size)

From your shop_manager.cpp in game>src please?

[Zeph 8]

15 godzin temu, MrQuin napisał:

The system works fine i tried it.

You added quest or something to open shop in npc?

[Owsap 14289]

On 9/8/2019 at 3:00 PM, Zeph said:

You added quest or something to open shop in npc?

 

On 9/8/2019 at 2:34 PM, displayjokes said:

Can you show me this function: bool CShopManager::Initialize(TShopTable * table, int size)

From your shop_manager.cpp in game>src please?

You must add the value 1 to OnClick column of your shop NPC in mob_proto.
Example:

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[DirT2Games 6]

Does anyone know why these bile?

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Zeph 8]

Dnia 25.09.2019 o 03:18, Owsap napisał:

 

You must add the value 1 to OnClick column of your shop NPC in mob_proto.
Example:

I came to this myself but thanks

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[ManiacRobert 488]

Acum 1 oră, DirT2Games a spus:

Does anyone know why these bile?

 

Wrong packets.

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[DirT2Games 6]

En 26/9/2019 a las 19:03, ManiacRobert dijo:

Wrong packets.

This I suspected, but I reviewed everything and is in agreement. I don't understand why that is.

[BeQuitxHD 0]

work this system with max. Yang System (long, long) ? 

[arlinamid 1865]

Hi guys. I always get this error ConvertToShopItemTable: row(0) of group items of group tab1 does not have vnum column.

I cant figure it out what i do  it wrong @Mali61 @xP3NG3Rx

[Zeph 8]

I have a question, when i add costume weapon in shop, after buy item dissapering in equipment, i try add bonuses in shop_table_ex but then i have 2x same bonus, i added socket -1 but the same, what can i do?

 

Maybe you know what's wrong? @VegaS™ @Mali61

 

Propably i have to edit this code, but i don't know how.

 

#ifdef ENABLE_RENEWAL_SHOPEX
        char getval[256];
        for (int j = 0; j < ITEM_ATTRIBUTE_MAX_NUM; j++) {
            if (j < ITEM_SOCKET_MAX_NUM) {
                snprintf(getval,sizeof(getval), "socket%d", j);
                if (!pItemGroup->GetValue(i, getval, shopItems[i].alSockets[j])) {
                    sys_err("row(%d) stage %d of group items of group %s does not have socket column", i,j, pNode->GetNodeName().c_str());
                    return false;
                }
            }
            snprintf(getval,sizeof(getval), "attr_type%d", j);
            if (!pItemGroup->GetValue(i, getval, shopItems[i].aAttr[j].bType)) {
                sys_err("row(%d) stage %d of group items of group %s does not have attr_type column", i, j, pNode->GetNodeName().c_str());
                return false;
            }
            snprintf(getval,sizeof(getval), "attr_value%d", j);
            if (!pItemGroup->GetValue(i, getval, shopItems[i].aAttr[j].sValue)) {
                sys_err("row(%d) stage %d of group items of group %s does not have attr_value column", i, j, pNode->GetNodeName().c_str());
                return false;
            }
        }
        if (pItemGroup->GetValue(i, "price_type", shopItems[i].price_type) && pItemGroup->GetValue(i, "price_vnum", shopItems[i].price_vnum) && shopItems[i].price_type == 3) {
            if (shopItems[i].price_type > 4 || shopItems[i].price_type < 1) {
                sys_err("row(%d) of group items of group %s price_type is wrong!", i, pNode->GetNodeName().c_str());
                return false;
            }
            TItemTable * pProto = ITEM_MANAGER::instance().GetTable(shopItems[i].price_vnum);
            if (!pProto) {
                sys_err("NOT GET ITEM PROTO %d", shopItems[i].price_vnum);
                return false;
            }
        }
#endif

[/spoiler]

[xmflaal 5]

It should be good

[Zeph 8]

5 hours ago, xmflaal said:

It should be good

I had timelimit on my item, that's why it didn't work.

[Tigrex96 1]

sorry for pushing this thread but are there only shop buttons, released somewhere? so armor shiel the categories

[Gurgarath 3693]

1 hour ago, Tigrex96 said:

sorry for pushing this thread but are there only shop buttons, released somewhere? so armor shiel the categories

This is called "ShopEx"

[Tigrex96 1]

where can I find the version?

[Resist0 37]

Good working system Thanks.

 

Just 1 Question. When i add item with time like Mount and add in socket0 slot Timevalue like 2592000 = 30d ->
 

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

How can i fix it ?

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[TheR3LAX13 3]

On 9/5/2019 at 9:25 PM, Thundernatsu said:

SYSERR: Sep  5 19:23:44.71727 :: Boot: shop table size error
SYSERR: Sep  5 19:23:44.350368 :: pid_deinit: 
End of pid
@VegaS™

@VegaS™ @Mali61 pls help me!!!

[arlinamid 1865]

On 3/23/2020 at 9:54 PM, Chief said:

Good working system Thanks.

 

Just 1 Question. When i add item with time like Mount and add in socket0 slot Timevalue like 2592000 = 30d ->
 

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

How can i fix it ?

 You have to check item type and change socket0  data in source, because socket0 is a timestamp or you give a unix timestamp in the future. https://www.epochconverter.com/

 

Hi Guys, i have a problem i make something wrong,  i had bigger shop size ( 8x10) 

	pack2.owner_vid = owner_vid;
	pack2.shop_tab_count = m_vec_shopTabs.size();
	char temp[18108]; // ĂÖ´ë 1728 * 3
	char* buf = &temp[0];
	size_t size = 0;

So i enlarge the temp variable size, but i think this it wasn't the correct number 

 

Because  client give me this error :

 

CPythonNetworkStream::CheckPacket - Not enough dynamic packet size: header 38 packet size: 18108 SYSERR: RECV< HEADER_GC_SHOP (4) SYSERR: bc 46 0a SYSERR: RECV< 199 (18104)

 

If anybody have idea what i make it wrong, pls help me. Thanks. Sorry for my bad english.

@Mali61 @VegaS

 

 

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Mali 61383]

On 3/23/2020 at 11:54 PM, Chief said:

Good working system Thanks.

 

Just 1 Question. When i add item with time like Mount and add in socket0 slot Timevalue like 2592000 = 30d ->
 

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

How can i fix it ?

now it's fixed. if you don't add any (socket or attr), it's adding proto's (sockets or attrs)

....

for shop table size error:

if your tables.h doesn't have

#include "service.h"

add it.

And be careful about duplicate npcs (shop & shopex)

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Owsap 14289]

Not sure where I could share this but here is a way to simply reload the ShopTableEx in-game.

In reply to @Chief, @CHMarvin, @thespeedy and a contribution to @masodikbela's & @Mali61 post.

 

 

Reload ShopTableEx

 

game/src/cmd_gm.cpp

Spoiler

/// 1.
// Add
#include "shop_manager.h"

/// 2.
// Search
		switch (LOWER(*arg1))

// Add above
		if (strstr(arg1, "shop_ex"))
		{
			char szShopTableExFileName[256];
			snprintf(szShopTableExFileName, sizeof(szShopTableExFileName),
				"%s/shop_table_ex.txt", LocaleService_GetBasePath().c_str());

			if (CShopManager::instance().ReloadShopTableEx(szShopTableExFileName))
				ch->ChatPacket(CHAT_TYPE_INFO, "Reloading ShopTableEx.");
			else
				ch->ChatPacket(CHAT_TYPE_INFO, "Failed to reload ShopTableEx.");

			return;
		}

 

game/src/shop_manager.cpp

Spoiler

/// 1.
// Search
bool CShopManager::ReadShopTableEx(const char* stFileName)

// Add above
bool CShopManager::ReloadShopTableEx(const char* stFileName)
{
	return ReadShopTableEx(stFileName, true);
}

/// 2.
// Search
bool CShopManager::ReadShopTableEx(const char* stFileName)

// Replace with
bool CShopManager::ReadShopTableEx(const char* stFileName, bool bReload)

/// 3.
// Search
	typedef std::multimap <DWORD, TShopTableEx> TMapNPCshop;
	TMapNPCshop map_npcShop;

// Add below
	if (bReload)
	{
		sys_log(0, "RELOADING ShopTableEx");
		map_npcShop.clear();
		m_map_pkShopByNPCVnum.clear();
		m_map_pkShop.clear();
	}

 

game/src/shop_manager.h

Spoiler

/// 1.
// Search
	void Destroy();

// Add below
	bool ReloadShopTableEx(const char* stFileName);

/// 2.
// Search
	bool ReadShopTableEx(const char* stFileName);

// Replace with
	bool ReadShopTableEx(const char* stFileName, bool bReload = false);

 

 

Result

 

https://metin2.download/picture/o46OU9SVu96fNAANCWZ2lTT1krtmT0r0/.gif

 

 

Edited August 27, 2022 by Metin2 Dev
Core X - External 2 Internal

[Natox 20]

Nice job thanks

[numNum 39]

Thank you for the release it works perfectly   

 

 

hmm is there any way to make it through MySQL ( something like shop_ex and shop_item_ex ) ??

i think it would be better than .txt 

 

 

 

 

 

 

 

Edited April 12, 2020 by jeddawee

[Mali 61383]

23 hours ago, Owsap said:

Not sure where I could share this but here is a way to simply reload the ShopTableEx in-game.

In reply to @Chief, @CHMarvin, @thespeedy and a contribution to @masodikbela's & @Mali61 post.

thank you but those containers are using by normal shops too

18 hours ago, jeddawee said:

Thank you for the release it works perfectly   

 

 

hmm is there any way to make it through MySQL ( something like shop_ex and shop_item_ex ) ??

i think it would be better than .txt 

 

But this is shopex

 

Update:

*Added reload command

Edited April 13, 2020 by Mali61

[ezentere 0]

"Share / locale / xx /"
When I throw this file "shop_table_ex.txt" to this path, I get the "Error connecting to server" error while logging in to the game.