Chat PM System (@name message)

[Mali 39482]

M2 Download Center

This is the hidden content, please

• Sign In
• or
• Sign Up

( Internal )

This is the hidden content, please

• Sign In
• or
• Sign Up

( GitHub )

Spoiler

 

Usage: @name message

[Mareq 0]

Image not load

[Mali 39482]

7 hours ago, Mareq said:

Image not load

Edited August 24, 2022 by Metin2 Dev
Core X - External 2 Internal

[HaiosMotan 378]

It's working but there's a problem..You can spam without geting kicked..can you put a timer?

[Speachless 748]

#ifdef CHAT_PM
	std::string findstr(buf);
	if (findstr.at(0) == '@') 
	{
		findstr = findstr.substr(1);
		int pos = findstr.find(" ");
		std::string message = findstr.substr(pos + 1), chname = findstr.substr(0, pos);

		LPCHARACTER stch = CHARACTER_MANAGER::instance().FindPC(chname.c_str());
		if (stch)
		{
			if (message.size() - chname.size() <= 1 )
			{
				ch->ChatPacket(CHAT_TYPE_INFO, "You haven't written a message or it is too short.");
				return (iExtraLen);
			}
          
			if (ch->GetLastPMPulse() < thecore_pulse())
					ch->ClearPMCounter();
		  
			if (ch->GetPMCounter() > 3 && ch->GetLastPMPulse() > thecore_pulse())
			{
					ch->GetDesc()->SetPhase(PHASE_CLOSE);
					return -1;
			}
			if (stch == ch)
			{
				ch->ChatPacket(CHAT_TYPE_INFO, "You can't send message to yourself.");
				return (iExtraLen);
			}
          
			stch->ChatPacket(CHAT_TYPE_WHISPER, "%s: %s", ch->GetName(), message.c_str());
			ch->ChatPacket(CHAT_TYPE_WHISPER, "To %s: %s", stch->GetName(), message.c_str());
			ch->IncreasePMCounter();
			ch->SetLastPMPulse();			
		}
		else
			ch->ChatPacket(CHAT_TYPE_INFO, "The player doesn't exist or is not online.");
		return (iExtraLen);
	}
#endif

I've made some improvements

[Mali 39482]

1 hour ago, SergiuAndreiM said:

It's working but there's a problem..You can spam without geting kicked..can you put a timer?

Updated

 

[Speachless 748]

9 minutes ago, Mali61 said:

Updated

 

It's more efficient to use thecore_pulse rather than a quest flag. It is a constructive critique. I like your pm in chat idea.

[Mali 39482]

Thanks bro but this part is wrong

if (stch)
		{
			.....
			....
			stch->ChatPacket(CHAT_TYPE_WHISPER, "%s: %s", ch->GetName(), message.c_str());
			ch->ChatPacket(CHAT_TYPE_WHISPER, "To %s: %s", stch->GetName(), message.c_str());
			....	
		}
		else if (stch == ch)

You can use this:

		if (stch)
		{
			if (stch == ch)
				bla bla
			.....
			....
			stch->ChatPacket(CHAT_TYPE_WHISPER, "%s: %s", ch->GetName(), message.c_str());
			ch->ChatPacket(CHAT_TYPE_WHISPER, "To %s: %s", stch->GetName(), message.c_str());
			....	
		}

 

[Speachless 748]

Yep, I noticed and corrected. I tested. It works ok. There would still be ok if we make a check for 0 message length.

[Mali 39482]

1 minute ago, Dobrescu Sebastian said:

Yep, I noticed and corrected. I tested. It works ok. There would still be ok if we make a check for 0 message length.

Okey okay ok I will add but now I'm going to sleep

[Speachless 748]

24 minutes ago, Mali61 said:

Okey okay ok I will add but now I'm going to sleep

I've done this too.