Opponent's hp quest

[Aioria 10]

Hi! I found this quest on epvp from Vegas, and it works, I've just a problem. 

The syschat is printed twice when get killed and I can't fix it

 

  
	quest hp_opponent_info begin
    state start begin
        when kill with npc.is_pc() begin
            local opponent
                if pc.get_sex() == 0 then
                    opponent = "he"
                else
                    opponent = "she"
                end
            local remaining_life = pc.get_hp()
            local obtaining_names = pc.get_name()
            local killing_enemy = npc.get_vid()
	                if killing_enemy == 0 or killing_enemy == pc.get_vid() then
                    return
                end
	            local old_opponent = pc.select(killing_enemy)
                syschat("You were killed by '"..obtaining_names.."', and "..opponent.." remained with "..remaining_life.." hp")
                pc.select(old_opponent)
        end
    end
end
	  

 

[Syreldar 1820]

	                if killing_enemy == 0 or killing_enemy == pc.get_vid() then
                    return
                end

o boi

 

btw, the bug is source-sided, it's known that kill triggers trigger twice for players.

Solution:

Search this line in the questmanager.cpp file:

m_mapNPC[npc].OnKill(*pPC);

Substitute with:

 

if (npc > 0)
{
    m_mapNPC[npc].OnKill(*pPC);
}

[Aioria 10]

Ah sorry, i didn't know it  I'm newbe with this, btw thanks so much, i'll try it right now

------------- Edit --------------

Je t'aime! It works perfectly, thank you very much!

Can I ask you how to improve the quest? I've noticed you didn't appreciated this part

 

	                if killing_enemy == 0 or killing_enemy == pc.get_vid() then
                    return
                end[/CODE]

and if this don't disturb you, can i ask you to tell me how make this quest print even if the killing player is buffed by group skill? or just if it is in a group.

Anyway thanks again, no problem if you don't answer to these questions

[Syreldar 1820]

I can't print if player is buffed, there is no function for that.

to improve the quest, remove all that ..thing..i've quoted, it's useless coding.

[Aioria 10]

Ok, I'll try when I go home, thank you again!