Jump to content
Sign in to follow this  
HG66

[Fix] Blessing Scroll

Recommended Posts

if (pkItemScroll->GetValue(0) == YONGSIN_SCROLL)
	{
		success_prob = MIN(100,success_prob+10);
	}

Fixxed and Function.

 

Bye

  • Love 4

Share this post


Link to post

The blessing scroll don't give 10%+ Upp. With this fix BS Give 10+%

  • Love 1

Share this post


Link to post

In the original case the Blessing Scroll does not raise the successful rate.

The Dragon's Scroll is raising the rate with 10%.

 

:mellow:

Share this post


Link to post

Nope. The rate 10+ are unfixxed. :D

Share this post


Link to post
25040	Blessing Scroll	Reduces the risk of destroying an Item if the upgrade fails. The cost of this save is that the quality is reduced by 1 point.
71032	Dragon Scroll	Eliminates the risk of destroying an item if the improvement fails. Only its quality will be decreased by 1. Additionally, the probability of a successful improvement will increase by 10%.

Do you see the differences?

Those lines from .UK client.

And here is from .DE:

25040	Segensschriftrolle	Beseitigt das Risiko, einen Gegenstand zu zerstören, wenn seine Verbesserung fehlschlägt. In diesem Fall wird lediglich seine Qualität um 1 verringert.
71032	Schriftrolle des Drachen	Beseitigt das Risiko, einen Gegenstand zu zerstören, wenn seine Verbesserung fehlschlägt. Es wird nur die Qualität um eine Stufe verringert. Zudem erhöht sich die Wahrscheinlichkeit einer erfolgreichen Verbesserung um 10 %.

Your modification removes the blessing scorlls. Do you understand?

Share this post


Link to post

Yea but this 10% don't exist. Without a fix :D

 

I  have tested.

Share this post


Link to post

You are wrong.

 

The Blessing scroll doesn't give +10% succesfull rate, just grants that the item will not be lost after trying to improve it.

 

The Dragon Scroll, instead, should give +10% succesfull rate, BUT it doesn't, it has a completely different refine-function, check the gamefile and you will know what i'm talking about.

 

try to refine an item with 90% success rate and use the Dragon scroll, the probability will not be 100%, the item can fail.

try to refine an item with 100% success rate and use the Dragon scroll, the probability will not be 110%, the item can fail either. ;)

Share this post


Link to post

Exactly. The Dragon God blessing scroll and Master Compass are said to increase the upgrade rate but in reality they have a fixed table. We changed that in our game so it's really 10% more effective.

  • Love 1

Share this post


Link to post

100% succes_prób + 10% = crash game.

 

Thanks for bug. ^^

Share this post


Link to post

Exactly. The Dragon God blessing scroll and Master Compass are said to increase the upgrade rate but in reality they have a fixed table. We changed that in our game so it's really 10% more effective.

Yes, that's correct.

Share this post


Link to post
if (pkItemScroll->GetValue(0) == YONGSIN_SCROLL)
		{
			if (LC_IsYMIR() == true || LC_IsKorea() == true)
				success_prob = hyuniron_prob_euckr[MINMAX(0, item->GetRefineLevel(), 8)];
			else
				success_prob = hyuniron_prob[MINMAX(0, item->GetRefineLevel(), 8)];
		}

for

if (pkItemScroll->GetValue(0) == YONGSIN_SCROLL)
	{
		success_prob = MIN(100,success_prob+10);
	}

?

 

and how to change YONGSIN_SCROLL to normal id ?

 

-----------------------------------------------------------

const char hyuniron_prob[9] = { 100, 75, 65, 55, 45, 40, 35, 25, 20 };
		const char hyuniron_prob_euckr[9] = { 100, 75, 65, 55, 45, 40, 35, 30, 25 };

		const char yagong_prob[9] = { 100, 100, 90, 80, 70, 60, 50, 30, 20 };
		const char yagong_prob_euckr[9] = { 100, 100, 90, 80, 70, 60, 50, 40, 30 };

		if (pkItemScroll->GetValue(0) == YONGSIN_SCROLL)
		{
			if (LC_IsYMIR() == true || LC_IsKorea() == true)
				success_prob = hyuniron_prob_euckr[MINMAX(0, item->GetRefineLevel(), 8)];
			else
				success_prob = hyuniron_prob[MINMAX(0, item->GetRefineLevel(), 8)];
		}
		else if (pkItemScroll->GetValue(0) == YAGONG_SCROLL)
		{
			if (LC_IsYMIR() == true || LC_IsKorea() == true)
				success_prob = yagong_prob_euckr[MINMAX(0, item->GetRefineLevel(), 8)];
			else
				success_prob = yagong_prob[MINMAX(0, item->GetRefineLevel(), 8)];
		}
		else

Thats mean the yongsin give +5%, yagong +5%?

Share this post


Link to post

if (pkitemscroll->GetVnum () == VNUMOFSCROLL) 

  • Love 1

Share this post


Link to post
 
Which one scroll is blacksmith handbook
 
 
CHUKBOK_SCROLL = 0,
    HYUNIRON_CHN   = 1, // Áß±ążˇĽ­¸¸ »çżë
    YONGSIN_SCROLL = 2,
    MUSIN_SCROLL   = 3,
    YAGONG_SCROLL  = 4,
    MEMO_SCROLL       = 5,
    BDRAGON_SCROLL    = 6,
 
 
Or that a scroll what id and where it is declared, what file?

Share this post


Link to post

Hello,

Sorry for push old thread, but i dont found a fix for it.

Anyone have a good fix for it?

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.