Filtering the chat

[Matteo 69]

Hi,

Im trying with a function to filter some string from the chat, but it gives a strange error.

Functions:

const char* FilterChat(const char* c_pszBuffer)
{
    std::string strChatBuf = c_pszBuffer;

    // Other stuff with the string, but its commented out rn.
    
    char szTmpBuf[1024 + 1] = {};
    const char* c_szpFilterBuf = strChatBuf.c_str();
    _snprintf(szTmpBuf, sizeof(szTmpBuf), "%s", c_szpFilterBuf);

    return szTmpBuf;

}

In bool CPythonNetworkStream::RecvChatPacket():

#ifdef CHAT_FILTER
	CPythonTextTail::Instance().RegisterChatTail(kChat.dwVID, FilterChat(line));
#else
	CPythonTextTail::Instance().RegisterChatTail(kChat.dwVID, line);
#endif

 

And in-game its junk:

 

What's the problem? With debugging it seems the array gets created with full of junk already, but i've initialized it with full of zeroes if im not wrong.

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal

[Owsap 14484]

Use a static variable instead for szTmpBuf.

static char szTmpBuf[1024 + 1] = {};	

[Denizeri24 43]

7 minutes ago, Owsap said:

Use a static variable instead for szTmpBuf.

static char szTmpBuf[1024 + 1] = {};	

for better;

constexpr char szTmpBuf[1024 + 1] = {};    

[Matteo 69]

On 10/5/2021 at 8:59 PM, Owsap said:

Use a static variable instead for szTmpBuf.

static char szTmpBuf[1024 + 1] = {};	

Thanks worked!

[VegaS™ 13108]

Quote

1>PythonNetworkStreamPhaseGame.cpp(xxxx): warning C4172: returning address of local variable or temporary

or:

That's a small tip for the next time when you're coding, so you'll know if it's a critical warning and it needs real attention or not, based on the level.

https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings

Edited August 17, 2022 by Metin2 Dev
Core X - External 2 Internal