DS - Bonus Set

[WizKid 3]

16 hours ago, Cappuccino said:

I can say that probably the bug is in uitooltip.py

I was tweaking the code from UiToolTip.py and noticed the problem might come from this line:

if window_type == player.INVENTORY and self.interface and self.interface.wndDragonSoul:

It might be that the trade window is considered an inventory window, that's why it shows the DS Bonus...

Also tried to change to player.EQUIPMENT, since I have the Extended Inventory_system implemented, but that way I can't even see the DS Set Bonus anywhere.

Is there any other variable I can change to, that only affects the DS Slots?
 

[iMerv3 1023]

On 3/24/2021 at 2:08 AM, WizKid said:

Hi, does anyone know how to fix this? (Sorry for the bad image quality)
If I trade DS while my set is on, it shows the bonus of the stones inside the trade window.

https://metin2.download/picture/r3F9504x09DVmF8K988YXgTtGTP6KMUj/.gif

Thanks 

 

 

 

On 3/24/2021 at 9:52 PM, Cappuccino said:

I can say that probably the bug is in uitooltip.py

In fact, in uiToolTip.py, window_type should be right when append __AppendDragonSoulAttributeInformation. Most people use the old uidragonsoul.py class and is most common that you will have this kind of problems.

 

Example (also make sure in uiDragonSoul.py on OverInEquipItem func must be self.ShowToolTip(player.EQUIPMENT, overSlotPos))

Spoiler

if window_type == player.EQUIPMENT and self.interface and self.interface.wndDragonSoul:
    self.__AppendDragonSoulAttributeInformation(attrSlot, itemVnum/10000, self.interface.wndDragonSoul.GetDSSetGrade())
else:
    self.__AppendDragonSoulAttributeInformation(attrSlot)

 

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[centarus 1]

how can i solve?

https://metin2.download/picture/ZUgC685gVGjDF9HryJ3iTm4q2JEyf11O/.png

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[SamuraiHUN 1963]

2 hours ago, centarus said:

how can i solve?

https://metin2.download/picture/yqZr15c2nwTExdt76dh1A4PhFX7Q7Tly/.png

		if app.ENABLE_DS_SET:
			self.tooltipItem.BindInterface(self)

add this before:

 

		self.tooltipItem = uiToolTip.ItemToolTip()

interfacemodule.py

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[centarus 1]

39 minutes ago, SamuraiHUN said:

		if app.ENABLE_DS_SET:
			self.tooltipItem.BindInterface(self)

add this before:

 

		self.tooltipItem = uiToolTip.ItemToolTip()

interfacemodule.py

thx but it already is

Edited September 1, 2021 by centarus

[SamuraiHUN 1963]

This is the hidden content, please

• Sign In
• or
• Sign Up

0.0.1 modification: Fixed the path to the uiaffectshower.py + add image ymir work/ui/dragonsoul folder.

Edited September 2, 2021 by SamuraiHUN

[Nuzzo 74]

Can anyone help me? After following the whole tutorial I get this error in the client and its closing.
I also tried debugging but I get no information

https://metin2.download/picture/fgR10X846RjJl6imsKSFwc3XY53ENLFk/.png

Edited March 11, 2023 by Metin2 Dev International
Core X - External 2 Internal

[samedovich 25]

if you only want bonuses to be displayed on equipped gems and not elsewhere...

 

### uitooltip.py ###

#find

		elif item.ITEM_TYPE_DS == itemType:
			self.AppendTextLine(self.__DragonSoulInfoString(itemVnum))

			if app.ENABLE_DS_SET:
				if window_type == player.EQUIPMENT and self.interface and self.interface.wndDragonSoul:
					self.__AppendDragonSoulAttributeInformation(attrSlot, itemVnum / 10000, self.interface.wndDragonSoul.GetDSSetGrade())
				else:
					self.__AppendAttributeInformation(attrSlot)
			else:
				self.__AppendAttributeInformation(attrSlot)

		else:
			self.__AppendLimitInformation()

### replace them all with this

		elif item.ITEM_TYPE_DS == itemType:
			self.AppendTextLine(self.__DragonSoulInfoString(itemVnum))

			if app.ENABLE_DS_SET:
				showSetBonus = False
				if self.interface and self.interface.wndDragonSoul:
					if slotIndex != -1 and window_type is not None:
						try:
							if player.IsDSEquipmentSlot(window_type, slotIndex):
								showSetBonus = True
						except:
							showSetBonus = False

				if showSetBonus:
					self.__AppendDragonSoulAttributeInformation(
						attrSlot, itemVnum / 10000, self.interface.wndDragonSoul.GetDSSetGrade()
					)
				else:
					self.__AppendDragonSoulAttributeInformation(attrSlot)
			else:
				self.__AppendAttributeInformation(attrSlot)