Problem with a little function in quest

[Zoom 1]

 

Hi, i have a problem with "if" in my quest.

 

This quest looks like:

 

when xxx.use begin

 

[...]

 

if pc.get_skill_group() != 1 and pc.get_job() != 0 or pc.get_job() != 4 then
    syschat("["..item.get_name().."]".." you are not a warrior body")
    return

end

 

Translate: When im not a BODY and WARRIOR MEN or WOMAN, return...

but when i try use item on warrior with skills BODY, i got syschat "you are not a warrior body"

 

Really i don't know why this doesn't work, this is a simple function, somebody have idea whats wrong?

 

Best regards.

 

[Cunoo 183]

quest test begin
	state start begin
		when login begin
			set_state(information)
		end
	end
	state information begin
		when letter begin
			send_letter("Test")
		end
		when button or info begin
			if pc.get_skill_group() == 1 and pc.get_job() == 0 or pc.get_job() == 4 then
				say_title("Test")
				say("")
				say("You are a warrior body. (man/woman)")
				say("")
				clear_letter()
			else
				say_title("Test")
				say("")
				say("You are not a warrior body. (man/woman)")
				say("")
				clear_letter()
			end
		end
	end
end

if not pc.get_skill_group() == 1 and pc.get_job() == 0 or pc.get_job() == 4 then
	syschat("["..item.get_name().."]".." you are not a warrior body")
	return
end

quest test2 begin
	state start begin
		when login begin
			set_state(information)
		end
	end
	state information begin
		when letter begin
			send_letter("Test2")
		end
		when button or info begin
			if not pc.get_skill_group() == 1 and pc.get_job() == 0 or pc.get_job() == 4 then
				say_title("Test2")
				say("")
				say("You are not a warrior body. (man/woman)")
				say("")
				clear_letter()
			else
				say_title("Test2")
				say("")
				say("You are a warrior body. (man/woman)")
				say("")
				clear_letter()
			end
		end
	end
end

 

Edited August 7, 2020 by Cunoo

[Zoom 1]

@Cunoo

 

When i change my line of "if" to "if not pc.get_skill_group() == 1 and pc.get_job()== 0 or pc.get_job() == 4 then

i doesn't work, when i change pc.get_skill_group() == 1 to pc.get_skill_group() == 2 (MENTAL) i can use item.

 

Thanks for quests but in my case i can't use like this:

 

if bla bla

   bla bla

else <---- with else

  bla bla

 

I have to include this "if" to this list:

 

when xxx.use begin

 

if pc.get_skill_group() == 0 then
                syschat("...")
                return
            end

if table.getn(vnum_list) == 0 then
                syschat("...")
                return
            end
            
if pc.count_item(50513) == 0 then
                syschat("..")
                return
            end
            
 if not pc.can_warp() then
                syschat("..")
                return
            end

 

----- HERE TO SPEACE FOR IF --

 

"if" must end with return end

[WeedHex 590]

1 hour ago, Zoom said:

@Cunoo

 

When i change my line of "if" to "if not pc.get_skill_group() == 1 and pc.get_job()== 0 or pc.get_job() == 4 then

i doesn't work, when i change pc.get_skill_group() == 1 to pc.get_skill_group() == 2 (MENTAL) i can use item.

 

Thanks for quests but in my case i can't use like this:

 

if bla bla

   bla bla

else <---- with else

  bla bla

 

I have to include this "if" to this list:

 

when xxx.use begin

 

if pc.get_skill_group() == 0 then
                syschat("...")
                return
            end

if table.getn(vnum_list) == 0 then
                syschat("...")
                return
            end
            
if pc.count_item(50513) == 0 then
                syschat("..")
                return
            end
            
 if not pc.can_warp() then
                syschat("..")
                return
            end

 

----- HERE TO SPEACE FOR IF --

 

"if" must end with return end

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal

[Zoom 1]

1 hour ago, WeedHex said:

Yee, i like it too, but i don't understand?

 

Edit: Solved,  @Cunoo helped me

Edited August 25, 2022 by Metin2 Dev
Core X - External 2 Internal