Jump to content
×
×
  • Create New...
  • 0

[Problem] ITEM_RING doesn't give bonuses


takbardzo

Question

 

1. Description of the problem / Question :

When an item with type 33 (ITEM_RING) is equipped, character doesn't receive any bonuses. It equips just fine and the item equip effect goes off, but there are no stats added. Also when I changed the ITEM_RING condition in char_item.cpp to just show me some kind of a message when I equip it, it worked, so it's probably a little too deeper for me.

 

 

2. SysErr ( Client / Server ) / SysLog ( Server )

nussink

 

3. How to reproduce it ?

So I've changed the magic lollipop type to 33 - nZuZHVK.png this one xD and it doesn't give any bonuses. And it did when it was still an ITEM_UNIQUE

 

4. Screenshots ?

Nothing to show here tbh...

 

 

 

 

 

Edited by Metin2 Dev
Core X - External 2 Internal
Link to comment
Share on other sites

7 answers to this question

Recommended Posts

  • 0
  • Bot
item.cpp:

int CItem::FindEquipCell(LPCHARACTER ch, int iCandidateCell)
{
	[...]
	if (GetType() == ITEM_DS || GetType() == ITEM_SPECIAL_DS)
	{
		[...]
	}
	else if (GetType() == ITEM_COSTUME)
	{
		[...]
	}
	// look if you have this
	else if (GetType() == ITEM_RING)
	{
		if (ch->GetWear(WEAR_RING1))
			return WEAR_RING2;
		else
			return WEAR_RING1;
	}
	// look if you have this
	else if (GetType() == ITEM_BELT)
		return WEAR_BELT;
	else if (GetWearFlag() & WEARABLE_BODY)
		return WEAR_BODY;
	[...]
}

Tbh i don't think it's there since that's for you to equip, but I remember that before I had that disabled and the bonuses didn't work for me either. But you lose nothing by trying.

Edited by M2Dev

english_banner.gif

Link to comment
Share on other sites

  • 0
  • Bot
11 minutes ago, takbardzo said:

 

I don't think I do, gonna look into it.

 

 

 

Yeah I did have this in place, thanks tho.

But, you are sure it not giving bonus? Or just not showing them?. Can you equip the ring and put:
/state

?

english_banner.gif

Link to comment
Share on other sites

  • 0
5 minutes ago, WLsj24 said:

--

 

Thanks for replying, just did the /state test. It's supposed to award +1k HP. Lower one is after putting it on but there's no change anyway. Craap.

 

spacer.png

Edited by Metin2 Dev
Core X - External 2 Internal
  • Sad 1
Link to comment
Share on other sites

  • 0
  • Distinguished Member

Maybe i'm offing maybe not but i just gave the rings item_proto bonus and that will work, also you can show them to players with uitooltip.py, so either better.

Link to comment
Share on other sites

  • 0
On 7/3/2020 at 12:25 PM, TMP4 said:

Maybe i'm offing maybe not but i just gave the rings item_proto bonus and that will work, also you can show them to players with uitooltip.py, so either better.

 

Yup! It did work. Seems like item_ring reads bonuses from item_proto just like weapons, armors etc, or whatever. Thank you! It works flawlessly now.

Link to comment
Share on other sites

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Answer this question...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recently Browsing   0 members

    • No registered users viewing this page.


  • Metin2 Dev Github
  • Activity

    1. 6

      Owsap Productions

    2. 11

      BUG SAFEBOX disappear stacks ..

    3. 2

      Error no member named SetcCreateTime in Citem

    4. 2

      Need some help with effect slot on pickup system

    5. 1

      GF Pet system "x" level / percent

    6. 1

      disable quest esc

    7. 2

      Navicat Premium 16.1.3 x64

    8. 2

      Join the Metin2 Dev team

    9. 2

      Error no member named SetcCreateTime in Citem

Important Information

Terms of Use / Privacy Policy / Guidelines / We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.