Legend 186 Posted June 28, 2018 Share Posted June 28, 2018 Hey, Today i will show you how you can fix easy the invisibility effect bug and the AFFECT_EUNHYEONG = sealth ninja skill from 17.5 Official update. InstanceBase.cpp (Is hiding the ninja from the minimap) Spoiler Search for: Spoiler BOOL CInstanceBase::IsInvisibility() { if (IsAffect(AFFECT_INVISIBILITY)) return true; return false; } Replace with: Spoiler BOOL CInstanceBase::IsInvisibility() { if (IsAffect(AFFECT_INVISIBILITY) || IsAffect(AFFECT_EUNHYEONG)) return true; return false; } Search for: Spoiler void CInstanceBase::Render() { Inside the function search for: m_GraphicThingInstance.Render(); Add bellow: CPythonCharacterManager & rkChrMgr = CPythonCharacterManager::Instance(); for (auto ptr = rkChrMgr.CharacterInstanceBegin(); ptr != rkChrMgr.CharacterInstanceEnd(); ++ptr) { CInstanceBase * pkInstEach = *ptr; if (pkInstEach) { if (pkInstEach->IsAffect(AFFECT_EUNHYEONG) || pkInstEach->IsAffect(AFFECT_INVISIBILITY)) { if (CPythonPlayer::Instance().IsMainCharacterIndex(pkInstEach->GetVirtualID())) continue; pkInstEach->m_GraphicThingInstance.HideAllAttachingEffect(); } } } InstanceBaseEffect.cpp Search for: Spoiler void CInstanceBase::__SetAffect(UINT eAffect, bool isVisible) { Inside the function search: case AFFECT_INVISIBILITY: if (isVisible) { m_GraphicThingInstance.ClearAttachingEffect(); __EffectContainer_Destroy(); DetachTextTail(); } else { m_GraphicThingInstance.BlendAlphaValue(1.0f, 1.0f); AttachTextTail(); RefreshTextTail(); } return; break; } Replace with: Spoiler case AFFECT_INVISIBILITY: if (isVisible) { // m_GraphicThingInstance.ClearAttachingEffect(); // __EffectContainer_Destroy(); // DetachTextTail(); m_GraphicThingInstance.HideAllAttachingEffect(); } else { m_GraphicThingInstance.BlendAlphaValue(1.0f, 1.0f); m_GraphicThingInstance.ShowAllAttachingEffect(); // AttachTextTail(); // RefreshTextTail(); } return; break; 2 18 Link to comment Share on other sites More sharing options...
Shang 368 Posted June 28, 2018 Share Posted June 28, 2018 What is the bug? Link to comment Share on other sites More sharing options...
.Kain 1 Posted June 28, 2018 Share Posted June 28, 2018 vor 13 Minuten schrieb Shang: What is the bug? if you use stealth skill, you can be seen on minimap, but not anymore 1 Link to comment Share on other sites More sharing options...
Legend 186 Posted June 28, 2018 Author Share Posted June 28, 2018 There is also a fix about the /in command. Link to comment Share on other sites More sharing options...
Tallywa 35 Posted June 28, 2018 Share Posted June 28, 2018 bug with command /inv Link to comment Share on other sites More sharing options...
Premium WeedHex 635 Posted June 28, 2018 Premium Share Posted June 28, 2018 Thx 4 share! Link to comment Share on other sites More sharing options...
Forum Moderator Raylee 655 Posted June 29, 2018 Forum Moderator Share Posted June 29, 2018 Nice release Thank you Best regards Raylee Link to comment Share on other sites More sharing options...
Heathcliff 182 Posted July 7, 2018 Share Posted July 7, 2018 Thank you for this release, but it has a small bug. Make your GM character invisible, then zoom in your chatracter. You will se your character all it effects like GM logo, and skill effects. Then use Ninja hiding skill, and make this camera movement again with another character next to the ninja char. You will see the armor effects on the ninja 2 Link to comment Share on other sites More sharing options...
numNum 37 Posted July 11, 2018 Share Posted July 11, 2018 (edited) thx for sharing this fix but there is still one bug with m_GraphicThingInstance.HideAllAttachingEffect(); that when any player zoom to gm he can see his gm logo https://metin2.download/picture/uq37GLp9hzMK0vWbvUmAojq9YZWtntLe/.png hopefully you can fix it Edited September 3, 2022 by Metin2 Dev Core X - External 2 Internal 1 3 3 Link to comment Share on other sites More sharing options...
Active Member ReFresh 2330 Posted October 13, 2018 Active Member Share Posted October 13, 2018 ref I'll be always helpful! Link to comment Share on other sites More sharing options...
Legend 186 Posted November 20, 2018 Author Share Posted November 20, 2018 #Update, with a instancebase fix. 2 Link to comment Share on other sites More sharing options...
Honorable Member Tatsumaru 5243 Posted November 21, 2018 Honorable Member Share Posted November 21, 2018 (edited) One problem in the instancebase.cpp file. Other players do not see the visualization of skills. Is anyone able to fix it? Edited August 28, 2022 by Metin2 Dev Core X - External 2 Internal 2 Link to comment Share on other sites More sharing options...
Legend 186 Posted November 30, 2018 Author Share Posted November 30, 2018 (edited) On 11/21/2018 at 5:59 PM, Tatsumaru said: One problem in the instancebase.cpp file. Other players do not see the visualization of skills. Is anyone able to fix it? That problem is exist in official too, when i got some more time i will check more to find a solution, but atm idk. Edited August 28, 2022 by Metin2 Dev Core X - External 2 Internal 5 Link to comment Share on other sites More sharing options...
xUniverse 18 Posted December 20, 2018 Share Posted December 20, 2018 (edited) En 21/11/2018 a las 12:59, Tatsumaru dijo: One problem in the instancebase.cpp file. Other players do not see the visualization of skills. Is anyone able to fix it? This is what you want? (the delay is because I've tested in a online sv and my conection is bad) Edited August 28, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
Honorable Member Tatsumaru 5243 Posted December 20, 2018 Honorable Member Share Posted December 20, 2018 (edited) 20 minut temu, xUniverse napisał: This is what you want? (the delay is because I've tested in a online sv and my conection is bad) will the ninja disappear from the radar of the shaman? Edited August 25, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
xUniverse 18 Posted December 20, 2018 Share Posted December 20, 2018 hace 9 minutos, Tatsumaru dijo: will the ninja disappear from the radar of the shaman? Yes, the ninja disappear from the radar Link to comment Share on other sites More sharing options...
Honorable Member Tatsumaru 5243 Posted December 20, 2018 Honorable Member Share Posted December 20, 2018 12 minut temu, xUniverse napisał: Yes, the ninja disappear from the radar Can you write how you did it? 1 Link to comment Share on other sites More sharing options...
Active Member Mind Rapist 186 Posted February 3, 2019 Active Member Share Posted February 3, 2019 (edited) On 12/20/2018 at 11:12 AM, xUniverse said: This is what you want? (the delay is because I've tested in a online sv and my conection is bad) Anyone has this fix? Edited August 25, 2022 by Metin2 Dev Core X - External 2 Internal Link to comment Share on other sites More sharing options...
xUniverse 18 Posted February 17, 2019 Share Posted February 17, 2019 En 3/2/2019 a las 1:22, Mind Rapist dijo: Anyone has this fix? I've modified the CInstanceBase::__Assassin_SetEunhyeongAffect(bool isVisible) in InstanceBaseEffect.cpp. 1. If the player have the affect: the function destroys (with __EffectContainer_Destroy) all effects. 2. If the affect ends: I've created two new functions (RefreshRefinedEffect and RefreshAffectEffect) that "reload" the attached effects again. For the moment the only bug I found is: if you login with the affect, all effects will be shown again... Does anyone have another idea? Link to comment Share on other sites More sharing options...
Active Member ReFresh 2330 Posted February 20, 2019 Active Member Share Posted February 20, 2019 ref I'll be always helpful! Link to comment Share on other sites More sharing options...
Active Member Mind Rapist 186 Posted February 22, 2019 Active Member Share Posted February 22, 2019 On 2/17/2019 at 11:05 AM, xUniverse said: I've modified the CInstanceBase::__Assassin_SetEunhyeongAffect(bool isVisible) in InstanceBaseEffect.cpp. 1. If the player have the affect: the function destroys (with __EffectContainer_Destroy) all effects. 2. If the affect ends: I've created two new functions (RefreshRefinedEffect and RefreshAffectEffect) that "reload" the attached effects again. For the moment the only bug I found is: if you login with the affect, all effects will be shown again... Does anyone have another idea? That gives me an idea! If someone knows the name of the colored effect that fires on skill activation (not the skill's affect itself) just the effect around the player, we can exclude it from being executed during __EffectContainer_Destroy. Link to comment Share on other sites More sharing options...
kamil2321 11 Posted March 21, 2019 Share Posted March 21, 2019 Thanks for the code, I used a bit. Fix is not correct, because it's just hiding effects and the player(and GM) from another kingdom sees on the minimap of the opponent. But I respect and appreciate! So far, I managed to do it for now:https://youtu.be/wvN5Io_tXL8 But I do not have time to refine the code, I will definitely do it and share it someday! 1 1 1 Link to comment Share on other sites More sharing options...
Premium WeedHex 635 Posted March 21, 2019 Premium Share Posted March 21, 2019 It works but there is something wrong that's fucks my players, I got problem with this and I don't suggest to use. Link to comment Share on other sites More sharing options...
SorinSmon 493 Posted January 30, 2020 Share Posted January 30, 2020 i installl but no chance.. anyone can help me with this? Link to comment Share on other sites More sharing options...
SorinSmon 493 Posted February 22, 2020 Share Posted February 22, 2020 up? Link to comment Share on other sites More sharing options...
Recommended Posts