Quest ESC syserr

[daradevil124 369]

Hello community,

Today I have encountered a problem with my server and I would like to ask you about the solution.

Problem:
In the game, if you press the ESC key quickly while any Quest window is open, the server side prints the following SysErr;

SYSERR: Feb 6 02:17:45 :: Select: wrong QUEST_SELECT request! : 10002

	void CQuestManager::Select(unsigned int pc, unsigned int selection)
	{
		PC* pPC;

		if ((pPC = GetPC(pc)) && pPC->IsRunning() && pPC->GetRunningQuestState()->suspend_state==SUSPEND_STATE_SELECT)
		{
			pPC->SetSendDoneFlag();

			if (!pPC->GetRunningQuestState()->chat_scripts.empty())
			{
				// 채팅 이벤트인 경우
				// 현재 퀘스트는 어느 퀘스트를 실행할 것인가를 고르는 퀘스트 이므로
				// 끝내고 선택된 퀘스트를 실행한다.
				QuestState& old_qs = *pPC->GetRunningQuestState();
				CloseState(old_qs);

				if (selection >= pPC->GetRunningQuestState()->chat_scripts.size())
				{
					pPC->SetSendDoneFlag();
					GotoEndState(old_qs);
					pPC->EndRunning();
				}
				else
				{
					AArgScript* pas = pPC->GetRunningQuestState()->chat_scripts[selection];
					ExecuteQuestScript(*pPC, pas->quest_index, pas->state_index, pas->script.GetCode(), pas->script.GetSize());
				}
			}
			else
			{
				// on default 
				pPC->GetRunningQuestState()->args=1;
				lua_pushnumber(pPC->GetRunningQuestState()->co,selection+1);

				if (!RunState(*pPC->GetRunningQuestState()))
				{
					CloseState(*pPC->GetRunningQuestState());
					pPC->EndRunning();
				}
			}
		}
		else
		{
			sys_err("wrong QUEST_SELECT request! : %d",pc);
		}
	}

 

[Daenerys 174]

this is not an error. The ESC is reporting the ESC when it is used, just in case.
 

[daradevil124 369]

3 hours ago, Daenerys said:

this is not an error. The ESC is reporting the ESC when it is used, just in case.
 

Here is the video about my problem;

 

[daradevil124 369]

bumpp

[Daenerys 174]

Again, this is not an error.just notification.
 

[Exygo 1087]

void CQuestManager::Select(unsigned int pc, unsigned int selection)
	{
		PC* pPC;

		if ((pPC = GetPC(pc)) && pPC->IsRunning() && pPC->GetRunningQuestState()->suspend_state==SUSPEND_STATE_SELECT)
		{
			pPC->SetSendDoneFlag();

			if (!pPC->GetRunningQuestState()->chat_scripts.empty())
			{
				// äĆĂ ŔĚşĄĆ®ŔÎ °ćżě
				// ÇöŔç Äů˝şĆ®´Â ľî´Ŕ Äů˝şĆ®¸¦ ˝ÇÇŕÇŇ °ÍŔΰˇ¸¦ °í¸Ł´Â Äů˝şĆ® Ŕ̹ǷÎ
				// łˇł»°í Ľ±ĹĂµČ Äů˝şĆ®¸¦ ˝ÇÇŕÇŃ´Ů.
				QuestState& old_qs = *pPC->GetRunningQuestState();
				CloseState(old_qs);

				if (selection >= pPC->GetRunningQuestState()->chat_scripts.size())
				{
					pPC->SetSendDoneFlag();
					GotoEndState(old_qs);
					pPC->EndRunning();
				}
				else
				{
					AArgScript* pas = pPC->GetRunningQuestState()->chat_scripts[selection];
					ExecuteQuestScript(*pPC, pas->quest_index, pas->state_index, pas->script.GetCode(), pas->script.GetSize());
				}
			}
			else
			{
				// on default 
				pPC->GetRunningQuestState()->args=1;
				if (!pPC->GetRunningQuestState()->co) // fix 2 februarie 2018
					sys_err("GetRunningQuestState()->co is null");
				else
					lua_pushnumber(pPC->GetRunningQuestState()->co,selection+1);

				if (!RunState(*pPC->GetRunningQuestState()))
				{
					CloseState(*pPC->GetRunningQuestState());
					pPC->EndRunning();
				}
			}
		}
		else
		{
			// Better handling 5 februarie 2018 by Exygo
			if ((pPC = GetPC(pc)) && pPC->IsRunning() && pPC->GetRunningQuestState()->suspend_state == SUSPEND_STATE_PAUSE)
				return;

			sys_err("wrong QUEST_SELECT request for pc %d (getPC %d isRunning %d GetRunningQuestState %d)",
				int(pc),
				(pPC = GetPC(pc)) ? true : false,
				(pPC = GetPC(pc)) ? true : false ? pPC->IsRunning() : false,
				(pPC = GetPC(pc)) ? true : false ? pPC->GetRunningQuestState()->suspend_state : -1
			);
		}
	}

 

8 minutes ago, Daenerys said:

Again, this is not an error.just notification.
 

Yes, but sometimes the quest window remains frozen and it's unconfortable.

[daradevil124 369]

man think simple, this is an error.

Because its not comfortable for users.

look at the video mk

 

dear @Exygo its a fix?

##

 

update

same, i thin its just syserr hiding?

New syserr after apply this fix (or whatelse)

SYSERR: Feb 6 02:17:45 :: Select: wrong QUEST_WAIT request! : 10002

[Syreldar 1867]

1 hour ago, Exygo said:

			sys_err("wrong QUEST_SELECT request for pc %d (getPC %d isRunning %d GetRunningQuestState %d)",
				int(pc),
				(pPC = GetPC(pc)) ? true : false,
				(pPC = GetPC(pc)) ? true : false ? pPC->IsRunning() : false,
				(pPC = GetPC(pc)) ? true : false ? pPC->GetRunningQuestState()->suspend_state : -1
			);

 

 

ehm..

[daradevil124 369]

yes another solition ? 

[passaport 0]

UP! I need this fix too ,i tried to change sys_err to sys_log but when i press esc on quest run the taskbar is loking and i need to run again the quest to unlock.

[daradevil124 369]

Well, thanks for all the answers. I solved the problem myself.

[passaport 0]

@daradevil124 can you tell us how do you fix the problem ?

 

Thanks

[TRBizeps 48]

vor 5 Stunden schrieb passaport:

@daradevil124 can you tell us how do you fix the problem ?

 

Thanks

 

Well, can you tell us why he should publish the solution? I mean look at the posts above .. ridiculous.

[daradevil124 369]

Just use your logic.