Problem effect swords C++

[Ryen 43]

Hi guys im have one peoble...

 

im add a new efect from my new seet weapons but this happens to me:

CODE

Instancebase.cpp

    case CItemData::ITEM_TYPE_WEAPON:
        __ClearWeaponRefineEffect();
        //Agregas Nuevos Efectos
        if (pItem->GetSubType() == CItemData::WEAPON_SWORD)
        {
            DWORD vnum = pItem->GetIndex();

            if (vnum == 60299)
            {
                __AttachEffect(EFFECT_REFINED + EFFECT_SWORD_REFINED_SPECIAL1); //effect 24 sword effect
            }
        }

 

InstanceBase.h

 

            EFFECT_BODYARMOR_SPECIAL,    // °©¿Ê 4-2-1
            EFFECT_BODYARMOR_SPECIAL2,    // °©¿Ê 4-2-2
            EFFECT_ACCE_SPECIAL,

            EFFECT_SWORD_REFINED_SPECIAL1 = 23, // effect new

            EFFECT_REFINED_NUM,

 

 

playersettingmodule.py

 

    chrmgr.RegisterEffect(chrmgr.EFFECT_REFINED+23, "PART_WEAPON", "D:/ymir work/pc/common/effect/sword/revo_espada_s.mse")
 

any ideas?

 

Regards

Edited August 20, 2022 by Metin2 Dev
Core X - External 2 Internal

[Sirio 175]

Try this

 

if (pItem->GetSubType() == CItemData::WEAPON_SWORD)
        {
            DWORD vnum = pItem->GetIndex();

            if (vnum == 60299)
            {
                __ClearWeaponRefineEffect();
                m_swordRefineEffectRight = EFFECT_REFINED + EFFECT_SWORD_REFINED7 + refine - 7;
                m_swordRefineEffectRight = EFFECT_REFINED +  EFFECT_SWORD_REFINED_SPECIAL1; //effect 24 sword effect
            }
        }

[xP3NG3Rx 14189]

Seems syntax error.

But what's the problem?

If you unequip the new weapon, the effect will not removed?

[Ryen 43]

3 hours ago, xP3NG3Rx said:

Seems syntax error.

But what's the problem?

If you unequip the new weapon, the effect will not removed?

Yeah bro.,...

 

3 hours ago, Sirio said:

Try this

 

if (pItem->GetSubType() == CItemData::WEAPON_SWORD)
        {
            DWORD vnum = pItem->GetIndex();

            if (vnum == 60299)
            {
                __ClearWeaponRefineEffect();
                m_swordRefineEffectRight = EFFECT_REFINED + EFFECT_SWORD_REFINED7 + refine - 7;
                m_swordRefineEffectRight = EFFECT_REFINED +  EFFECT_SWORD_REFINED_SPECIAL1; //effect 24 sword effect
            }
        }

and probe that ... and not work

[BackPlayer 52]

nice weapon!

[sananemk 5]

I think this way use

if (pItem->GetSubType() == CItemData::WEAPON_SWORD)
        {
            DWORD vnum = pItem->GetIndex();

            if (vnum == 60299)
            // if (60299 <= vnum && vnum <= 60999)
            {
                m_swordRefineEffectRight = EFFECT_REFINED + EFFECT_SWORD_REFINED7;
                m_swordRefineEffectRight = EFFECT_REFINED +  EFFECT_SWORD_REFINED_SPECIAL1; //effect 24 sword effect
            }
        }