When i add the code to CGuildManager::CreateGuild which fixes sql injection players can create 2 guilds with the same name, are there any fix about it?

[xCoRPeR 21]

When i add the code to CGuildManager::CreateGuild which fixes sql injection players can create 2 guilds with the same name, are there any fix about it?

 

Code:

 

Spoiler

DWORD CGuildManager::CreateGuild(TGuildCreateParameter& gcp)
{
    if (!gcp.master)
        return 0;

    if (!check_name(gcp.name))
    {
        gcp.master->ChatPacket(CHAT_TYPE_INFO, LC_TEXT("<길드> 길드 이름이 적합하지 않습니다."));
        return 0;
    }
    
    static char __escape_name[GUILD_NAME_MAX_LEN * 2 + 1];
    DBManager::instance().EscapeString(__escape_name, sizeof(__escape_name), static_cast<const char *>(gcp.name), sizeof(gcp.name));
    
    std::auto_ptr<SQLMsg> pmsg(DBManager::instance().DirectQuery("SELECT COUNT(*) FROM guild%s WHERE name = '%s'",
                get_table_postfix(), __escape_name));

    if (pmsg->Get()->uiNumRows > 0)
    {
        MYSQL_ROW row = mysql_fetch_row(pmsg->Get()->pSQLResult);

        if (!(row[0] && row[0][0] == '0'))
        {
            gcp.master->ChatPacket(CHAT_TYPE_INFO, LC_TEXT("<길드> 이미 같은 이름의 길드가 있습니다."));
            return 0;
        }
    }
    else
    {
        gcp.master->ChatPacket(CHAT_TYPE_INFO, LC_TEXT("<길드> 길드를 생성할 수 없습니다."));
        return 0;
    }

    // new CGuild(gcp) queries guild tables and tell dbcache to notice other game servers.
    // other game server calls CGuildManager::LoadGuild to load guild.
    CGuild * pg = M2_NEW CGuild(gcp);
    m_mapGuild.insert(std::make_pair(pg->GetID(), pg));
    return pg->GetID();
}

 

[Ken 891]

Nova's second fix about MakeGuild is useless for me because the system is already checking alpha characters. (check_name). Before implementing the fix, you have to test the SQL injection. If the system does not check the alpha characters, that means you have many SQL injections in the source files. 

For example;

 

pc.change_name (Quest)
CInputLogin::ChangeName() - net.SendChangeCharacterNamePacket()
CInputLogin::CharacterCreate()
horse.set_name()

Kind Regards ~ Ken

[BackPlayer 55]

how can test my source for sql injections?

[xCoRPeR 21]

UP ( problem continues )

[ds_aim 239]

39 minutes ago, xCoRPeR said:

UP ( problem continues )

Man , u are blind?

Ken answered you.

It's not necesarry fix in guild.    USE ORIGINAL codes in guild.

You need to fix just messenger_manager.    In guild don't work sql injection.

[BeHappy4Ever 235]

On 26/12/2015 at 1:48 AM, BackPlayer said:

how can test my source for sql injections?

I think Anemus is okay,you can test it via using the exploit -.-