Help with GetQuestFlag exploit fix.

[Shang 364]

Hi devs,

I have a problem with an exploit with CHARACTER::GetQuestFlag. When the char calls a getqf, and he disconnects quickly, the player_id is 0 and core crashes.

I already have a fix i found on epvp but it doesn't work. The core is still crashing.

I have this fix (char.cpp):

int CHARACTER::GetQuestFlag(const std::string& flag) const
{
	quest::CQuestManager& q = quest::CQuestManager::instance();
	quest::PC* pPC = q.GetPC(GetPlayerID());
	if(!pPC) {
		sys_err("Nullpointer in CHARACTER::GetQuestFlag %lu", GetPlayerID()); 
		return 0;
	}
	return pPC->GetFlag(flag);
}

	if(!pPC) {
		sys_err("Nullpointer in CHARACTER::GetQuestFlag %lu", GetPlayerID()); 
		return 0;
	}

In syserr it says "Nullpointer[...]" but it seems like the return 0 doesn't exists because the core crashes.

Then i need a fix... I hope one dev can make it.

[The Naid 117]

Please don't help this guy.
Why?
Because this guy is a thief.

[Shang 364]

Please don't help this guy.
Why?
Because this guy is a thief.

​A thief why?

[Shang 364]

#UP