Green & Purple Potions Effect

[Legend 185]

Hello devs.

 

I recently noticed that the green and purple potions doesn't send any effect so I decided to add one.

 

File: char_item.cpp

 

So let's begin, first of all find these two cases:

 

case APPLY_MOV_SPEED:

case APPLY_ATT_SPEED:

 

and under of each of them add this:

 

EffectPacket(SE_DXUP_PURPLE); //purple potion

EffectPacket(SE_SPEEDUP_GREEN); //green potion

 

After you do that search for this(this variable exists two times so you need to do this step two times):

 

AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);

 

and under that add this:

 

EffectPacket(SE_DXUP_PURPLE);

 

Kind Regards

Legend

[martysama0134 6974]

In the client, everything is already set to let the green/purple effects work.

You just need to add the relative effectpacket via game.

^ via game

[Galet 497]

Thanks !

 

[MrLibya 539]

Thx , But Where You Add IT ? In Any File's ?

[Morphe 154]

Thx , But Where You Add IT ? In Any File's ?

char_item.cpp

[whoyou55 1]

I added, but not work.

[Damixxx0101 6]

OMG why u no give name file .... where i must add this please help ; /

[Aemon 7]

It can do on 34k ?  

[Necro 74]

It can do on 34k ?

 

i think that isnt possiblle because of source code which 34k hasnt.

[Damixxx0101 6]

								switch (item->GetValue(0))
								{
									case APPLY_MOV_SPEED:
										AddAffect(affect_type, apply_type, apply_value, AFF_MOV_SPEED_POTION, apply_duration, 0, true, true);
										EffectPacket(SE_DXUP_PURPLE); //purple potion
										break;

									case APPLY_ATT_SPEED:
										AddAffect(affect_type, apply_type, apply_value, AFF_ATT_SPEED_POTION, apply_duration, 0, true, true);
										EffectPacket(SE_SPEEDUP_GREEN); //green potion
										break;

									long time = item->GetValue(0);
									long moveSpeedPer	= item->GetValue(1);
									long attPer	= item->GetValue(2);
									long expPer			= item->GetValue(3);
									AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);
									EffectPacket(SE_DXUP_PURPLE);
									AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_ATTBONUS, attPer, AFF_NONE, time, 0, true, true);
									AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_EXPBONUS, expPer, AFF_NONE, time, 0, true, true);
									item->SetCount(item->GetCount() - 1);

what wrong ?

[Despero 129]

Work fine !

 

Edited August 18, 2022 by Metin2 Dev
Core X - External 2 Internal

[Legend 185]

OMG why u no give name file .... where i must add this please help ; /

File: char_item.cpp

 

Kind Regards

Legend

[Galet 497]

Same for the Penetration effect, no ?

[Fliegex3 29]

Dont work for me.

[Despero 129]

Dont work for me.

Send me your char_item.cpp

[thespeedy 18]

dont work

[TheSLZ 104]

It works.

But i didn't find it twice:

AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);

But works, thanks 

Edited August 28, 2015 by TheSLZ

[thespeedy 18]

dont work -.-

[.plechito' 7486]

It does

[thespeedy 18]

 

AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);
EffectPacket(SE_DXUP_PURPLE);
AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_ATTBONUS, attPer, AFF_NONE, time, 0, true, true);
EffectPacket(SE_SPEEDUP_GREEN);
AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_EXPBONUS, expPer, AFF_NONE, time, 0, true, true);

 ok?

Edited September 2, 2015 by thespeedy

[WhiteWorld 31]

so I have residential and work

3x

    case APPLY_MOV_SPEED:
    case APPLY_ATT_SPEED:

1,

                                case APPLY_MOV_SPEED:
                                    AddAffect(AFFECT_UNIQUE_ABILITY, POINT_MOV_SPEED, item->GetValue(2), AFF_MOV_SPEED_POTION, item->GetValue(1), 0, true, true);
                                    EffectPacket(SE_DXUP_PURPLE); //purple potion
                                    break;

                                case APPLY_ATT_SPEED:
                                    AddAffect(AFFECT_UNIQUE_ABILITY, POINT_ATT_SPEED, item->GetValue(2), AFF_ATT_SPEED_POTION, item->GetValue(1), 0, true, true);
                                    EffectPacket(SE_SPEEDUP_GREEN); //green potion
                                    break;

2,

                                    case APPLY_MOV_SPEED:
                                        AddAffect(affect_type, apply_type, apply_value, AFF_MOV_SPEED_POTION, apply_duration, 0, true, true);
                                        EffectPacket(SE_DXUP_PURPLE); //purple potion
                                        break;

                                    case APPLY_ATT_SPEED:
                                        AddAffect(affect_type, apply_type, apply_value, AFF_ATT_SPEED_POTION, apply_duration, 0, true, true);
                                        EffectPacket(SE_SPEEDUP_GREEN); //green potion
                                        break;

3,

                                case APPLY_MOV_SPEED:
                                    AddAffect(AFFECT_MOV_SPEED, POINT_MOV_SPEED, item->GetValue(2), AFF_MOV_SPEED_POTION, item->GetValue(1), 0, true);
                                    EffectPacket(SE_DXUP_PURPLE); //purple potion
                                    break;

                                case APPLY_ATT_SPEED:
                                    AddAffect(AFFECT_ATT_SPEED, POINT_ATT_SPEED, item->GetValue(2), AFF_ATT_SPEED_POTION, item->GetValue(1), 0, true);
                                    EffectPacket(SE_SPEEDUP_GREEN); //green potion
                                    break;

 

and 1x

AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);

                                    AddAffect(AFFECT_NOG_ABILITY, POINT_MOV_SPEED, moveSpeedPer, AFF_MOV_SPEED_POTION, time, 0, true, true);
                                    EffectPacket(SE_DXUP_PURPLE); //purple potion
                                    AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_ATTBONUS, attPer, AFF_NONE, time, 0, true, true);
                                    AddAffect(AFFECT_NOG_ABILITY, POINT_MALL_EXPBONUS, expPer, AFF_NONE, time, 0, true, true);

it works, thank you

[xP3NG3Rx 19155]

Here is a little fix to disable the double potion sounds (green & purple):

UI\PythonItem.cpp -> DWORD CPythonItem::__GetUseSoundType(const CItemData& c_rkItemData)
Search the case of the ability_up and replace it with this:
 

				case CItemData::USE_ABILITY_UP:
					{
						if ((c_rkItemData.GetIndex() == 27053 || c_rkItemData.GetIndex() == 27054) ||
							(c_rkItemData.GetIndex() >= 27100 && c_rkItemData.GetIndex() <= 27105) ||
							(c_rkItemData.GetIndex() >= 27110 && c_rkItemData.GetIndex() <= 27115))
							return USESOUND_NONE;
						else
							return USESOUND_POTION;
					}
					break;

This is an exception to block the playusesound when you are using an item from inventory:

netSendItemUsePacket -> CPythonNetworkStream::SendItemUsePacket -> __PlayInventoryItemUseSound

Because of the SpecificEffectPacket plays the sound of the potions as well.

[martysama0134 6974]

Someone linked me this old topic, and I figured out I never noticed those sounds played twice.

This is my fix: (PythonNetworkStreamPhaseGameItem.cpp)

There's no need to play those sounds.

Alternatively (based on penger's but via apply check): (but it's not of my taste) (PythonItem.cpp)

 

				case CItemData::USE_ABILITY_UP:
					if (c_rkItemData.GetValue(0) == CItemData::APPLY_MOV_SPEED || c_rkItemData.GetValue(0) == CItemData::APPLY_ATT_SPEED)
						return USESOUND_NONE;
					return USESOUND_POTION;

 

Edited January 29, 2023 by Metin2 Dev
Core X - External 2 Internal