Npc spawn and purge

[farmmedal 1]

Good day to you all!

I have got a little problem. I would like my quest to spawn an npc, then purge it - but! - if two players are doing the quest simultaneously, they can only purge "their" npc, they spawned.

I cannot figure out, why this quest is not working for me:

quest npcspawn begin
	state start begin
		when letter begin
			send_letter("NpcSpawn")
		end
		when button or info begin
			local x = (pc.get_local_x())
			local y = (pc.get_local_y())
			mob.spawn(4001, x+2, y+2, 2, 2, 1)
			game.set_event_flag("player", pc.get_player_id())
		end
		when 4001.click begin
			if game.get_event_flag("player") == (pc.get_player_id()) then
				say("jonapot")
				wait()
				say("aviszontlátásra")
				wait()
				game.set_event_flag("player", 0)
				npc.purge()
			else
			return
			end
		end
	end
end

I just do not understand, why this isnt working. I used the player id as a local number, yet when I tried it with two players, spawned them both and they purged the other else's spawned npc.

 

Anyone could help me please?

Thanks!

[Syreldar 1821]

That makes no sense. You're using the same global flag to save the player's id, meaning it will get overwritten every time a player opens the letter.

Also using a global flag, something which is used for events or global settings, to save a var for a player is something you totally should not do.

 

 

[farmmedal 1]

Of course, thought of that also, so I used pc.setqf after that - same results

What do you think, what should I use? 

[Sherer 459]

Simply use vid to bind spawned npc to a player (mob.spawn returns monster's vid in case if one was spawned and zero if spawned was somehow unsuccessful).

quest npcspawn begin
	state start begin
		when letter begin
			send_letter("NpcSpawn")
		end
		when button or info begin
			local x = (pc.get_local_x())
			local y = (pc.get_local_y())
			local iVID = mob.spawn(4001, x+2, y+2, 2, 2, 1)
			if iVID == 0 then
				say("Cannot spawn.")
			else
				pc.setqf("spawnedVID", iVID)
			end
		end
		when 4001.click begin
			if npc.get_vid() == pc.getqf("spawnedVID") then
				say("jonapot")
				wait()
				say("aviszontlátásra")
				wait()
				game.set_event_flag("player", 0)
				npc.purge()
			end
		end
	end
end

Edited August 23, 2022 by Sherer

[farmmedal 1]

I am going to try it right now, thanks! 

 

Edit: Works flawlessly, you have my greatest thanks!

Edited August 23, 2022 by farmmedal
new informations