SPAM MOUNT BUG (CTRL+F)

[DemOnJR 1215]

Hello, I found a bug when you use this system:

Spoiler

 

 

You can spam ctrl f g and you create lag on the server like this:

 

Spoiler

int MountSpam = ch->GetQuestFlag("mount.spam");
if (MountSpam)
{
    /* code */
    if (get_global_time() < MountSpam + 5)
    {
        /* code */
        ch->ChatPacket(CHAT_TYPE_INFO, "WAIT 5 SECONDS");
        return;
    }
}
ch->SetQuestFlag("mount.spam", get_global_time());

 

 

Spoiler

Edited September 4, 2022 by Metin2 Dev
Core X - External 2 Internal

[Gurgarath 3699]

1 hour ago, DemOnJR said:

solved

tell me more

[DemOnJR 1215]

13 minutes ago, Gurgarath said:

tell me more

I thought I solved it but it still an problem.

but I dont know how to make it when you go up to it 5 times after that it will block you 5 seconds.

 

Edit:

int MountSpam = ch->GetQuestFlag("mount.spam");
if (MountSpam)
{
	/* code */
	if (get_global_time() < MountSpam + 5)
	{
		/* code */
		ch->ChatPacket(CHAT_TYPE_INFO, "WAIT 5 SECONDS");
		return;
	}
}
ch->SetQuestFlag("mount.spam", get_global_time());

 

@Gurgarath

Edited April 12, 2020 by DemOnJR

[Mr.Black 146]

1 minute ago, DemOnJR said:

I thought I solved it but it still an problem.

but I dont know how to make it when you go up to it 5 times after that it will block you 5 seconds.

@Gurgarath

Selfish
I will never give u t ...

[DemOnJR 1215]

Just now, Mr.Black said:

Selfish
I will never give u t ...

what?

[DemOnJR 1215]

up

[Trukken 1]

Little late to the party, but here's my take.
 

	// Prevent user spam if used more than 6 times in a 5 second window
	const int mountSpam = ch->GetQuestFlag("mount.spam");
	int mountSpamTimeout = ch->GetQuestFlag("mount.spam_timeout");
	const long globalTime = get_global_time();

	if (mountSpam >= 6 || mountSpamTimeout != 0)
	{
		if (mountSpamTimeout == 0) {
			ch->SetQuestFlag("mount.spam_timeout", globalTime);
			mountSpamTimeout = globalTime;
		}
		ch->SetQuestFlag("mount.spam", 0);
		if (globalTime < mountSpamTimeout + 5)
		{
			ch->ChatPacket(CHAT_TYPE_INFO, "WAIT 5 SECONDS");
			return;
		}
		ch->SetQuestFlag("mount.spam_timeout", 0);
	}

	ch->SetQuestFlag("mount.spam", std::max(mountSpam + 1, 1));

Let me know if you have a better solution.

[Trukken 1]

On 10/7/2025 at 1:30 PM, Trukken said:

Little late to the party, but here's my take.
 

	// Prevent user spam if used more than 6 times in a 5 second window
	const int mountSpam = ch->GetQuestFlag("mount.spam");
	int mountSpamTimeout = ch->GetQuestFlag("mount.spam_timeout");
	const long globalTime = get_global_time();

	if (mountSpam >= 6 || mountSpamTimeout != 0)
	{
		if (mountSpamTimeout == 0) {
			ch->SetQuestFlag("mount.spam_timeout", globalTime);
			mountSpamTimeout = globalTime;
		}
		ch->SetQuestFlag("mount.spam", 0);
		if (globalTime < mountSpamTimeout + 5)
		{
			ch->ChatPacket(CHAT_TYPE_INFO, "WAIT 5 SECONDS");
			return;
		}
		ch->SetQuestFlag("mount.spam_timeout", 0);
	}

	ch->SetQuestFlag("mount.spam", std::max(mountSpam + 1, 1));

Let me know if you have a better solution.

Looking back at it, it's actually garbage code.
Do this instead:
service.h
 

#define ENABLE_BLOCK_RIDE_SPAM                          // < Block Do Ride Spam

char.h
 

// Search
const CHARACTER_SET& GetChainLightingExcept() const { return m_setExceptChainLighting; }

// Add after

#ifdef ENABLE_BLOCK_RIDE_SPAM
		int					m_iRideSpamBlockAfter;
		int					m_iRideSpamTime;
#endif

 

cmd_general.cpp

// Search, the curly bracket { might be on the same line!
ACMD(do_ride)
{

// Add BEFORE
#ifdef ENABLE_BLOCK_RIDE_SPAM
/**
 * Determine wether the player is spamming do_ride
 */
bool isLimitedToMount(LPCHARACTER ch){
	constexpr int timeoutSeconds = 5;

	if ((thecore_pulse() < (ch->m_iRideSpamTime + timeoutSeconds * 25)))
	{
		if (ch->m_iRideSpamBlockAfter < 6)
		{
			ch->m_iRideSpamBlockAfter++;
			return false;
		}

		return true;
	}

	ch->m_iRideSpamBlockAfter = 0;

	ch->m_iRideSpamTime = thecore_pulse();
	return false;
}
#endif

// Now go back to
ACMD(do_ride)
{
  
// Add AFTER
#ifdef ENABLE_BLOCK_RIDE_SPAM
	if (isLimitedToMount(ch)) {
		ch->ChatPacket(CHAT_TYPE_INFO, "WAIT 5 SECONDS");
		return;
	}
#endif

Pros:
- It actually works
- Uses memory instead of DB
- Won't get an integer overflow at Epochalypse