Two littles bugs

[Galet 498]

Hello, I have two little annoying bugs.

Indeed, they are probably simple to fix, but I'm not sure if I'm right, so I don't want to make an alternative solution.

The first bug is :

Everybody can drop a skillbook but nobody can drop a wolfman's skillbook, so the wolfman's skills are locked at M1.

The second one is :

I can't open some boxes (e.g Cor Draconis, Apprentice Chest, Chest of Darkness and so on...) I think the problem come from special_item_group but I don't know why...

 

Thanks, and have a nice day !

Edited August 24, 2022 by Metin2 Dev
Core X - External 2 Internal

[luzzo 193]

According with first problem, if you are talking about 50300 skillbook you can fix in this way

Open char.cpp

 

Find

void CHARACTER::GiveRandomSkillBook()

 

In this function you have to edit this

dwSkillVnum = number(1, 111);

 

changing 111 with last lycan's skill value

Edited July 4, 2015 by luzzo

[Galet 498]

Is there's a risk to drop a skillbook with for example an unexisting number ? e.g if the number is 155, there'snt any skill referenced by the n°155, I'll drop a virgin skillbook or a bugged one ?

Thanks anyway, because my old function was :

            if (number(1, 3) == 2)
            {
                dwSkillVnum = number(170, 175);
            }
            else
            {
                dwSkillVnum = number(1, 111);
            }

[luzzo 193]

No there isn't. In the same funtion there is a check for a valid skill value.

 

Or to be more clear you can even check that the type of skill is not 0 (like sun zii etc.)

 

for example

 

Edited August 19, 2022 by Metin2 Dev
Core X - External 2 Internal

[Galet 498]

Strangely, In more than 250 skillbooks, 0 was a wolfman skillbook...

Edited July 4, 2015 by galet

[luzzo 193]

Obviously in this way you have the same drop percentage for each book but the game will do more clicle becase there is an hight range of non valid value.

[Galet 498]

I'll retry, I've made some changes in my game source to see

[Galet 498]

Same problem, It's annoying because I don't know where I failed

[luzzo 193]

my fail sorry.

There is another part to modify.

The fist one you edited is right and is for /do_book or for 50300 from box.

The missing part is for 50300 drop on ground.

 

Open item_manager.cpp

 

search for

if (vnum == 50300 || vnum == ITEM_SKILLFORGET_VNUM)

 

and edit like this

Edited August 19, 2022 by Metin2 Dev
Core X - External 2 Internal

[Galet 498]

I'll tell you, but now (and I f***ing don't know why) my sources crashes...

 

Edit : I don't know if it's working but I have skillbooks for guild skills for example, thoses skill books just crash my game...

Edited July 4, 2015 by galet

[luzzo 193]

if you have guilds skillbooks you haven't added the controll that i wrote about it.

[Galet 498]

Sorry, I didn't see it...

[Galet 498]

if you have guilds skillbooks you haven't added the controll that i wrote about it.

Hello, first of all, thanks ! Indeed, I have wolfman's skillbooks, but I still have guild's skillbooks...

The check in item_manager.cpp :

 

            do
            {
                dwSkillVnum = number(1, 175);
                CSkillProto * pkSk = CSkillManager::instance().Get(dwSkillVnum);
                if (!pkSk)
                    continue;
                if (dwSkillVnum > 111 && dwSkillVnum < 170)
                    continue;
                break;
            } while (1);

Thank you and have a nice day !

I still have the second problem though...

Edited July 10, 2015 by galet

[Galet 498]

Ok, fixed thanks to Luzzo !

 

Only the second bug remains