Sura Mirage bug skill without sword

[NesT 1]

Hey guys,

The sura mirage have a bug, when you make AOS ( aura of sword ) without the weapon , the player makes huge damage which hitting like that.

Any fix for that ?

 

[mustafa41416 0]

Hi

34k Diff ;

 

This difference file has been created

game_r34083
00046659: 63 2C
0004665A: E8 6F
0004665B: FD 00
0004665C: FF 00

[NesT 1]

Hey , thanks for help man.

But im using source, you know its fix ?

[DevSheeN 13]

Hi

34k Diff ;

 

This difference file has been created

game_r34083

00046659: 63 2C

0004665A: E8 6F

0004665B: FD 00

0004665C: FF 00

 

Ne ara benim diffimi verir oldun lan.

[Exygo 1086]

Hey guys,

The sura mirage have a bug, when you make AOS ( aura of sword ) without the weapon , the player makes huge damage which hitting like that.

Any fix for that ?

 

I have a temporary fix for that to prevent player using that skill without weapon.

[propc 9]

up+

[Benhero 23]

Try this in CHARACTER::Attack()

Shout Work

 

One Moment! This is for "Aura of Sword"..

I'll made it 4 Sura to.

 

#edit.. I post it after i test it xD

[Benhero 23]

So Add this in the First Line of

bool CHARACTER::Damage()

if (pAttacker->IsAffectFlag(AFF_GEOMGYEONG) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GEOMKYUNG);
}
if (pAttacker->IsAffectFlag(AFF_GWIGUM) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GWIGEOM);
}

It will Automatic Deacitvate Aura & Sura Sword if you hit Someone!

 

Greatz

[Speachless 757]

So Add this in the First Line of

bool CHARACTER::Damage()

if (pAttacker->IsAffectFlag(AFF_GEOMGYEONG) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GEOMKYUNG);
}
if (pAttacker->IsAffectFlag(AFF_GWIGUM) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GWIGEOM);
}

It will Automatic Deacitvate Aura & Sura Sword if you hit Someone!

 

Greatz

In what cpp file ?

[JachuPL 308]

 

So Add this in the First Line of

bool CHARACTER::Damage()

if (pAttacker->IsAffectFlag(AFF_GEOMGYEONG) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GEOMKYUNG);
}
if (pAttacker->IsAffectFlag(AFF_GWIGUM) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GWIGEOM);
}

It will Automatic Deacitvate Aura & Sura Sword if you hit Someone!

 

Greatz

In what cpp file ?

 

char_battle.cpp:1603 in my case

[The Naid 118]

So Add this in the First Line of

bool CHARACTER::Damage()

if (pAttacker->IsAffectFlag(AFF_GEOMGYEONG) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GEOMKYUNG);
}
if (pAttacker->IsAffectFlag(AFF_GWIGUM) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GWIGEOM);
}

It will Automatic Deacitvate Aura & Sura Sword if you hit Someone!

 

Greatz

 

Nice coredowner.

[PeaceMaker 121]

So Add this in the First Line of

bool CHARACTER::Damage()

if (pAttacker->IsAffectFlag(AFF_GEOMGYEONG) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GEOMKYUNG);
}
if (pAttacker->IsAffectFlag(AFF_GWIGUM) && !pAttacker->GetWear(WEAR_WEAPON))
{
    pAttacker->RemoveAffect(SKILL_GWIGEOM);
}

It will Automatic Deacitvate Aura & Sura Sword if you hit Someone!

 

Greatz

 

Nice coredowner.

Tested and yes its a core downer...

Any other fix?

[wezt 95]

Hey, as far I understand from source, huge damage for skills without weapon happening because in such cases doesn't calculate weapon resistance (sword resistance for sura).

In char_skill.cpp at

case SKILL_ATTR_TYPE_MELEE:

You can see how calculate dmg, for example:

					if (pkWeapon)
						switch (pkWeapon->GetSubType())
						{
							case WEAPON_SWORD:
								iDam = iDam * (100 - pkChrVictim->GetPoint(POINT_RESIST_SWORD)) / 100;
								break;

So I've added this part after "switch" (probably not a best way to fix):
 

if (m_pkChr->GetJob() == JOB_SURA && !pkWeapon)
    iDam = iDam * (100 - pkChrVictim->GetPoint(POINT_RESIST_SWORD)) / 100;

 

With current changes for sura skills without weapon, core keep using sword resistance for damage calculation.

 

[MityQ 5]

in char_skill.cpp, add this:

if ((dwVnum == SKILL_GEOMKYUNG || dwVnum == SKILL_GWIGEOM) && !GetWear(WEAR_WEAPON))

	            return false;

under this:

   
      

bool CHARACTER::UseSkill(DWORD dwVnum, LPCHARACTER pkVictim, bool bUseGrandMaster)

	{

	    if (false == CanUseSkill(dwVnum))

	        return false;