Great OfflineShop db leak fix

[Kuqsal 241]

Dear friends,

I found a SQL-side bug in the "Great Shop" system that was causing the `player.item` table to bloat. I have fixed it—the implementation is shown below—but I would like to ask for your opinion: do you consider this an optimized and correct fix?


Thank you in advance for your comments, and I wish you success in life.

void ITEM_MANAGER::SaveSingleItem(LPITEM item)
{
	
#ifdef ENABLE_FIX_SKIPSAVE_ITEM_LEAK
	if (item->GetSkipSave())
			return;
#endif

	if (!item->GetOwner())
	{
		DWORD dwID = item->GetID();
		DWORD dwOwnerID = item->GetLastOwnerPID();

		db_clientdesc->DBPacketHeader(HEADER_GD_ITEM_DESTROY, 0, sizeof(DWORD) + sizeof(DWORD));
		db_clientdesc->Packet(&dwID, sizeof(DWORD));
		db_clientdesc->Packet(&dwOwnerID, sizeof(DWORD));

		sys_log(1, "ITEM_DELETE %s:%u", item->GetName(), dwID);
		return;
	}

	sys_log(1, "ITEM_SAVE %s:%d in %s window %d", item->GetName(), item->GetID(), item->GetOwner()->GetName(), item->GetWindow());

	TPlayerItem t;

	t.id = item->GetID();
	t.window = item->GetWindow();
	switch (t.window)
	{
		case EQUIPMENT:
			t.pos = item->GetCell() - INVENTORY_MAX_NUM;
			break;
#ifdef ENABLE_BELT_INVENTORY_EX
		case INVENTORY:
			if (BELT_INVENTORY_SLOT_START <= item->GetCell() && BELT_INVENTORY_SLOT_END > item->GetCell())
			{
				t.window = BELT_INVENTORY;
				t.pos = item->GetCell() - BELT_INVENTORY_SLOT_START;
				break;
			}
#endif
		default:
			t.pos = item->GetCell();
			break;
	}
	t.count = item->GetCount();
	t.vnum = item->GetOriginalVnum();
	switch (t.window)
	{
		case SAFEBOX:
		case MALL:
			t.owner = item->GetOwner()->GetDesc()->GetAccountTable().id;
			break;
		default:
			t.owner = item->GetOwner()->GetPlayerID();
			break;
	}
	thecore_memcpy(t.alSockets, item->GetSockets(), sizeof(t.alSockets));
	thecore_memcpy(t.aAttr, item->GetAttributes(), sizeof(t.aAttr));
#ifdef ENABLE_SOULBIND_SYSTEM 
	t.sealbind = item->GetSealBindTime();
#endif
	db_clientdesc->DBPacketHeader(HEADER_GD_ITEM_SAVE, 0, sizeof(TPlayerItem));
	db_clientdesc->Packet(&t, sizeof(TPlayerItem));
}






LPITEM ITEM_MANAGER::CreateItem(DWORD vnum, DWORD count, DWORD id, bool bTryMagic, int iRarePct, bool bSkipSave) --inside


#ifdef ENABLE_FIX_SKIPSAVE_ITEM_LEAK
		item->SetSkipSave(bSkipSave);
#else
		item->SetSkipSave(false);
#endif

@ Amun @ martysama0134 @ Intel @ Karbust @ Geoffrey @ Mali @ Owsap @ Distraught