[Fix] Guild name "Noname" after leaving a guild

[Kori 524]

First of all: Thanks to Mitachi for the question on Discord and to Sauber for explaining how something like this happens.

Reason: On guild leave the client called CPythonGuild::Destroy(), which wiped the whole
guild name cache (m_GuildNameMap), including the names of other guilds. The server sends
each guild name only once per session (CHARACTER::m_known_guild), so every text tail
created afterwards fell back to "Noname" until relog.


 

Spoiler

Files:
- UserInterface/PythonGuild.h
- UserInterface/PythonGuild.cpp
- UserInterface/PythonNetworkStreamPhaseGame.cpp

 

1) PythonGuild.h — Find:

		void Destroy();

Replace with:

		void Destroy();
		void LeaveGuild();


2) PythonGuild.h — Find:

		void __Initialize();

Replace with:

		void __ResetGuildData();
		void __Initialize();


3) PythonGuild.cpp — Find:

	void CPythonGuild::__Initialize()
	{
		ZeroMemory(&m_GuildInfo, sizeof(m_GuildInfo));
		ZeroMemory(&m_GuildSkillData, sizeof(m_GuildSkillData));
		ZeroMemory(&m_adwEnemyGuildID, ENEMY_GUILD_SLOT_MAX_COUNT*sizeof(DWORD));
		m_GradeDataMap.clear();
		m_GuildMemberDataVector.clear();
		m_dwMemberLevelSummary = 0;
		m_dwMemberLevelAverage = 0;
		m_bGuildEnable = FALSE;
		m_GuildNameMap.clear();
	}

	void CPythonGuild::Destroy()
	{
		__Initialize();
	}

Replace with:

	void CPythonGuild::__ResetGuildData()
	{
		ZeroMemory(&m_GuildInfo, sizeof(m_GuildInfo));
		ZeroMemory(&m_GuildSkillData, sizeof(m_GuildSkillData));
		ZeroMemory(&m_adwEnemyGuildID, ENEMY_GUILD_SLOT_MAX_COUNT*sizeof(DWORD));
		m_GradeDataMap.clear();
		m_GuildMemberDataVector.clear();
		m_dwMemberLevelSummary = 0;
		m_dwMemberLevelAverage = 0;
		m_bGuildEnable = FALSE;
	}

	void CPythonGuild::__Initialize()
	{
		__ResetGuildData();
		m_GuildNameMap.clear();
	}

	void CPythonGuild::Destroy()
	{
		__Initialize();
	}

	void CPythonGuild::LeaveGuild()
	{
		if (0 != m_GuildInfo.dwGuildID && '\0' != m_GuildInfo.szGuildName[0])
			m_GuildNameMap[m_GuildInfo.dwGuildID] = m_GuildInfo.szGuildName;

		__ResetGuildData();
	}


4) PythonNetworkStreamPhaseGame.cpp — In CPythonNetworkStream::RecvGuildSub_Remove(),
   find:

		CPythonGuild::Instance().Destroy();

Replace with:

		CPythonGuild::Instance().LeaveGuild();

 

have a nice day

[Mitachi 3366]

I'm working on my 5.2, so I wrote down a list of bugs to fix, but I couldn't remember how to reproduce this particular one. I guess I need to be careful when asking on Metin2Dev how to trigger bugs I'm already working on, unless I want to see the fix published the very next day just to farm some rep.

Shit happens, however:

a desync there in PythonNetworkStreamPhaseGame.cpp:

		case GUILD_SUBHEADER_GC_GUILD_INVITE:
		{
			DWORD dwGuildID;
			if (!Recv(sizeof(dwGuildID), &dwGuildID))
				return false;
			char szGuildName[GUILD_NAME_MAX_LEN+1];
			if (!Recv(GUILD_NAME_MAX_LEN + 1, &szGuildName)) /* @mitafix.client.44 */
				return false;

			szGuildName[GUILD_NAME_MAX_LEN] = 0;

			PyCallClassMemberFunc(m_apoPhaseWnd[PHASE_WINDOW_GAME], "RecvGuildInviteQuestion", Py_BuildValue("(is)", dwGuildID, szGuildName));
			Tracef(" <Guild Invite> %d, %s\n", dwGuildID, szGuildName);
			break;
		}

This was causing:

When you invite someone in the guild, he accept but he can't see the guild name above his head (only in the new member client) a simple UpdatePacket will fix, like equipping/unequipping something.

What I was doing to make it happen (not all process are needed ig):

1. Log in with two characters: the guild leader and a guild member.
2. Disband the guild.
3. Create a new guild using the same character as leader.
4. Invite the former member to the newly created guild.

This doesn't happen every time due to packet timing/buffering. Depending on how the packets are grouped and processed, the leftover byte doesn't always result in the same visible failure, so you may try 2/3 times before to notice the bug.